Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml
@ 2020-12-18 12:05 Johan Jonker
  2020-12-18 12:05 ` [PATCH 2/8] ARM: dts: rockchip: add new watchdog compatible to rv1108.dtsi Johan Jonker
                   ` (9 more replies)
  0 siblings, 10 replies; 15+ messages in thread
From: Johan Jonker @ 2020-12-18 12:05 UTC (permalink / raw)
  To: heiko
  Cc: robh+dt, wim, linux, jamie, linux-watchdog, devicetree,
	linux-kernel, linux-arm-kernel, linux-rockchip

The watchdog compatible strings are suppose to be SoC orientated.
In the more recently added Rockchip SoC dtsi files only
the fallback string "snps,dw-wdt" is used, so add the following
compatible strings:

"rockchip,px30-wdt", "snps,dw-wdt"
"rockchip,rk3228-wdt", "snps,dw-wdt"
"rockchip,rk3308-wdt", "snps,dw-wdt"
"rockchip,rk3328-wdt", "snps,dw-wdt"
"rockchip,rk3399-wdt", "snps,dw-wdt"
"rockchip,rv1108-wdt", "snps,dw-wdt"

make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
index f7ee9229c..b58596b18 100644
--- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
@@ -18,10 +18,16 @@ properties:
       - const: snps,dw-wdt
       - items:
           - enum:
+              - rockchip,px30-wdt
               - rockchip,rk3066-wdt
               - rockchip,rk3188-wdt
+              - rockchip,rk3228-wdt
               - rockchip,rk3288-wdt
+              - rockchip,rk3308-wdt
+              - rockchip,rk3328-wdt
               - rockchip,rk3368-wdt
+              - rockchip,rk3399-wdt
+              - rockchip,rv1108-wdt
           - const: snps,dw-wdt
 
   reg:
-- 
2.11.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 2/8] ARM: dts: rockchip: add new watchdog compatible to rv1108.dtsi
  2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
@ 2020-12-18 12:05 ` Johan Jonker
  2020-12-18 12:05 ` [PATCH 3/8] ARM: dts: rockchip: add new watchdog compatible to rk322x.dtsi Johan Jonker
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Johan Jonker @ 2020-12-18 12:05 UTC (permalink / raw)
  To: heiko
  Cc: robh+dt, wim, linux, jamie, linux-watchdog, devicetree,
	linux-kernel, linux-arm-kernel, linux-rockchip

The watchdog compatible strings are suppose to be SoC orientated.
In the more recently added Rockchip rv1108.dtsi file only
the fallback string "snps,dw-wdt" is used, so add the new
compatible string:

"rockchip,rv1108-wdt", "snps,dw-wdt"

make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm/boot/dts/rv1108.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index e491964b1..8ef8d038e 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -300,7 +300,7 @@
 	};
 
 	watchdog: watchdog@10360000 {
-		compatible = "snps,dw-wdt";
+		compatible = "rockchip,rv1108-wdt", "snps,dw-wdt";
 		reg = <0x10360000 0x100>;
 		interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&cru PCLK_WDT>;
-- 
2.11.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 3/8] ARM: dts: rockchip: add new watchdog compatible to rk322x.dtsi
  2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
  2020-12-18 12:05 ` [PATCH 2/8] ARM: dts: rockchip: add new watchdog compatible to rv1108.dtsi Johan Jonker
@ 2020-12-18 12:05 ` Johan Jonker
  2020-12-18 12:05 ` [PATCH 4/8] arm64: dts: rockchip: add new watchdog compatible to px30.dtsi Johan Jonker
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Johan Jonker @ 2020-12-18 12:05 UTC (permalink / raw)
  To: heiko
  Cc: robh+dt, wim, linux, jamie, linux-watchdog, devicetree,
	linux-kernel, linux-arm-kernel, linux-rockchip

The watchdog compatible strings are suppose to be SoC orientated.
In the more recently added Rockchip rk322x.dtsi file only
the fallback string "snps,dw-wdt" is used, so add the new
compatible string:

"rockchip,rk3228-wdt", "snps,dw-wdt"

make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm/boot/dts/rk322x.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
index 48e6e8d44..9910f9b5c 100644
--- a/arch/arm/boot/dts/rk322x.dtsi
+++ b/arch/arm/boot/dts/rk322x.dtsi
@@ -385,7 +385,7 @@
 	};
 
 	wdt: watchdog@110a0000 {
-		compatible = "snps,dw-wdt";
+		compatible = "rockchip,rk3228-wdt", "snps,dw-wdt";
 		reg = <0x110a0000 0x100>;
 		interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&cru PCLK_CPU>;
-- 
2.11.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 4/8] arm64: dts: rockchip: add new watchdog compatible to px30.dtsi
  2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
  2020-12-18 12:05 ` [PATCH 2/8] ARM: dts: rockchip: add new watchdog compatible to rv1108.dtsi Johan Jonker
  2020-12-18 12:05 ` [PATCH 3/8] ARM: dts: rockchip: add new watchdog compatible to rk322x.dtsi Johan Jonker
@ 2020-12-18 12:05 ` Johan Jonker
  2020-12-18 12:05 ` [PATCH 5/8] arm64: dts: rockchip: add new watchdog compatible to rk3308.dtsi Johan Jonker
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Johan Jonker @ 2020-12-18 12:05 UTC (permalink / raw)
  To: heiko
  Cc: robh+dt, wim, linux, jamie, linux-watchdog, devicetree,
	linux-kernel, linux-arm-kernel, linux-rockchip

The watchdog compatible strings are suppose to be SoC orientated.
In the more recently added Rockchip px30.dtsi file only
the fallback string "snps,dw-wdt" is used, so add the new
compatible string:

"rockchip,px30-wdt", "snps,dw-wdt"

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm64/boot/dts/rockchip/px30.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
index af6bcef9e..541785425 100644
--- a/arch/arm64/boot/dts/rockchip/px30.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
@@ -600,7 +600,7 @@
 	};
 
 	wdt: watchdog@ff1e0000 {
-		compatible = "snps,dw-wdt";
+		compatible = "rockchip,px30-wdt", "snps,dw-wdt";
 		reg = <0x0 0xff1e0000 0x0 0x100>;
 		clocks = <&cru PCLK_WDT_NS>;
 		interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.11.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 5/8] arm64: dts: rockchip: add new watchdog compatible to rk3308.dtsi
  2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
                   ` (2 preceding siblings ...)
  2020-12-18 12:05 ` [PATCH 4/8] arm64: dts: rockchip: add new watchdog compatible to px30.dtsi Johan Jonker
@ 2020-12-18 12:05 ` Johan Jonker
  2020-12-18 12:05 ` [PATCH 6/8] arm64: dts: rockchip: add new watchdog compatible to rk3328.dtsi Johan Jonker
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Johan Jonker @ 2020-12-18 12:05 UTC (permalink / raw)
  To: heiko
  Cc: robh+dt, wim, linux, jamie, linux-watchdog, devicetree,
	linux-kernel, linux-arm-kernel, linux-rockchip

The watchdog compatible strings are suppose to be SoC orientated.
In the more recently added Rockchip rk3308.dtsi file only
the fallback string "snps,dw-wdt" is used, so add the new
compatible string:

"rockchip,rk3308-wdt", "snps,dw-wdt"

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3308.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3308.dtsi b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
index 2560b9877..ad54acf5d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3308.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
@@ -244,7 +244,7 @@
 	};
 
 	wdt: watchdog@ff080000 {
-		compatible = "snps,dw-wdt";
+		compatible = "rockchip,rk3308-wdt", "snps,dw-wdt";
 		reg = <0x0 0xff080000 0x0 0x100>;
 		clocks = <&cru PCLK_WDT>;
 		interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.11.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 6/8] arm64: dts: rockchip: add new watchdog compatible to rk3328.dtsi
  2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
                   ` (3 preceding siblings ...)
  2020-12-18 12:05 ` [PATCH 5/8] arm64: dts: rockchip: add new watchdog compatible to rk3308.dtsi Johan Jonker
@ 2020-12-18 12:05 ` Johan Jonker
  2020-12-18 12:05 ` [PATCH 7/8] arm64: dts: rockchip: add new watchdog compatible to rk3399.dtsi Johan Jonker
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Johan Jonker @ 2020-12-18 12:05 UTC (permalink / raw)
  To: heiko
  Cc: robh+dt, wim, linux, jamie, linux-watchdog, devicetree,
	linux-kernel, linux-arm-kernel, linux-rockchip

The watchdog compatible strings are suppose to be SoC orientated.
In the more recently added Rockchip rk3328.dtsi file only
the fallback string "snps,dw-wdt" is used, so add the new
compatible string:

"rockchip,rk3328-wdt", "snps,dw-wdt"

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index bbdb19a3e..1e3e1086e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -453,7 +453,7 @@
 	};
 
 	wdt: watchdog@ff1a0000 {
-		compatible = "snps,dw-wdt";
+		compatible = "rockchip,rk3328-wdt", "snps,dw-wdt";
 		reg = <0x0 0xff1a0000 0x0 0x100>;
 		interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&cru PCLK_WDT>;
-- 
2.11.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 7/8] arm64: dts: rockchip: add new watchdog compatible to rk3399.dtsi
  2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
                   ` (4 preceding siblings ...)
  2020-12-18 12:05 ` [PATCH 6/8] arm64: dts: rockchip: add new watchdog compatible to rk3328.dtsi Johan Jonker
@ 2020-12-18 12:05 ` Johan Jonker
  2020-12-18 12:05 ` [PATCH 8/8] ARM: dts: rockchip: remove clock-names property from watchdog node in rv1108.dtsi Johan Jonker
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Johan Jonker @ 2020-12-18 12:05 UTC (permalink / raw)
  To: heiko
  Cc: robh+dt, wim, linux, jamie, linux-watchdog, devicetree,
	linux-kernel, linux-arm-kernel, linux-rockchip

The watchdog compatible strings are suppose to be SoC orientated.
In the more recently added Rockchip rk3399.dtsi file only
the fallback string "snps,dw-wdt" is used, so add the new
compatible string:

"rockchip,rk3399-wdt", "snps,dw-wdt"

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 2b99480ea..825eb254b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1536,7 +1536,7 @@
 	};
 
 	watchdog@ff848000 {
-		compatible = "snps,dw-wdt";
+		compatible = "rockchip,rk3399-wdt", "snps,dw-wdt";
 		reg = <0x0 0xff848000 0x0 0x100>;
 		clocks = <&cru PCLK_WDT>;
 		interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH 0>;
-- 
2.11.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 8/8] ARM: dts: rockchip: remove clock-names property from watchdog node in rv1108.dtsi
  2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
                   ` (5 preceding siblings ...)
  2020-12-18 12:05 ` [PATCH 7/8] arm64: dts: rockchip: add new watchdog compatible to rk3399.dtsi Johan Jonker
@ 2020-12-18 12:05 ` Johan Jonker
  2020-12-31 19:16 ` [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps, dw-wdt.yaml Rob Herring
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Johan Jonker @ 2020-12-18 12:05 UTC (permalink / raw)
  To: heiko
  Cc: robh+dt, wim, linux, jamie, linux-watchdog, devicetree,
	linux-kernel, linux-arm-kernel, linux-rockchip

A test with the command below gives this error:

/arch/arm/boot/dts/rv1108-evb.dt.yaml: watchdog@10360000:
clock-names:0: 'tclk' was expected

Comment from the dw_wdt.c file:

Try to request the watchdog dedicated timer clock source. It must
be supplied if asynchronous mode is enabled. Otherwise fallback
to the common timer/bus clocks configuration, in which the very
first found clock supply both timer and APB signals.

Like in the other Rockchip watchdog nodes the property "clock-names"
is not needed, so remove it.

make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm/boot/dts/rv1108.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 8ef8d038e..bec47e0be 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -304,7 +304,6 @@
 		reg = <0x10360000 0x100>;
 		interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&cru PCLK_WDT>;
-		clock-names = "pclk_wdt";
 		status = "disabled";
 	};
 
-- 
2.11.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps, dw-wdt.yaml
  2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
                   ` (6 preceding siblings ...)
  2020-12-18 12:05 ` [PATCH 8/8] ARM: dts: rockchip: remove clock-names property from watchdog node in rv1108.dtsi Johan Jonker
@ 2020-12-31 19:16 ` Rob Herring
  2021-01-09 14:05 ` [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Heiko Stübner
  2021-01-23 17:34 ` Guenter Roeck
  9 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2020-12-31 19:16 UTC (permalink / raw)
  To: Johan Jonker
  Cc: wim, linux-arm-kernel, linux-watchdog, heiko, devicetree,
	linux-rockchip, jamie, linux, linux-kernel, robh+dt

On Fri, 18 Dec 2020 13:05:27 +0100, Johan Jonker wrote:
> The watchdog compatible strings are suppose to be SoC orientated.
> In the more recently added Rockchip SoC dtsi files only
> the fallback string "snps,dw-wdt" is used, so add the following
> compatible strings:
> 
> "rockchip,px30-wdt", "snps,dw-wdt"
> "rockchip,rk3228-wdt", "snps,dw-wdt"
> "rockchip,rk3308-wdt", "snps,dw-wdt"
> "rockchip,rk3328-wdt", "snps,dw-wdt"
> "rockchip,rk3399-wdt", "snps,dw-wdt"
> "rockchip,rv1108-wdt", "snps,dw-wdt"
> 
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml
  2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
                   ` (7 preceding siblings ...)
  2020-12-31 19:16 ` [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps, dw-wdt.yaml Rob Herring
@ 2021-01-09 14:05 ` Heiko Stübner
  2021-01-23 17:34 ` Guenter Roeck
  9 siblings, 0 replies; 15+ messages in thread
From: Heiko Stübner @ 2021-01-09 14:05 UTC (permalink / raw)
  To: Johan Jonker
  Cc: robh+dt, wim, linux, jamie, linux-watchdog, devicetree,
	linux-kernel, linux-arm-kernel, linux-rockchip

Am Freitag, 18. Dezember 2020, 13:05:27 CET schrieb Johan Jonker:
> The watchdog compatible strings are suppose to be SoC orientated.
> In the more recently added Rockchip SoC dtsi files only
> the fallback string "snps,dw-wdt" is used, so add the following
> compatible strings:
> 
> "rockchip,px30-wdt", "snps,dw-wdt"
> "rockchip,rk3228-wdt", "snps,dw-wdt"
> "rockchip,rk3308-wdt", "snps,dw-wdt"
> "rockchip,rk3328-wdt", "snps,dw-wdt"
> "rockchip,rk3399-wdt", "snps,dw-wdt"
> "rockchip,rv1108-wdt", "snps,dw-wdt"
> 
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

I'd like to pick up the devicetree patches (2-8) once this has landed
in the watchdog tree.

Thanks
Heiko



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml
  2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
                   ` (8 preceding siblings ...)
  2021-01-09 14:05 ` [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Heiko Stübner
@ 2021-01-23 17:34 ` Guenter Roeck
  2021-01-25 23:40   ` Heiko Stuebner
  9 siblings, 1 reply; 15+ messages in thread
From: Guenter Roeck @ 2021-01-23 17:34 UTC (permalink / raw)
  To: Johan Jonker
  Cc: heiko, robh+dt, wim, jamie, linux-watchdog, devicetree,
	linux-kernel, linux-arm-kernel, linux-rockchip

On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
> The watchdog compatible strings are suppose to be SoC orientated.
> In the more recently added Rockchip SoC dtsi files only
> the fallback string "snps,dw-wdt" is used, so add the following
> compatible strings:
> 
> "rockchip,px30-wdt", "snps,dw-wdt"
> "rockchip,rk3228-wdt", "snps,dw-wdt"
> "rockchip,rk3308-wdt", "snps,dw-wdt"
> "rockchip,rk3328-wdt", "snps,dw-wdt"
> "rockchip,rk3399-wdt", "snps,dw-wdt"
> "rockchip,rv1108-wdt", "snps,dw-wdt"
> 
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> index f7ee9229c..b58596b18 100644
> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> @@ -18,10 +18,16 @@ properties:
>        - const: snps,dw-wdt
>        - items:
>            - enum:
> +              - rockchip,px30-wdt
>                - rockchip,rk3066-wdt
>                - rockchip,rk3188-wdt
> +              - rockchip,rk3228-wdt
>                - rockchip,rk3288-wdt
> +              - rockchip,rk3308-wdt
> +              - rockchip,rk3328-wdt
>                - rockchip,rk3368-wdt
> +              - rockchip,rk3399-wdt
> +              - rockchip,rv1108-wdt
>            - const: snps,dw-wdt
>  
>    reg:

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml
  2021-01-23 17:34 ` Guenter Roeck
@ 2021-01-25 23:40   ` Heiko Stuebner
  2021-01-26  4:55     ` Guenter Roeck
  0 siblings, 1 reply; 15+ messages in thread
From: Heiko Stuebner @ 2021-01-25 23:40 UTC (permalink / raw)
  To: Johan Jonker, Guenter Roeck
  Cc: robh+dt, wim, jamie, linux-watchdog, devicetree, linux-kernel,
	linux-arm-kernel, linux-rockchip

Hi Guenter,

Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck:
> On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
> > The watchdog compatible strings are suppose to be SoC orientated.
> > In the more recently added Rockchip SoC dtsi files only
> > the fallback string "snps,dw-wdt" is used, so add the following
> > compatible strings:
> > 
> > "rockchip,px30-wdt", "snps,dw-wdt"
> > "rockchip,rk3228-wdt", "snps,dw-wdt"
> > "rockchip,rk3308-wdt", "snps,dw-wdt"
> > "rockchip,rk3328-wdt", "snps,dw-wdt"
> > "rockchip,rk3399-wdt", "snps,dw-wdt"
> > "rockchip,rv1108-wdt", "snps,dw-wdt"
> > 
> > make ARCH=arm dtbs_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > 
> > make ARCH=arm64 dtbs_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > 
> > Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

just to clarify, do you expect me to pick up the dt-binding patch
with the devicetree patches or do you want to take this individual
patch through the watchdog tree instead?


Thanks
Heiko

> > ---
> >  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > index f7ee9229c..b58596b18 100644
> > --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > @@ -18,10 +18,16 @@ properties:
> >        - const: snps,dw-wdt
> >        - items:
> >            - enum:
> > +              - rockchip,px30-wdt
> >                - rockchip,rk3066-wdt
> >                - rockchip,rk3188-wdt
> > +              - rockchip,rk3228-wdt
> >                - rockchip,rk3288-wdt
> > +              - rockchip,rk3308-wdt
> > +              - rockchip,rk3328-wdt
> >                - rockchip,rk3368-wdt
> > +              - rockchip,rk3399-wdt
> > +              - rockchip,rv1108-wdt
> >            - const: snps,dw-wdt
> >  
> >    reg:
> 





^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml
  2021-01-25 23:40   ` Heiko Stuebner
@ 2021-01-26  4:55     ` Guenter Roeck
  2021-01-26  8:37       ` Heiko Stübner
  0 siblings, 1 reply; 15+ messages in thread
From: Guenter Roeck @ 2021-01-26  4:55 UTC (permalink / raw)
  To: Heiko Stuebner, Johan Jonker
  Cc: robh+dt, wim, jamie, linux-watchdog, devicetree, linux-kernel,
	linux-arm-kernel, linux-rockchip

Hi Heiko,

On 1/25/21 3:40 PM, Heiko Stuebner wrote:
> Hi Guenter,
> 
> Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck:
>> On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
>>> The watchdog compatible strings are suppose to be SoC orientated.
>>> In the more recently added Rockchip SoC dtsi files only
>>> the fallback string "snps,dw-wdt" is used, so add the following
>>> compatible strings:
>>>
>>> "rockchip,px30-wdt", "snps,dw-wdt"
>>> "rockchip,rk3228-wdt", "snps,dw-wdt"
>>> "rockchip,rk3308-wdt", "snps,dw-wdt"
>>> "rockchip,rk3328-wdt", "snps,dw-wdt"
>>> "rockchip,rk3399-wdt", "snps,dw-wdt"
>>> "rockchip,rv1108-wdt", "snps,dw-wdt"
>>>
>>> make ARCH=arm dtbs_check
>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>
>>> make ARCH=arm64 dtbs_check
>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>
>>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> just to clarify, do you expect me to pick up the dt-binding patch
> with the devicetree patches or do you want to take this individual
> patch through the watchdog tree instead?
> 

You'd have to ask Wim since he takes care of actually sending pull requests.
But didn't you say earlier that you wanted to apply the rest of the series
after this one is applied through the watchdog tree ?

Thanks,
Guenter

> 
> Thanks
> Heiko
> 
>>> ---
>>>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> index f7ee9229c..b58596b18 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> @@ -18,10 +18,16 @@ properties:
>>>        - const: snps,dw-wdt
>>>        - items:
>>>            - enum:
>>> +              - rockchip,px30-wdt
>>>                - rockchip,rk3066-wdt
>>>                - rockchip,rk3188-wdt
>>> +              - rockchip,rk3228-wdt
>>>                - rockchip,rk3288-wdt
>>> +              - rockchip,rk3308-wdt
>>> +              - rockchip,rk3328-wdt
>>>                - rockchip,rk3368-wdt
>>> +              - rockchip,rk3399-wdt
>>> +              - rockchip,rv1108-wdt
>>>            - const: snps,dw-wdt
>>>  
>>>    reg:
>>
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml
  2021-01-26  4:55     ` Guenter Roeck
@ 2021-01-26  8:37       ` Heiko Stübner
  2021-01-26 14:56         ` Guenter Roeck
  0 siblings, 1 reply; 15+ messages in thread
From: Heiko Stübner @ 2021-01-26  8:37 UTC (permalink / raw)
  To: Johan Jonker, Guenter Roeck
  Cc: robh+dt, wim, jamie, linux-watchdog, devicetree, linux-kernel,
	linux-arm-kernel, linux-rockchip

Hi Guenter,

Am Dienstag, 26. Januar 2021, 05:55:59 CET schrieb Guenter Roeck:
> On 1/25/21 3:40 PM, Heiko Stuebner wrote:
> > Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck:
> >> On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
> >>> The watchdog compatible strings are suppose to be SoC orientated.
> >>> In the more recently added Rockchip SoC dtsi files only
> >>> the fallback string "snps,dw-wdt" is used, so add the following
> >>> compatible strings:
> >>>
> >>> "rockchip,px30-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3228-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3308-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3328-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3399-wdt", "snps,dw-wdt"
> >>> "rockchip,rv1108-wdt", "snps,dw-wdt"
> >>>
> >>> make ARCH=arm dtbs_check
> >>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>>
> >>> make ARCH=arm64 dtbs_check
> >>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>>
> >>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> >>> Acked-by: Rob Herring <robh@kernel.org>
> >>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> >>
> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > 
> > just to clarify, do you expect me to pick up the dt-binding patch
> > with the devicetree patches or do you want to take this individual
> > patch through the watchdog tree instead?
> > 
> 
> You'd have to ask Wim since he takes care of actually sending pull requests.
> But didn't you say earlier that you wanted to apply the rest of the series
> after this one is applied through the watchdog tree ?

Yep that was my intent, though somehow I mistook you as also being
a watchdog maintainer, hence the confusion.

So I'll wait for Wim to apply this patch and then I'll take the rest of
the series.

Thanks
Heiko


> >>> ---
> >>>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
> >>>  1 file changed, 6 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>> index f7ee9229c..b58596b18 100644
> >>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>> @@ -18,10 +18,16 @@ properties:
> >>>        - const: snps,dw-wdt
> >>>        - items:
> >>>            - enum:
> >>> +              - rockchip,px30-wdt
> >>>                - rockchip,rk3066-wdt
> >>>                - rockchip,rk3188-wdt
> >>> +              - rockchip,rk3228-wdt
> >>>                - rockchip,rk3288-wdt
> >>> +              - rockchip,rk3308-wdt
> >>> +              - rockchip,rk3328-wdt
> >>>                - rockchip,rk3368-wdt
> >>> +              - rockchip,rk3399-wdt
> >>> +              - rockchip,rv1108-wdt
> >>>            - const: snps,dw-wdt
> >>>  
> >>>    reg:
> >>
> > 
> > 
> > 
> > 
> 
> 





^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml
  2021-01-26  8:37       ` Heiko Stübner
@ 2021-01-26 14:56         ` Guenter Roeck
  0 siblings, 0 replies; 15+ messages in thread
From: Guenter Roeck @ 2021-01-26 14:56 UTC (permalink / raw)
  To: Heiko Stübner, Johan Jonker
  Cc: robh+dt, wim, jamie, linux-watchdog, devicetree, linux-kernel,
	linux-arm-kernel, linux-rockchip

On 1/26/21 12:37 AM, Heiko Stübner wrote:
> Hi Guenter,
> 
> Am Dienstag, 26. Januar 2021, 05:55:59 CET schrieb Guenter Roeck:
>> On 1/25/21 3:40 PM, Heiko Stuebner wrote:
>>> Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck:
>>>> On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
>>>>> The watchdog compatible strings are suppose to be SoC orientated.
>>>>> In the more recently added Rockchip SoC dtsi files only
>>>>> the fallback string "snps,dw-wdt" is used, so add the following
>>>>> compatible strings:
>>>>>
>>>>> "rockchip,px30-wdt", "snps,dw-wdt"
>>>>> "rockchip,rk3228-wdt", "snps,dw-wdt"
>>>>> "rockchip,rk3308-wdt", "snps,dw-wdt"
>>>>> "rockchip,rk3328-wdt", "snps,dw-wdt"
>>>>> "rockchip,rk3399-wdt", "snps,dw-wdt"
>>>>> "rockchip,rv1108-wdt", "snps,dw-wdt"
>>>>>
>>>>> make ARCH=arm dtbs_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>>>
>>>>> make ARCH=arm64 dtbs_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>>>
>>>>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>>>>> Acked-by: Rob Herring <robh@kernel.org>
>>>>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>>>>
>>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>> just to clarify, do you expect me to pick up the dt-binding patch
>>> with the devicetree patches or do you want to take this individual
>>> patch through the watchdog tree instead?
>>>
>>
>> You'd have to ask Wim since he takes care of actually sending pull requests.
>> But didn't you say earlier that you wanted to apply the rest of the series
>> after this one is applied through the watchdog tree ?
> 
> Yep that was my intent, though somehow I mistook you as also being
> a watchdog maintainer, hence the confusion.
> 

I am, but Wim sends all pull requests.

Guenter

> So I'll wait for Wim to apply this patch and then I'll take the rest of
> the series.
> 
> Thanks
> Heiko
> 
> 
>>>>> ---
>>>>>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
>>>>>  1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>>> index f7ee9229c..b58596b18 100644
>>>>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>>> @@ -18,10 +18,16 @@ properties:
>>>>>        - const: snps,dw-wdt
>>>>>        - items:
>>>>>            - enum:
>>>>> +              - rockchip,px30-wdt
>>>>>                - rockchip,rk3066-wdt
>>>>>                - rockchip,rk3188-wdt
>>>>> +              - rockchip,rk3228-wdt
>>>>>                - rockchip,rk3288-wdt
>>>>> +              - rockchip,rk3308-wdt
>>>>> +              - rockchip,rk3328-wdt
>>>>>                - rockchip,rk3368-wdt
>>>>> +              - rockchip,rk3399-wdt
>>>>> +              - rockchip,rv1108-wdt
>>>>>            - const: snps,dw-wdt
>>>>>  
>>>>>    reg:
>>>>
>>>
>>>
>>>
>>>
>>
>>
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, back to index

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-18 12:05 [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Johan Jonker
2020-12-18 12:05 ` [PATCH 2/8] ARM: dts: rockchip: add new watchdog compatible to rv1108.dtsi Johan Jonker
2020-12-18 12:05 ` [PATCH 3/8] ARM: dts: rockchip: add new watchdog compatible to rk322x.dtsi Johan Jonker
2020-12-18 12:05 ` [PATCH 4/8] arm64: dts: rockchip: add new watchdog compatible to px30.dtsi Johan Jonker
2020-12-18 12:05 ` [PATCH 5/8] arm64: dts: rockchip: add new watchdog compatible to rk3308.dtsi Johan Jonker
2020-12-18 12:05 ` [PATCH 6/8] arm64: dts: rockchip: add new watchdog compatible to rk3328.dtsi Johan Jonker
2020-12-18 12:05 ` [PATCH 7/8] arm64: dts: rockchip: add new watchdog compatible to rk3399.dtsi Johan Jonker
2020-12-18 12:05 ` [PATCH 8/8] ARM: dts: rockchip: remove clock-names property from watchdog node in rv1108.dtsi Johan Jonker
2020-12-31 19:16 ` [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps, dw-wdt.yaml Rob Herring
2021-01-09 14:05 ` [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Heiko Stübner
2021-01-23 17:34 ` Guenter Roeck
2021-01-25 23:40   ` Heiko Stuebner
2021-01-26  4:55     ` Guenter Roeck
2021-01-26  8:37       ` Heiko Stübner
2021-01-26 14:56         ` Guenter Roeck

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git