From: Guenter Roeck <linux@roeck-us.net>
To: Campion Kang <campion.kang@advantech.com.tw>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org,
AceLan Kao <chia-lin.kao@canonical.com>
Subject: Re: [PATCH v5 5/6] hwmon: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller
Date: Thu, 31 Dec 2020 17:28:35 -0800
Message-ID: <20210101012835.GA87441@roeck-us.net> (raw)
In-Reply-To: <20201231123948.10473-5-campion.kang@advantech.com.tw>
On Thu, Dec 31, 2020 at 08:39:47PM +0800, Campion Kang wrote:
> This is one of sub-device driver for Advantech embedded controller
> AHC1EC0. This driver provides sysfs ABI for Advantech related
> applications to monitor the system status.
>
> Signed-off-by: Campion Kang <campion.kang@advantech.com.tw>
> ---
> drivers/hwmon/Kconfig | 10 +
[ ... ]
> + lmsensor_data.hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev,
> + "ahc1ec0-hwmon", adv_ec_data, ahc1ec0_groups);
New drivers must use [devm_]hwmon_device_register_with_info() and will
otherwise not be accepted.
Guenter
next prev parent reply index
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 12:39 [PATCH v5 1/6] MAINTAINERS: Add Advantech AHC1 embedded controller entry Campion Kang
2020-12-31 12:39 ` [PATCH v5 2/6] mfd: ahc1ec0: Add Advantech EC include file used by dt-bindings Campion Kang
2020-12-31 12:39 ` [PATCH v5 3/6] dt-bindings: mfd: ahc1ec0.yaml: Add Advantech embedded controller - AHC1EC0 Campion Kang
2020-12-31 15:34 ` Rob Herring
2020-12-31 12:39 ` [PATCH v5 4/6] mfd: ahc1ec0: Add support for Advantech embedded controller Campion Kang
2020-12-31 12:39 ` [PATCH v5 5/6] hwmon: ahc1ec0-hwmon: Add sub-device hwmon " Campion Kang
2021-01-01 1:28 ` Guenter Roeck [this message]
2020-12-31 12:39 ` [PATCH v5 6/6] watchdog: ahc1ec0-wdt: Add sub-device watchdog " Campion Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210101012835.GA87441@roeck-us.net \
--to=linux@roeck-us.net \
--cc=campion.kang@advantech.com.tw \
--cc=chia-lin.kao@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Watchdog Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
linux-watchdog@vger.kernel.org
public-inbox-index linux-watchdog
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git