From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B79A4C43381 for ; Thu, 4 Mar 2021 00:51:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82A6D64F3A for ; Thu, 4 Mar 2021 00:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241848AbhCDAvl (ORCPT ); Wed, 3 Mar 2021 19:51:41 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:44580 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376979AbhCCTo3 (ORCPT ); Wed, 3 Mar 2021 14:44:29 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id CA9061C0B81; Wed, 3 Mar 2021 20:27:33 +0100 (CET) Date: Wed, 3 Mar 2021 20:27:33 +0100 From: Pavel Machek To: Henning Schild Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-watchdog@vger.kernel.org, Srikanth Krishnakar , Jan Kiszka , Gerd Haeussler , Guenter Roeck , Wim Van Sebroeck , Mark Gross , Hans de Goede Subject: Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs Message-ID: <20210303192733.GA8720@amd> References: <20210302163309.25528-1-henning.schild@siemens.com> <20210302163309.25528-3-henning.schild@siemens.com> <20210302205452.GA32573@duo.ucw.cz> <20210303183714.62c0f06f@md1za8fc.ad001.siemens.net> <20210303174040.GA3305@amd> <20210303194956.5b36a73c@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: <20210303194956.5b36a73c@md1za8fc.ad001.siemens.net> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2021-03-03 19:49:56, Henning Schild wrote: > Am Wed, 3 Mar 2021 18:40:40 +0100 > schrieb Pavel Machek : >=20 > > Hi! > >=20 > > > > > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile > > > > > index 2a698df9da57..c15e1e3c5958 100644 > > > > > --- a/drivers/leds/Makefile > > > > > +++ b/drivers/leds/Makefile > > > > > @@ -93,6 +93,7 @@ obj-$(CONFIG_LEDS_TURRIS_OMNIA) > > > > > +=3D leds-turris-omnia.o > > > > > obj-$(CONFIG_LEDS_WM831X_STATUS) +=3D leds-wm831x-status.o > > > > > obj-$(CONFIG_LEDS_WM8350) +=3D leds-wm8350.o > > > > > obj-$(CONFIG_LEDS_WRAP) +=3D leds-wrap.o > > > > > +obj-$(CONFIG_LEDS_SIEMENS_SIMATIC_IPC) +=3D > > > > > simatic-ipc-leds.o =20 > > > >=20 > > > > Let's put this into drivers/leds/simple. You'll have to create > > > > it. =20 > > >=20 > > > Can you please go into detail why? We plan to add more devices in > > > the future, which might in fact make this a little less simple. But > > > we can discuss that when the time is right and start with simple. =20 > >=20 > > There's already way too many drivers in the directory, and your driver > > is very different from drivers for camera flash (for example). >=20 > Understood, the whole Makefile Kconfig thingy? You'll need Makefile + Kconfig, yes. No need for CONFIG_LEDS_SIMPLE. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmA/4yUACgkQMOfwapXb+vK/tgCgqwLKOLfYmIuhh5QZrkHIfSET FuoAoI5etED7qEWaPIdY61h5hp+n7gXG =i6mJ -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd--