From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CCA3C433E6 for ; Thu, 4 Mar 2021 00:51:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 095BC64FB5 for ; Thu, 4 Mar 2021 00:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241836AbhCDAvk (ORCPT ); Wed, 3 Mar 2021 19:51:40 -0500 Received: from gecko.sbs.de ([194.138.37.40]:36180 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1838579AbhCCTBG (ORCPT ); Wed, 3 Mar 2021 14:01:06 -0500 Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 123IxwIh025455 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 3 Mar 2021 19:59:58 +0100 Received: from md1za8fc.ad001.siemens.net ([139.22.36.86]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 123InvaB000593; Wed, 3 Mar 2021 19:49:57 +0100 Date: Wed, 3 Mar 2021 19:49:56 +0100 From: Henning Schild To: Pavel Machek Cc: , , , , Srikanth Krishnakar , Jan Kiszka , Gerd Haeussler , Guenter Roeck , Wim Van Sebroeck , Mark Gross , Hans de Goede Subject: Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs Message-ID: <20210303194956.5b36a73c@md1za8fc.ad001.siemens.net> In-Reply-To: <20210303174040.GA3305@amd> References: <20210302163309.25528-1-henning.schild@siemens.com> <20210302163309.25528-3-henning.schild@siemens.com> <20210302205452.GA32573@duo.ucw.cz> <20210303183714.62c0f06f@md1za8fc.ad001.siemens.net> <20210303174040.GA3305@amd> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Am Wed, 3 Mar 2021 18:40:40 +0100 schrieb Pavel Machek : > Hi! > > > > > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile > > > > index 2a698df9da57..c15e1e3c5958 100644 > > > > --- a/drivers/leds/Makefile > > > > +++ b/drivers/leds/Makefile > > > > @@ -93,6 +93,7 @@ obj-$(CONFIG_LEDS_TURRIS_OMNIA) > > > > += leds-turris-omnia.o > > > > obj-$(CONFIG_LEDS_WM831X_STATUS) += leds-wm831x-status.o > > > > obj-$(CONFIG_LEDS_WM8350) += leds-wm8350.o > > > > obj-$(CONFIG_LEDS_WRAP) += leds-wrap.o > > > > +obj-$(CONFIG_LEDS_SIEMENS_SIMATIC_IPC) += > > > > simatic-ipc-leds.o > > > > > > Let's put this into drivers/leds/simple. You'll have to create > > > it. > > > > Can you please go into detail why? We plan to add more devices in > > the future, which might in fact make this a little less simple. But > > we can discuss that when the time is right and start with simple. > > There's already way too many drivers in the directory, and your driver > is very different from drivers for camera flash (for example). Understood, the whole Makefile Kconfig thingy? Henning > Best regards, > Pavel