linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH v5 5/7] watchdog: f71808e_wdt: migrate to new kernel watchdog API
Date: Sat, 28 Aug 2021 09:12:48 -0700	[thread overview]
Message-ID: <20210828161248.GA822720@roeck-us.net> (raw)
In-Reply-To: <35d9dbf57b58c5f003cef31dc256ec2fec044524.1628525954.git-series.a.fatoum@pengutronix.de>

On Mon, Aug 09, 2021 at 06:20:35PM +0200, Ahmad Fatoum wrote:
> Migrating the driver lets us drop the watchdog misc device boilerplate
> and reduces size by 285 lines. It also brings us support for new
> functionality like CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED.
> 
> This incurs a slight backwards-compatibility break, because the new
> kernel watchdog API doesn't support unloading modules for drivers
> whose watchdog hardware is reported to be running.
> 
> This means following scenario will be no longer supported:
>  - BIOS has enabled watchdog
>  - Module is loaded and unloaded without opening watchdog
>  - module_exit is expected to succeed and disable watchdog HW
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

  reply	other threads:[~2021-08-28 16:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 16:20 [PATCH v5 0/7] watchdog: f71808e_wdt: migrate to new kernel API Ahmad Fatoum
2021-08-09 16:20 ` [PATCH v5 1/7] watchdog: f71808e_wdt: fix inaccurate report in WDIOC_GETTIMEOUT Ahmad Fatoum
2021-08-09 16:20 ` [PATCH v5 2/7] watchdog: f71808e_wdt: remove superfluous global Ahmad Fatoum
2021-08-28 16:07   ` Guenter Roeck
2021-08-09 16:20 ` [PATCH v5 3/7] watchdog: f71808e_wdt: constify static array Ahmad Fatoum
2021-08-28 16:07   ` Guenter Roeck
2021-08-09 16:20 ` [PATCH v5 4/7] watchdog: f71808e_wdt: rename variant-independent identifiers appropriately Ahmad Fatoum
2021-08-09 16:20 ` [PATCH v5 5/7] watchdog: f71808e_wdt: migrate to new kernel watchdog API Ahmad Fatoum
2021-08-28 16:12   ` Guenter Roeck [this message]
2021-08-09 16:20 ` [PATCH v5 6/7] watchdog: f71808e_wdt: refactor to platform device/driver pair Ahmad Fatoum
2021-08-09 16:20 ` [PATCH v5 7/7] watchdog: f71808e_wdt: dynamically allocate watchdog driver data Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210828161248.GA822720@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=a.fatoum@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@linux-watchdog.org \
    --subject='Re: [PATCH v5 5/7] watchdog: f71808e_wdt: migrate to new kernel watchdog API' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).