linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: ar7_wdt: Make use of the helper function devm_platform_ioremap_resource_byname()
Date: Tue, 7 Sep 2021 05:38:47 -0700	[thread overview]
Message-ID: <20210907123847.GA4989@roeck-us.net> (raw)
In-Reply-To: <20210907074223.2706-1-caihuoqing@baidu.com>

On Tue, Sep 07, 2021 at 03:42:22PM +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/ar7_wdt.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/watchdog/ar7_wdt.c b/drivers/watchdog/ar7_wdt.c
> index ff37dc91057d..743e171d97a3 100644
> --- a/drivers/watchdog/ar7_wdt.c
> +++ b/drivers/watchdog/ar7_wdt.c
> @@ -63,8 +63,6 @@ static DEFINE_SPINLOCK(wdt_lock);
>  /* XXX currently fixed, allows max margin ~68.72 secs */
>  #define prescale_value 0xffff
>  
> -/* Resource of the WDT registers */
> -static struct resource *ar7_regs_wdt;
>  /* Pointer to the remapped WDT IO space */
>  static struct ar7_wdt *ar7_wdt;
>  
> @@ -265,9 +263,7 @@ static int ar7_wdt_probe(struct platform_device *pdev)
>  {
>  	int rc;
>  
> -	ar7_regs_wdt =
> -		platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs");
> -	ar7_wdt = devm_ioremap_resource(&pdev->dev, ar7_regs_wdt);
> +	ar7_wdt = devm_platform_ioremap_resource_byname(pdev, "regs");
>  	if (IS_ERR(ar7_wdt))
>  		return PTR_ERR(ar7_wdt);
>  
> -- 
> 2.25.1
> 

      reply	other threads:[~2021-09-07 12:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07  7:42 Cai Huoqing
2021-09-07 12:38 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907123847.GA4989@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=caihuoqing@baidu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@linux-watchdog.org \
    --subject='Re: [PATCH] watchdog: ar7_wdt: Make use of the helper function devm_platform_ioremap_resource_byname()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).