linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] watchdog: mlx-wdt: Use regmap_write_bits()
@ 2021-09-07  9:27 Philipp Zabel
  2021-09-07 12:40 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Philipp Zabel @ 2021-09-07  9:27 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck; +Cc: linux-watchdog

Use the regmap_write_bits() macro instead of regmap_update_bits_base().
No functional change.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/watchdog/mlx_wdt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/mlx_wdt.c b/drivers/watchdog/mlx_wdt.c
index 54193369e85c..9c5b6616fc87 100644
--- a/drivers/watchdog/mlx_wdt.c
+++ b/drivers/watchdog/mlx_wdt.c
@@ -100,9 +100,8 @@ static int mlxreg_wdt_ping(struct watchdog_device *wdd)
 	struct mlxreg_wdt *wdt = watchdog_get_drvdata(wdd);
 	struct mlxreg_core_data *reg_data = &wdt->pdata->data[wdt->ping_idx];
 
-	return regmap_update_bits_base(wdt->regmap, reg_data->reg,
-				       ~reg_data->mask, BIT(reg_data->bit),
-				       NULL, false, true);
+	return regmap_write_bits(wdt->regmap, reg_data->reg, ~reg_data->mask,
+				 BIT(reg_data->bit));
 }
 
 static int mlxreg_wdt_set_timeout(struct watchdog_device *wdd,
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] watchdog: mlx-wdt: Use regmap_write_bits()
  2021-09-07  9:27 [PATCH] watchdog: mlx-wdt: Use regmap_write_bits() Philipp Zabel
@ 2021-09-07 12:40 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-09-07 12:40 UTC (permalink / raw)
  To: Philipp Zabel; +Cc: Wim Van Sebroeck, linux-watchdog

On Tue, Sep 07, 2021 at 11:27:32AM +0200, Philipp Zabel wrote:
> Use the regmap_write_bits() macro instead of regmap_update_bits_base().
> No functional change.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/mlx_wdt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/mlx_wdt.c b/drivers/watchdog/mlx_wdt.c
> index 54193369e85c..9c5b6616fc87 100644
> --- a/drivers/watchdog/mlx_wdt.c
> +++ b/drivers/watchdog/mlx_wdt.c
> @@ -100,9 +100,8 @@ static int mlxreg_wdt_ping(struct watchdog_device *wdd)
>  	struct mlxreg_wdt *wdt = watchdog_get_drvdata(wdd);
>  	struct mlxreg_core_data *reg_data = &wdt->pdata->data[wdt->ping_idx];
>  
> -	return regmap_update_bits_base(wdt->regmap, reg_data->reg,
> -				       ~reg_data->mask, BIT(reg_data->bit),
> -				       NULL, false, true);
> +	return regmap_write_bits(wdt->regmap, reg_data->reg, ~reg_data->mask,
> +				 BIT(reg_data->bit));
>  }
>  
>  static int mlxreg_wdt_set_timeout(struct watchdog_device *wdd,
> -- 
> 2.30.2
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-07 12:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07  9:27 [PATCH] watchdog: mlx-wdt: Use regmap_write_bits() Philipp Zabel
2021-09-07 12:40 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).