linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [v3,0/2] update mediatek wdt driver and dt-binding
@ 2021-09-14 12:34 Fengquan Chen
  2021-09-14 12:34 ` [v3,1/2] dt-bindings: watchdog: mtk-wdt: add disable_wdt_extrst support Fengquan Chen
  2021-09-14 12:34 ` [v3,2/2] watchdog: mtk: " Fengquan Chen
  0 siblings, 2 replies; 4+ messages in thread
From: Fengquan Chen @ 2021-09-14 12:34 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Matthias Brugger,
	linux-watchdog, devicetree, linux-arm-kernel, linux-mediatek,
	linux-kernel
  Cc: fengquan.chen, tinghan.shen, randy.wu, rex-bc.chen,
	christine.zhu, joe.yang, zhishuang.zhang

1. update watchdog dt-binding
2. add disable_wdt_extrst to support disable reset signal output

fengquan.chen (2):
  dt-bindings: watchdog: mtk-wdt: add disable_wdt_extrst support
  watchdog: mtk: add disable_wdt_extrst support

 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 2 ++
 drivers/watchdog/mtk_wdt.c                             | 7 +++++++
 2 files changed, 9 insertions(+)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [v3,1/2] dt-bindings: watchdog: mtk-wdt: add disable_wdt_extrst support
  2021-09-14 12:34 [v3,0/2] update mediatek wdt driver and dt-binding Fengquan Chen
@ 2021-09-14 12:34 ` Fengquan Chen
  2021-09-17 14:57   ` Guenter Roeck
  2021-09-14 12:34 ` [v3,2/2] watchdog: mtk: " Fengquan Chen
  1 sibling, 1 reply; 4+ messages in thread
From: Fengquan Chen @ 2021-09-14 12:34 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Matthias Brugger,
	linux-watchdog, devicetree, linux-arm-kernel, linux-mediatek,
	linux-kernel
  Cc: fengquan.chen, tinghan.shen, randy.wu, rex-bc.chen,
	christine.zhu, joe.yang, zhishuang.zhang, Rob Herring

This patch add a description and example of disable_wdt_extrst
element for watchdog on MTK Socs

Signed-off-by: Fengquan Chen <fengquan.chen@mediatek.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
index a4e31ce96e0e..0114871f887a 100644
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
@@ -22,6 +22,7 @@ Required properties:
 - reg : Specifies base physical address and size of the registers.
 
 Optional properties:
+- mediatek,disable-extrst: disable send output reset signal
 - interrupts: Watchdog pre-timeout (bark) interrupt.
 - timeout-sec: contains the watchdog timeout in seconds.
 - #reset-cells: Should be 1.
@@ -31,6 +32,7 @@ Example:
 watchdog: watchdog@10007000 {
 	compatible = "mediatek,mt8183-wdt",
 		     "mediatek,mt6589-wdt";
+	mediatek,disable-extrst;
 	reg = <0 0x10007000 0 0x100>;
 	interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
 	timeout-sec = <10>;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [v3,2/2] watchdog: mtk: add disable_wdt_extrst support
  2021-09-14 12:34 [v3,0/2] update mediatek wdt driver and dt-binding Fengquan Chen
  2021-09-14 12:34 ` [v3,1/2] dt-bindings: watchdog: mtk-wdt: add disable_wdt_extrst support Fengquan Chen
@ 2021-09-14 12:34 ` Fengquan Chen
  1 sibling, 0 replies; 4+ messages in thread
From: Fengquan Chen @ 2021-09-14 12:34 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Matthias Brugger,
	linux-watchdog, devicetree, linux-arm-kernel, linux-mediatek,
	linux-kernel
  Cc: fengquan.chen, tinghan.shen, randy.wu, rex-bc.chen,
	christine.zhu, joe.yang, zhishuang.zhang

In some cases, we may need watchdog just to trigger an
internal soc reset without sending any output signal.

Provide a disable_wdt_extrst parameter for configuration.
We can disable or enable it just by configuring dts.

Signed-off-by: Fengquan Chen <fengquan.chen@mediatek.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/watchdog/mtk_wdt.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index 796fbb048cbe..ceb57ea627cd 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c
@@ -65,6 +65,7 @@ struct mtk_wdt_dev {
 	void __iomem *wdt_base;
 	spinlock_t lock; /* protects WDT_SWSYSRST reg */
 	struct reset_controller_dev rcdev;
+	bool disable_wdt_extrst;
 };
 
 struct mtk_wdt_data {
@@ -256,6 +257,8 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
 		reg |= (WDT_MODE_IRQ_EN | WDT_MODE_DUAL_EN);
 	else
 		reg &= ~(WDT_MODE_IRQ_EN | WDT_MODE_DUAL_EN);
+	if (mtk_wdt->disable_wdt_extrst)
+		reg &= ~WDT_MODE_EXRST_EN;
 	reg |= (WDT_MODE_EN | WDT_MODE_KEY);
 	iowrite32(reg, wdt_base + WDT_MODE);
 
@@ -381,6 +384,10 @@ static int mtk_wdt_probe(struct platform_device *pdev)
 		if (err)
 			return err;
 	}
+
+	mtk_wdt->disable_wdt_extrst =
+		of_property_read_bool(dev->of_node, "mediatek,disable-extrst");
+
 	return 0;
 }
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [v3,1/2] dt-bindings: watchdog: mtk-wdt: add disable_wdt_extrst support
  2021-09-14 12:34 ` [v3,1/2] dt-bindings: watchdog: mtk-wdt: add disable_wdt_extrst support Fengquan Chen
@ 2021-09-17 14:57   ` Guenter Roeck
  0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-09-17 14:57 UTC (permalink / raw)
  To: Fengquan Chen
  Cc: Wim Van Sebroeck, Rob Herring, Matthias Brugger, linux-watchdog,
	devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
	tinghan.shen, randy.wu, rex-bc.chen, christine.zhu, joe.yang,
	zhishuang.zhang, Rob Herring

On Tue, Sep 14, 2021 at 08:34:53PM +0800, Fengquan Chen wrote:
> This patch add a description and example of disable_wdt_extrst
> element for watchdog on MTK Socs
> 
> Signed-off-by: Fengquan Chen <fengquan.chen@mediatek.com>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> index a4e31ce96e0e..0114871f887a 100644
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> @@ -22,6 +22,7 @@ Required properties:
>  - reg : Specifies base physical address and size of the registers.
>  
>  Optional properties:
> +- mediatek,disable-extrst: disable send output reset signal
>  - interrupts: Watchdog pre-timeout (bark) interrupt.
>  - timeout-sec: contains the watchdog timeout in seconds.
>  - #reset-cells: Should be 1.
> @@ -31,6 +32,7 @@ Example:
>  watchdog: watchdog@10007000 {
>  	compatible = "mediatek,mt8183-wdt",
>  		     "mediatek,mt6589-wdt";
> +	mediatek,disable-extrst;
>  	reg = <0 0x10007000 0 0x100>;
>  	interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
>  	timeout-sec = <10>;

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-17 14:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14 12:34 [v3,0/2] update mediatek wdt driver and dt-binding Fengquan Chen
2021-09-14 12:34 ` [v3,1/2] dt-bindings: watchdog: mtk-wdt: add disable_wdt_extrst support Fengquan Chen
2021-09-17 14:57   ` Guenter Roeck
2021-09-14 12:34 ` [v3,2/2] watchdog: mtk: " Fengquan Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).