linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/watchdog: fix repeated words in comments
@ 2022-08-16 12:42 Jilin Yuan
  0 siblings, 0 replies; 6+ messages in thread
From: Jilin Yuan @ 2022-08-16 12:42 UTC (permalink / raw)
  To: wim, linux; +Cc: linux-watchdog, linux-kernel, Jilin Yuan

 Delete the redundant word 'we'.
 Delete the redundant word 'set'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/watchdog/wdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/wdt.c b/drivers/watchdog/wdt.c
index 183876156243..c358bebc42c2 100644
--- a/drivers/watchdog/wdt.c
+++ b/drivers/watchdog/wdt.c
@@ -311,7 +311,7 @@ static irqreturn_t wdt_interrupt(int irq, void *dev_id)
  *	@ppos: pointer to the position to write. No seeks allowed
  *
  *	A write to a watchdog device is defined as a keepalive signal. Any
- *	write of data will do, as we we don't define content meaning.
+ *	write of data will do, as we don't define content meaning.
  */
 
 static ssize_t wdt_write(struct file *file, const char __user *buf,
@@ -406,7 +406,7 @@ static long wdt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
  *	open and on opening we load the counters. Counter zero is a 100Hz
  *	cascade, into counter 1 which downcounts to reboot. When the counter
  *	triggers counter 2 downcounts the length of the reset pulse which
- *	set set to be as long as possible.
+ *	set to be as long as possible.
  */
 
 static int wdt_open(struct inode *inode, struct file *file)
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers/watchdog: fix repeated words in comments
  2022-08-16 12:41 Jilin Yuan
@ 2022-08-16 15:50 ` Guenter Roeck
  0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2022-08-16 15:50 UTC (permalink / raw)
  To: Jilin Yuan; +Cc: wim, linux-watchdog, linux-kernel

On Tue, Aug 16, 2022 at 08:41:26PM +0800, Jilin Yuan wrote:
>  Delete the redundant word 'we'.
>  Delete the redundant word 'set'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>

I am going to ignore all those patches simply because the subject does
not mention the affected driver (but does mention the unnecessary
"drivers"). Really, and I have said that before, if you really have
to submit those cosmetic patches, at least do it right.

Guenter

> ---
>  drivers/watchdog/wdt_pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/wdt_pci.c b/drivers/watchdog/wdt_pci.c
> index d5e56b601351..a5fed7ea0243 100644
> --- a/drivers/watchdog/wdt_pci.c
> +++ b/drivers/watchdog/wdt_pci.c
> @@ -347,7 +347,7 @@ static irqreturn_t wdtpci_interrupt(int irq, void *dev_id)
>   *	@ppos: pointer to the position to write. No seeks allowed
>   *
>   *	A write to a watchdog device is defined as a keepalive signal. Any
> - *	write of data will do, as we we don't define content meaning.
> + *	write of data will do, as we don't define content meaning.
>   */
>  
>  static ssize_t wdtpci_write(struct file *file, const char __user *buf,
> @@ -443,7 +443,7 @@ static long wdtpci_ioctl(struct file *file, unsigned int cmd,
>   *	open and on opening we load the counters. Counter zero is a 100Hz
>   *	cascade, into counter 1 which downcounts to reboot. When the counter
>   *	triggers counter 2 downcounts the length of the reset pulse which
> - *	set set to be as long as possible.
> + *	set to be as long as possible.
>   */
>  
>  static int wdtpci_open(struct inode *inode, struct file *file)
> -- 
> 2.36.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] drivers/watchdog: fix repeated words in comments
@ 2022-08-16 12:45 Jilin Yuan
  0 siblings, 0 replies; 6+ messages in thread
From: Jilin Yuan @ 2022-08-16 12:45 UTC (permalink / raw)
  To: wim, linux; +Cc: linux-watchdog, linux-kernel, Jilin Yuan

 Delete the redundant word 'and'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/watchdog/booke_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
index 5e4dc1a0f2c6..75da5cd02615 100644
--- a/drivers/watchdog/booke_wdt.c
+++ b/drivers/watchdog/booke_wdt.c
@@ -74,7 +74,7 @@ static unsigned long long period_to_sec(unsigned int period)
 /*
  * This procedure will find the highest period which will give a timeout
  * greater than the one required. e.g. for a bus speed of 66666666 and
- * and a parameter of 2 secs, then this procedure will return a value of 38.
+ * a parameter of 2 secs, then this procedure will return a value of 38.
  */
 static unsigned int sec_to_period(unsigned int secs)
 {
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] drivers/watchdog: fix repeated words in comments
@ 2022-08-16 12:44 Jilin Yuan
  0 siblings, 0 replies; 6+ messages in thread
From: Jilin Yuan @ 2022-08-16 12:44 UTC (permalink / raw)
  To: wim, linux; +Cc: linux-watchdog, linux-kernel, Jilin Yuan

 Delete the redundant word 'we'.
 Delete the redundant word 'have'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/watchdog/dw_wdt.c      | 2 +-
 drivers/watchdog/eurotechwdt.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
index cd578843277e..3208ce305335 100644
--- a/drivers/watchdog/dw_wdt.c
+++ b/drivers/watchdog/dw_wdt.c
@@ -218,7 +218,7 @@ static int dw_wdt_set_timeout(struct watchdog_device *wdd, unsigned int top_s)
 
 	/*
 	 * Set the new value in the watchdog.  Some versions of dw_wdt
-	 * have have TOPINIT in the TIMEOUT_RANGE register (as per
+	 * have TOPINIT in the TIMEOUT_RANGE register (as per
 	 * CP_WDT_DUAL_TOP in WDT_COMP_PARAMS_1).  On those we
 	 * effectively get a pat of the watchdog right here.
 	 */
diff --git a/drivers/watchdog/eurotechwdt.c b/drivers/watchdog/eurotechwdt.c
index ce682942662c..e26609ad4c17 100644
--- a/drivers/watchdog/eurotechwdt.c
+++ b/drivers/watchdog/eurotechwdt.c
@@ -192,7 +192,7 @@ static void eurwdt_ping(void)
  * @ppos: pointer to the position to write. No seeks allowed
  *
  * A write to a watchdog device is defined as a keepalive signal. Any
- * write of data will do, as we we don't define content meaning.
+ * write of data will do, as we don't define content meaning.
  */
 
 static ssize_t eurwdt_write(struct file *file, const char __user *buf,
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] drivers/watchdog: fix repeated words in comments
@ 2022-08-16 12:43 Jilin Yuan
  0 siblings, 0 replies; 6+ messages in thread
From: Jilin Yuan @ 2022-08-16 12:43 UTC (permalink / raw)
  To: wim, linux; +Cc: linux-watchdog, linux-kernel, Jilin Yuan

 Delete the redundant word 'we'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/watchdog/pc87413_wdt.c | 2 +-
 drivers/watchdog/w83977f_wdt.c | 2 +-
 drivers/watchdog/wdt977.c      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c
index 9f9a340427fc..14f37b3b903f 100644
--- a/drivers/watchdog/pc87413_wdt.c
+++ b/drivers/watchdog/pc87413_wdt.c
@@ -333,7 +333,7 @@ static int pc87413_status(void)
  *	@ppos: pointer to the position to write. No seeks allowed
  *
  *	A write to a watchdog device is defined as a keepalive signal. Any
- *	write of data will do, as we we don't define content meaning.
+ *	write of data will do, as we don't define content meaning.
  */
 
 static ssize_t pc87413_write(struct file *file, const char __user *data,
diff --git a/drivers/watchdog/w83977f_wdt.c b/drivers/watchdog/w83977f_wdt.c
index fd64ae77780a..31bf21ceaf48 100644
--- a/drivers/watchdog/w83977f_wdt.c
+++ b/drivers/watchdog/w83977f_wdt.c
@@ -321,7 +321,7 @@ static int wdt_release(struct inode *inode, struct file *file)
  *      @ppos: pointer to the position to write. No seeks allowed
  *
  *      A write to a watchdog device is defined as a keepalive signal. Any
- *      write of data will do, as we we don't define content meaning.
+ *      write of data will do, as we don't define content meaning.
  */
 
 static ssize_t wdt_write(struct file *file, const char __user *buf,
diff --git a/drivers/watchdog/wdt977.c b/drivers/watchdog/wdt977.c
index c9b8e863f70f..cd623c6da1fa 100644
--- a/drivers/watchdog/wdt977.c
+++ b/drivers/watchdog/wdt977.c
@@ -298,7 +298,7 @@ static int wdt977_release(struct inode *inode, struct file *file)
  *      @ppos: pointer to the position to write. No seeks allowed
  *
  *      A write to a watchdog device is defined as a keepalive signal. Any
- *      write of data will do, as we we don't define content meaning.
+ *      write of data will do, as we don't define content meaning.
  */
 
 static ssize_t wdt977_write(struct file *file, const char __user *buf,
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] drivers/watchdog: fix repeated words in comments
@ 2022-08-16 12:41 Jilin Yuan
  2022-08-16 15:50 ` Guenter Roeck
  0 siblings, 1 reply; 6+ messages in thread
From: Jilin Yuan @ 2022-08-16 12:41 UTC (permalink / raw)
  To: wim, linux; +Cc: linux-watchdog, linux-kernel, Jilin Yuan

 Delete the redundant word 'we'.
 Delete the redundant word 'set'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/watchdog/wdt_pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/wdt_pci.c b/drivers/watchdog/wdt_pci.c
index d5e56b601351..a5fed7ea0243 100644
--- a/drivers/watchdog/wdt_pci.c
+++ b/drivers/watchdog/wdt_pci.c
@@ -347,7 +347,7 @@ static irqreturn_t wdtpci_interrupt(int irq, void *dev_id)
  *	@ppos: pointer to the position to write. No seeks allowed
  *
  *	A write to a watchdog device is defined as a keepalive signal. Any
- *	write of data will do, as we we don't define content meaning.
+ *	write of data will do, as we don't define content meaning.
  */
 
 static ssize_t wdtpci_write(struct file *file, const char __user *buf,
@@ -443,7 +443,7 @@ static long wdtpci_ioctl(struct file *file, unsigned int cmd,
  *	open and on opening we load the counters. Counter zero is a 100Hz
  *	cascade, into counter 1 which downcounts to reboot. When the counter
  *	triggers counter 2 downcounts the length of the reset pulse which
- *	set set to be as long as possible.
+ *	set to be as long as possible.
  */
 
 static int wdtpci_open(struct inode *inode, struct file *file)
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-08-16 15:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-16 12:42 [PATCH] drivers/watchdog: fix repeated words in comments Jilin Yuan
  -- strict thread matches above, loose matches on Subject: below --
2022-08-16 12:45 Jilin Yuan
2022-08-16 12:44 Jilin Yuan
2022-08-16 12:43 Jilin Yuan
2022-08-16 12:41 Jilin Yuan
2022-08-16 15:50 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).