* [PATCH linux-next] watchdog: rti-wdt:using the pm_runtime_resume_and_get to simplify the code
@ 2022-08-02 7:46 cgel.zte
2022-09-25 17:17 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-08-02 7:46 UTC (permalink / raw)
To: linux-kernel; +Cc: linux, linux-watchdog, ye xingchen, Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync
and pm_runtime_put_noidle.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/watchdog/rti_wdt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
index 053ef3bde12d..6e9253761fc1 100644
--- a/drivers/watchdog/rti_wdt.c
+++ b/drivers/watchdog/rti_wdt.c
@@ -225,9 +225,8 @@ static int rti_wdt_probe(struct platform_device *pdev)
wdt->freq = wdt->freq * 9 / 10;
pm_runtime_enable(dev);
- ret = pm_runtime_get_sync(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0) {
- pm_runtime_put_noidle(dev);
pm_runtime_disable(&pdev->dev);
return dev_err_probe(dev, ret, "runtime pm failed\n");
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] watchdog: rti-wdt:using the pm_runtime_resume_and_get to simplify the code
2022-08-02 7:46 [PATCH linux-next] watchdog: rti-wdt:using the pm_runtime_resume_and_get to simplify the code cgel.zte
@ 2022-09-25 17:17 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2022-09-25 17:17 UTC (permalink / raw)
To: cgel.zte; +Cc: linux-kernel, linux-watchdog, ye xingchen, Zeal Robot
On Tue, Aug 02, 2022 at 07:46:43AM +0000, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync
> and pm_runtime_put_noidle.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/rti_wdt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
> index 053ef3bde12d..6e9253761fc1 100644
> --- a/drivers/watchdog/rti_wdt.c
> +++ b/drivers/watchdog/rti_wdt.c
> @@ -225,9 +225,8 @@ static int rti_wdt_probe(struct platform_device *pdev)
> wdt->freq = wdt->freq * 9 / 10;
>
> pm_runtime_enable(dev);
> - ret = pm_runtime_get_sync(dev);
> + ret = pm_runtime_resume_and_get(dev);
> if (ret < 0) {
> - pm_runtime_put_noidle(dev);
> pm_runtime_disable(&pdev->dev);
> return dev_err_probe(dev, ret, "runtime pm failed\n");
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-25 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02 7:46 [PATCH linux-next] watchdog: rti-wdt:using the pm_runtime_resume_and_get to simplify the code cgel.zte
2022-09-25 17:17 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).