From: Matthias Brugger <matthias.bgg@gmail.com>
To: Crystal Guo <crystal.guo@mediatek.com>,
linux@roeck-us.net, robh+dt@kernel.org
Cc: srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
seiya.wang@mediatek.com
Subject: Re: [v3,1/5] dt-binding: mediatek: watchdog: fix the description of compatible
Date: Thu, 30 Jul 2020 13:11:34 +0200 [thread overview]
Message-ID: <2fca091d-4889-2564-0fe0-927093929f10@gmail.com> (raw)
In-Reply-To: <1596104510-11113-2-git-send-email-crystal.guo@mediatek.com>
On 30/07/2020 12:21, Crystal Guo wrote:
> Besides watchdog, mt2712 and nt8183 also provide sub-system software
> reset features. But mt6589 not support this feature
>
> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
My proposal for the commit message:
"The watchdog driver for MT2712 and MT8183 relies on DT data, so the fallback
compatible MT6589 won't work."
With that or anything like that:
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> index 4dd36bd..45eedc2 100644
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> @@ -4,13 +4,13 @@ Required properties:
>
> - compatible should contain:
> "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> - "mediatek,mt2712-wdt", "mediatek,mt6589-wdt": for MT2712
> + "mediatek,mt2712-wdt": for MT2712
> "mediatek,mt6589-wdt": for MT6589
> "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> - "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
> + "mediatek,mt8183-wdt": for MT8183
> "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
>
> - reg : Specifies base physical address and size of the registers.
>
next prev parent reply other threads:[~2020-07-30 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:21 add watchdog support for mt8192 Crystal Guo
2020-07-30 10:21 ` [v3,1/5] dt-binding: mediatek: watchdog: fix the description of compatible Crystal Guo
2020-07-30 11:11 ` Matthias Brugger [this message]
2020-07-30 10:21 ` [v3,2/5] arm64: dts: mt8183: update watchdog device node Crystal Guo
2020-07-30 11:11 ` Matthias Brugger
2020-07-30 10:21 ` [v3,3/5] dt-binding: mediatek: mt8192: update mtk-wdt document Crystal Guo
2020-07-30 10:21 ` [v3,4/5] dt-binding: mt8192: add toprgu reset-controller head file Crystal Guo
2020-07-30 10:21 ` [v3,5/5] watchdog: mt8192: add wdt support Crystal Guo
2020-07-30 16:06 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fca091d-4889-2564-0fe0-927093929f10@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=crystal.guo@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).