From: Guenter Roeck <linux@roeck-us.net>
To: Suniel Mahesh <sunil.m@techveda.org>,
kgene@kernel.org, krzk@kernel.org, wim@linux-watchdog.org,
heiko@sntech.de
Cc: linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: Samsung based S3C2440A chipset - watchdog timer issue
Date: Thu, 19 Sep 2019 06:21:03 -0700 [thread overview]
Message-ID: <331a804f-bee2-c273-9a26-b40627d68880@roeck-us.net> (raw)
In-Reply-To: <652bf0b2-3681-47f2-3b50-40edff52a7b5@techveda.org>
On 9/19/19 12:40 AM, Suniel Mahesh wrote:
> Hi,
>
> I am working on one of the Samsung based S3C2440A chipset based target .
>
> I have couple of questions and I request someone to shed some light on these: (Thank you)
>
> The watchdog driver in linux, looks like, it just configured WDT but didn't start it (code snippet included below).
>
> May i know the reasson why WDT is not started ? Is it because u-boot already started WDT, implies it is not required to do the
> same once we jump into linux ? or is there any specific reason ?
>
The driver does not detect if the watchdog is not running when probed.
What u-boot does is irrelevant. To start the watchdog at boot, you would
have to provide the tmr_atboot=1 module parameter. Otherwise, it is explicitly
disabled, as shown in the code, and opening the watchdog device would start
the watchdog.
Having said that, the code is less than perfect. Initializing the timeout
in the probe function should be handled differently, and the kernel should
be informed that/if the watchdog is started at boot. It should also be
possible to detect if the watchdog is running instead of relying on tmr_atboot,
and inform the kernel accordingly. But those are not bugs, just possible
improvements.
Guenter
> drivers/watchdog/s3c2410_wdt.c (line 53 and lines 616 - 625)
>
> #define S3C2410_WATCHDOG_ATBOOT (0)
> ....
> static int tmr_atboot = S3C2410_WATCHDOG_ATBOOT;
> ...
> ...
> if (tmr_atboot && started == 0) {
> dev_info(dev, "starting watchdog timer\n");
> s3c2410wdt_start(&wdt->wdt_device);
> } else if (!tmr_atboot) {
> /* if we're not enabling the watchdog, then ensure it is
> * disabled if it has been left running from the bootloader
> * or other source */
>
> s3c2410wdt_stop(&wdt->wdt_device);
> }
> ...
> ...
>
> Tried to start WDT in linux by assigning value 1 to S3C2410_WATCHDOG_ATBOOT. The target resets.
>
> please comment.
>
> Thanks--
> Suniel Mahesh
>
prev parent reply other threads:[~2019-09-19 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 7:40 Samsung based S3C2440A chipset - watchdog timer issue Suniel Mahesh
2019-09-19 8:38 ` Krzysztof Kozlowski
2019-09-19 13:26 ` Guenter Roeck
2019-09-19 13:21 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=331a804f-bee2-c273-9a26-b40627d68880@roeck-us.net \
--to=linux@roeck-us.net \
--cc=heiko@sntech.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=sunil.m@techveda.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).