From: "Heiko Stübner" <heiko@sntech.de>
To: cl <cl@rock-chips.com>, "jay.xu@rock-chips.com" <jay.xu@rock-chips.com>
Cc: robh+dt <robh+dt@kernel.org>, jagan <jagan@amarulasolutions.com>,
wens <wens@csie.org>, uwe <uwe@kleine-koenig.org>,
mail <mail@david-bauer.net>, "Johan Jonker" <jbx6244@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
jensenhuang <jensenhuang@friendlyarm.com>,
michael <michael@amarulasolutions.com>, cnsztl <cnsztl@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
"ulf. hansson" <ulf.hansson@linaro.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
gregkh <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
"林涛(底层平台)" <shawn.lin@rock-chips.com>,
吴达超 <david.wu@rock-chips.com>,
zhangqing <zhangqing@rock-chips.com>,
"Tao Huang" <huangtao@rock-chips.com>, cl <cl@rock-chips.com>,
wim <wim@linux-watchdog.org>, linux <linux@roeck-us.net>,
jamie <jamie@jamieiles.com>,
linux-watchdog <linux-watchdog@vger.kernel.org>,
maz <maz@kernel.org>
Subject: Re: [RESEND PATCH v4 06/10] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank
Date: Fri, 18 Jun 2021 09:01:59 +0200 [thread overview]
Message-ID: <3493815.vrqWZg68TM@diego> (raw)
In-Reply-To: <2021061814414460293612@rock-chips.com>
Hi Jay,
Am Freitag, 18. Juni 2021, 08:41:45 CEST schrieb jay.xu@rock-chips.com:
> Hi Heiko
>
> --------------
> jay.xu@rock-chips.com
> >Hi,
> >
> >Am Donnerstag, 13. Mai 2021, 08:46:06 CEST schrieb cl@rock-chips.com:
> >> From: Liang Chen <cl@rock-chips.com>
> >>
> >> The clock property need 2 items on some rockchip chips.
> >>
> >> Signed-off-by: Liang Chen <cl@rock-chips.com>
> >
> >this patch should definitly move over to Jianquns gpio driver series,
> >as it introduces the usage of these new clocks.
> >
> >Also while the single-clock variant definitly doesn't need it,
> >I think we may want clock-names "apb_pclk", "debounce-ref" for the
> >2-clock variants?
> >
> Okay, I think it's very good idea,
> but is it possible to post the reg-name patch after these dts serial and gpio serial patches ?
You're already creating a new binding when changing the max-items.
So when we change that again later, in theory you'd need to support both
cases (with and without clock-names)
So I'd really prefer to get the binding right the first time and
identifying multiple clocks by clock-names instead of an implicit ordering
is way better in the long run as well.
Heiko
>
> >
> >Heiko
> >
> >> ---
> >> Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> >> index d993e00..0d62c28 100644
> >> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> >> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> >> @@ -22,7 +22,10 @@ properties:
> >> maxItems: 1
> >>
> >> clocks:
> >> - maxItems: 1
> >> + minItems: 1
> >> + items:
> >> + - description: APB interface clock source
> >> + - description: GPIO debounce reference clock source
> >>
> >> gpio-controller: true
> >>
> >>
> >
> >
> >
> >
> >
> >
> >
>
prev parent reply other threads:[~2021-06-18 7:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 8:11 [PATCH v4 00/10] arm64: dts: rockchip: add basic dtsi/dts files for RK3568 SoC cl
2021-04-29 8:11 ` [PATCH v4 01/10] dt-bindings: i2c: i2c-rk3x: add description for rk3568 cl
2021-04-30 21:10 ` Rob Herring
2021-05-25 19:08 ` Wolfram Sang
2021-04-29 8:11 ` [PATCH v4 02/10] dt-bindings: serial: snps-dw-apb-uart: " cl
2021-04-30 21:11 ` Rob Herring
2021-04-29 8:11 ` [PATCH v4 03/10] dt-bindings: mmc: rockchip-dw-mshc: " cl
2021-04-30 21:13 ` Rob Herring
2021-05-11 10:56 ` Ulf Hansson
2021-04-29 8:11 ` [PATCH v4 04/10] dt-bindings: watchdog: dw-wdt: " cl
2021-04-30 21:14 ` Rob Herring
2021-05-19 12:57 ` Guenter Roeck
2021-04-29 8:12 ` [PATCH v4 05/10] dt-bindings: pwm: rockchip: " cl
2021-04-30 21:14 ` Rob Herring
2021-04-29 8:13 ` [PATCH v4 06/10] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank cl
2021-04-30 21:15 ` Rob Herring
2021-04-29 8:13 ` [PATCH v4 07/10] dt-bindings: soc: rockchip: Convert grf.txt to YAML cl
2021-04-29 15:25 ` Rob Herring
2021-04-29 21:24 ` Rob Herring
2021-04-30 0:47 ` [PATCH v4 07/10] dt-bindings: soc: rockchip: Convert grf.txt to YAML【请注意,邮件由robherring2@gmail.com代发】 陈亮
2021-04-30 20:29 ` [PATCH v4 07/10] dt-bindings: soc: rockchip: Convert grf.txt to YAML Johan Jonker
2021-04-29 8:13 ` [PATCH v4 08/10] arm64: dts: rockchip: add generic pinconfig settings used by most Rockchip socs cl
2021-04-29 8:13 ` [PATCH v4 09/10] arm64: dts: rockchip: add core dtsi for RK3568 SoC cl
2021-04-29 8:13 ` [PATCH v4 10/10] arm64: dts: rockchip: add basic dts for RK3568 EVB cl
2021-04-30 21:40 ` Rob Herring
2021-04-30 0:57 ` [RESEND PATCH v4 07/10] dt-bindings: soc: rockchip: Convert grf.txt to YAML cl
2021-04-30 10:58 ` Johan Jonker
2021-05-13 3:33 ` [RESEND PATCH v4 06/10] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank cl
2021-05-13 6:46 ` cl
2021-05-14 10:06 ` Heiko Stuebner
[not found] ` <2021061814414460293612@rock-chips.com>
2021-06-18 7:01 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3493815.vrqWZg68TM@diego \
--to=heiko@sntech.de \
--cc=cl@rock-chips.com \
--cc=cnsztl@gmail.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=huangtao@rock-chips.com \
--cc=jagan@amarulasolutions.com \
--cc=jamie@jamieiles.com \
--cc=jay.xu@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=jensenhuang@friendlyarm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mail@david-bauer.net \
--cc=maz@kernel.org \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=uwe@kleine-koenig.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).