* [PATCH] [v3] drivers: watchdog: Remove duplicate include of kernel.h
@ 2021-03-25 11:29 Wan Jiabing
2021-03-25 14:36 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-03-25 11:29 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, linux-watchdog, linux-kernel
Cc: kael_w, Wan Jiabing
linux/kernel.h has been included. Remove the duplicate.
Reorder include files to be in alphabetic order.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
Changelog:
v3:
- Reorder include files to be in alphabetic order.
v2:
- Remove the duplicate which won't make worse.
---
drivers/watchdog/dw_wdt.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
index 32d0e1781e63..cd578843277e 100644
--- a/drivers/watchdog/dw_wdt.c
+++ b/drivers/watchdog/dw_wdt.c
@@ -13,22 +13,21 @@
*/
#include <linux/bitops.h>
-#include <linux/limits.h>
-#include <linux/kernel.h>
#include <linux/clk.h>
+#include <linux/debugfs.h>
#include <linux/delay.h>
#include <linux/err.h>
+#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/kernel.h>
+#include <linux/limits.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
-#include <linux/interrupt.h>
#include <linux/of.h>
-#include <linux/pm.h>
#include <linux/platform_device.h>
+#include <linux/pm.h>
#include <linux/reset.h>
#include <linux/watchdog.h>
-#include <linux/debugfs.h>
#define WDOG_CONTROL_REG_OFFSET 0x00
#define WDOG_CONTROL_REG_WDT_EN_MASK 0x01
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [v3] drivers: watchdog: Remove duplicate include of kernel.h
2021-03-25 11:29 [PATCH] [v3] drivers: watchdog: Remove duplicate include of kernel.h Wan Jiabing
@ 2021-03-25 14:36 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-03-25 14:36 UTC (permalink / raw)
To: Wan Jiabing, Wim Van Sebroeck, linux-watchdog, linux-kernel; +Cc: kael_w
On 3/25/21 4:29 AM, Wan Jiabing wrote:
> linux/kernel.h has been included. Remove the duplicate.
> Reorder include files to be in alphabetic order.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Changelog:
> v3:
> - Reorder include files to be in alphabetic order.
>
> v2:
> - Remove the duplicate which won't make worse.
> ---
> drivers/watchdog/dw_wdt.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e1781e63..cd578843277e 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -13,22 +13,21 @@
> */
>
> #include <linux/bitops.h>
> -#include <linux/limits.h>
> -#include <linux/kernel.h>
> #include <linux/clk.h>
> +#include <linux/debugfs.h>
> #include <linux/delay.h>
> #include <linux/err.h>
> +#include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/kernel.h>
> +#include <linux/limits.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> -#include <linux/interrupt.h>
> #include <linux/of.h>
> -#include <linux/pm.h>
> #include <linux/platform_device.h>
> +#include <linux/pm.h>
> #include <linux/reset.h>
> #include <linux/watchdog.h>
> -#include <linux/debugfs.h>
>
> #define WDOG_CONTROL_REG_OFFSET 0x00
> #define WDOG_CONTROL_REG_WDT_EN_MASK 0x01
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-25 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 11:29 [PATCH] [v3] drivers: watchdog: Remove duplicate include of kernel.h Wan Jiabing
2021-03-25 14:36 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).