From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1288C4332F for ; Fri, 20 May 2022 13:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236266AbiETNCE (ORCPT ); Fri, 20 May 2022 09:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236247AbiETNCD (ORCPT ); Fri, 20 May 2022 09:02:03 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CD6035DFC for ; Fri, 20 May 2022 06:02:00 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id u23so14225653lfc.1 for ; Fri, 20 May 2022 06:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=JuZHQ6f7UwG9sEcrBgd7CjvcA+TEESz6YOxMScXKub4=; b=oe7Ihu+Q38xydzIWx7L1VP2mveLIrDlraThtNZ/ZoAz2/WRIXeZBgN41A/MlyIrclb OrX55qBrx2BeXGVMyQKJbo8sTNu1m0W/RI7XqzVOHPKzCVEtYZnvMUGxFIcRe2ku3vab nwDsk93wl9k0K2zNJAs0PP78ghFBgt3k+U/qwe1a+5tmVnQ790bG2ZRF+bm8Og18bq4D qiKQA+S5Bq6mbVtHuUk1zZm0+HdDEDMuIA62eCVS8LFH+eewGz4diDxDPYrnXemlBhfn nhmz/94tEOF8VvLgU7moZKumeAShxaGFQwb50yMb4q+gRqyKCUG2dJw/rM3D6yu14Xb9 CWpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JuZHQ6f7UwG9sEcrBgd7CjvcA+TEESz6YOxMScXKub4=; b=f4TKT8UjBnzFuzQee529HPgn0kf9vtNmSVhLsk9+y7HkIxdRV4CTLYEFWqagPnw1QM 57yuw5EheptrEHXtJNh6XwuZQHaMFU9aN/ImODi08YXCtLm4WGCcxYFtJLPd7D3H2Bj6 rBHZLMyY9XgNJD7E7Qs6ipQBYlwWiHWCobORF2GFfBAToC+FjdEw6UoXupU1gGD4Mm6P BNg7y5Awr1w+w/2pQhnpD0+5MXZyDarbqAxD3sWDiLhdZa7Lltf/1WrUWM/p3y4z4IBP OweLyh1gTKnZlH74lMgvCj2j88L/Kyhdy02D5yDvkfaweAQUFJBBeTk9TM4NtdgQPSo+ PRaw== X-Gm-Message-State: AOAM530u+Hgt4EYrn+mNxhVCbbR/5bRq6QFtznVmw2gqJaKNmUrGvj2d 8LZwEzfhM0Hrg1J5DuFaZ0OuUA== X-Google-Smtp-Source: ABdhPJxWUauG7t9fEtUHzFuI8dk+jUlB1lV9RhKNo3qpTJb8fi//3+EhuolJeMHUbppfvl9h7cj5gA== X-Received: by 2002:a19:4306:0:b0:471:bc59:aeb1 with SMTP id q6-20020a194306000000b00471bc59aeb1mr6715970lfa.566.1653051718531; Fri, 20 May 2022 06:01:58 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id b9-20020a056512024900b0047255d21148sm653005lfo.119.2022.05.20.06.01.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 06:01:58 -0700 (PDT) Message-ID: <4c0c64ac-df79-f677-c6bb-1ba52af41bea@linaro.org> Date: Fri, 20 May 2022 15:01:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/4] watchdog: s3c2410_wdt: support exynosautov9 watchdog Content-Language: en-US To: Chanho Park , Wim Van Sebroeck , Guenter Roeck , Rob Herring Cc: Sam Protsenko , linux-watchdog@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org References: <20220520121750.71473-1-chanho61.park@samsung.com> <20220520121750.71473-3-chanho61.park@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220520121750.71473-3-chanho61.park@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 20/05/2022 14:17, Chanho Park wrote: > @@ -644,9 +675,11 @@ s3c2410_get_wdt_drv_data(struct platform_device *pdev) > > switch (index) { > case 0: > - return &drv_data_exynos850_cl0; > + return variant; > case 1: > - return &drv_data_exynos850_cl1; > + return (variant == &drv_data_exynos850_cl0) ? > + &drv_data_exynos850_cl1 : > + &drv_data_exynosautov9_cl1; This stops scaling... it's fine now, but any next variant will require some rework. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof