From: Guenter Roeck <linux@roeck-us.net>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
wim@linux-watchdog.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com
Cc: linux-watchdog@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] watchdog: stm32_iwdg: drop superfluous error message
Date: Sat, 14 Aug 2021 08:02:25 -0700 [thread overview]
Message-ID: <500cc974-bc39-74d5-1e1c-f763e25caa8b@roeck-us.net> (raw)
In-Reply-To: <20210814142741.7396-1-tangbin@cmss.chinamobile.com>
On 8/14/21 7:27 AM, Tang Bin wrote:
> In the function stm32_iwdg_probe(), devm_platform_ioremap_resource
> has already contained error message, so drop the redundant one.
>
> Co-developed-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/stm32_iwdg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
> index a3436c296..570a71509 100644
> --- a/drivers/watchdog/stm32_iwdg.c
> +++ b/drivers/watchdog/stm32_iwdg.c
> @@ -237,10 +237,8 @@ static int stm32_iwdg_probe(struct platform_device *pdev)
>
> /* This is the timer base. */
> wdt->regs = devm_platform_ioremap_resource(pdev, 0);
> - if (IS_ERR(wdt->regs)) {
> - dev_err(dev, "Could not get resource\n");
> + if (IS_ERR(wdt->regs))
> return PTR_ERR(wdt->regs);
> - }
>
> ret = stm32_iwdg_clk_init(pdev, wdt);
> if (ret)
>
prev parent reply other threads:[~2021-08-14 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 14:27 [PATCH] watchdog: stm32_iwdg: drop superfluous error message Tang Bin
2021-08-14 15:02 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500cc974-bc39-74d5-1e1c-f763e25caa8b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexandre.torgue@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=tangbin@cmss.chinamobile.com \
--cc=wim@linux-watchdog.org \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).