linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] watchdog: stm32_iwdg: drop superfluous error message
@ 2021-08-14 14:27 Tang Bin
  2021-08-14 15:02 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2021-08-14 14:27 UTC (permalink / raw)
  To: wim, linux, mcoquelin.stm32, alexandre.torgue
  Cc: linux-watchdog, linux-stm32, linux-arm-kernel, linux-kernel,
	Tang Bin, Zhang Shengju

In the function stm32_iwdg_probe(), devm_platform_ioremap_resource
has already contained error message, so drop the redundant one.

Co-developed-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
 drivers/watchdog/stm32_iwdg.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
index a3436c296..570a71509 100644
--- a/drivers/watchdog/stm32_iwdg.c
+++ b/drivers/watchdog/stm32_iwdg.c
@@ -237,10 +237,8 @@ static int stm32_iwdg_probe(struct platform_device *pdev)
 
 	/* This is the timer base. */
 	wdt->regs = devm_platform_ioremap_resource(pdev, 0);
-	if (IS_ERR(wdt->regs)) {
-		dev_err(dev, "Could not get resource\n");
+	if (IS_ERR(wdt->regs))
 		return PTR_ERR(wdt->regs);
-	}
 
 	ret = stm32_iwdg_clk_init(pdev, wdt);
 	if (ret)
-- 
2.20.1.windows.1




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] watchdog: stm32_iwdg: drop superfluous error message
  2021-08-14 14:27 [PATCH] watchdog: stm32_iwdg: drop superfluous error message Tang Bin
@ 2021-08-14 15:02 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-08-14 15:02 UTC (permalink / raw)
  To: Tang Bin, wim, mcoquelin.stm32, alexandre.torgue
  Cc: linux-watchdog, linux-stm32, linux-arm-kernel, linux-kernel,
	Zhang Shengju

On 8/14/21 7:27 AM, Tang Bin wrote:
> In the function stm32_iwdg_probe(), devm_platform_ioremap_resource
> has already contained error message, so drop the redundant one.
> 
> Co-developed-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/stm32_iwdg.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
> index a3436c296..570a71509 100644
> --- a/drivers/watchdog/stm32_iwdg.c
> +++ b/drivers/watchdog/stm32_iwdg.c
> @@ -237,10 +237,8 @@ static int stm32_iwdg_probe(struct platform_device *pdev)
>   
>   	/* This is the timer base. */
>   	wdt->regs = devm_platform_ioremap_resource(pdev, 0);
> -	if (IS_ERR(wdt->regs)) {
> -		dev_err(dev, "Could not get resource\n");
> +	if (IS_ERR(wdt->regs))
>   		return PTR_ERR(wdt->regs);
> -	}
>   
>   	ret = stm32_iwdg_clk_init(pdev, wdt);
>   	if (ret)
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-14 15:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-14 14:27 [PATCH] watchdog: stm32_iwdg: drop superfluous error message Tang Bin
2021-08-14 15:02 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).