From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF86C433DF for ; Sun, 19 Jul 2020 13:56:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B99432080D for ; Sun, 19 Jul 2020 13:56:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gFiQAMp9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726390AbgGSN4O (ORCPT ); Sun, 19 Jul 2020 09:56:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbgGSN4O (ORCPT ); Sun, 19 Jul 2020 09:56:14 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9688C0619D2; Sun, 19 Jul 2020 06:56:13 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id p1so7488117pls.4; Sun, 19 Jul 2020 06:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UgldB4wGcq1fUnLz6Vxctj8j+9cNDnU87erHnoDl4AA=; b=gFiQAMp9vaE1h9NNuH0HtjbwSwKuZekC+BTsKF87Ln2lB4MIAu6ECudR9uTfRkoUw6 jF3U3tiqjUvL82jeDcI71Xcb66cSu3q6oFitOzeZYfArrVuZP667kxzXwAnxomzTGRPW j5Ptr+xtCXpx77erU9rQfNHQXThWYS2QQBEeMY/wsxjvgxKJEb91q3bJsqCKlAtAEos3 riNDai3QsANIcj8E4GtEqq2tMFgDpDJh/FLZQDi1eYnPK1qt6dYJ4uMLuA8mmhoKTR4+ ewiVS7pdhPuziesBncgWgYId3Hr3oa7JBgySeLT/farMiZTsVwwfZo8jfa4QMziGBjxn npXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UgldB4wGcq1fUnLz6Vxctj8j+9cNDnU87erHnoDl4AA=; b=U26tCeE/Eg75pgWeQbMqtVERgJmZsvHxubXX4FlGbnLIIt1i5rP/EyIWQG2lQPoq6O XvG+mYsJBah4t6AcJV0GYxSMPUiO6WDeTK45fXxNYiXv9x2t08FnIYbK75JQ3AEFlYx5 NpGYNaSFUcpD2YopbZ2gZcDCwqikyxYmyz/3oFD0hVJsTeLrc8sGGHJFJP+TjiGIT0uI F9jSfGIfngswdOP6LeWTSpK2HN6BbRigAwGiyFrrLOtCEGNZGzBJ4ekcH7lgvKo+g8/P oF7GJwZPRNXkIW4XPkZgkuYH28gy+5uiAsDWjLnHkE079sZhi3QFJCV+UwKFuY/GFO3H 5fDA== X-Gm-Message-State: AOAM530X/tJgYFSI17Bgk5kjps02uUxZjkHncJY/kp3cI59iuT2Nkfyj vJIL3NGJWHnxzLlGBdQM+38= X-Google-Smtp-Source: ABdhPJxWVSuvX6r+XR354iXj8g34eI7uXHaZFnqUlEn/tiDc5TcGsFIpRFN4lJL44NcHJGtlf4yzNA== X-Received: by 2002:a17:902:8681:: with SMTP id g1mr14923298plo.303.1595166973340; Sun, 19 Jul 2020 06:56:13 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n15sm8776089pjf.12.2020.07.19.06.56.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jul 2020 06:56:12 -0700 (PDT) Subject: Re: [PATCHv4 3/4] watchdog: rti-wdt: attach to running watchdog during probe To: Tero Kristo , wim@linux-watchdog.org, linux-watchdog@vger.kernel.org Cc: linux-kernel@vger.kernel.org, jan.kiszka@siemens.com References: <20200717132958.14304-1-t-kristo@ti.com> <20200717132958.14304-4-t-kristo@ti.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <51c30a7c-a0e3-fc0b-2550-64749480a5fb@roeck-us.net> Date: Sun, 19 Jul 2020 06:56:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200717132958.14304-4-t-kristo@ti.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 7/17/20 6:29 AM, Tero Kristo wrote: > If the RTI watchdog is running already during probe, the driver must > configure itself to match the HW. Window size and timeout is probed from > hardware, and the last keepalive ping is adjusted to match it also. > > Signed-off-by: Tero Kristo Reviewed-by: Guenter Roeck > --- > drivers/watchdog/rti_wdt.c | 112 +++++++++++++++++++++++++++++++++---- > 1 file changed, 102 insertions(+), 10 deletions(-) > > diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c > index d456dd72d99a..7cbdc178ffe8 100644 > --- a/drivers/watchdog/rti_wdt.c > +++ b/drivers/watchdog/rti_wdt.c > @@ -35,7 +35,11 @@ > > #define RTIWWDRX_NMI 0xa > > -#define RTIWWDSIZE_50P 0x50 > +#define RTIWWDSIZE_50P 0x50 > +#define RTIWWDSIZE_25P 0x500 > +#define RTIWWDSIZE_12P5 0x5000 > +#define RTIWWDSIZE_6P25 0x50000 > +#define RTIWWDSIZE_3P125 0x500000 > > #define WDENABLE_KEY 0xa98559da > > @@ -48,7 +52,7 @@ > > #define DWDST BIT(1) > > -static int heartbeat; > +static int heartbeat = DEFAULT_HEARTBEAT; > > /* > * struct to hold data for each WDT device > @@ -79,11 +83,9 @@ static int rti_wdt_start(struct watchdog_device *wdd) > * be petted during the open window; not too early or not too late. > * The HW configuration options only allow for the open window size > * to be 50% or less than that; we obviouly want to configure the open > - * window as large as possible so we select the 50% option. To avoid > - * any glitches, we accommodate 5% safety margin also, so we setup > - * the min_hw_hearbeat at 55% of the timeout period. > + * window as large as possible so we select the 50% option. > */ > - wdd->min_hw_heartbeat_ms = 11 * wdd->timeout * 1000 / 20; > + wdd->min_hw_heartbeat_ms = 500 * wdd->timeout; > > /* Generate NMI when wdt expires */ > writel_relaxed(RTIWWDRX_NMI, wdt->base + RTIWWDRXCTRL); > @@ -110,7 +112,48 @@ static int rti_wdt_ping(struct watchdog_device *wdd) > return 0; > } > > -static unsigned int rti_wdt_get_timeleft(struct watchdog_device *wdd) > +static int rti_wdt_setup_hw_hb(struct watchdog_device *wdd, u32 wsize) > +{ > + /* > + * RTI only supports a windowed mode, where the watchdog can only > + * be petted during the open window; not too early or not too late. > + * The HW configuration options only allow for the open window size > + * to be 50% or less than that. > + */ > + switch (wsize) { > + case RTIWWDSIZE_50P: > + /* 50% open window => 50% min heartbeat */ > + wdd->min_hw_heartbeat_ms = 500 * heartbeat; > + break; > + > + case RTIWWDSIZE_25P: > + /* 25% open window => 75% min heartbeat */ > + wdd->min_hw_heartbeat_ms = 750 * heartbeat; > + break; > + > + case RTIWWDSIZE_12P5: > + /* 12.5% open window => 87.5% min heartbeat */ > + wdd->min_hw_heartbeat_ms = 875 * heartbeat; > + break; > + > + case RTIWWDSIZE_6P25: > + /* 6.5% open window => 93.5% min heartbeat */ > + wdd->min_hw_heartbeat_ms = 935 * heartbeat; > + break; > + > + case RTIWWDSIZE_3P125: > + /* 3.125% open window => 96.9% min heartbeat */ > + wdd->min_hw_heartbeat_ms = 969 * heartbeat; > + break; > + > + default: > + return -EINVAL; > + } > + > + return 0; > +} > + > +static unsigned int rti_wdt_get_timeleft_ms(struct watchdog_device *wdd) > { > u64 timer_counter; > u32 val; > @@ -123,11 +166,18 @@ static unsigned int rti_wdt_get_timeleft(struct watchdog_device *wdd) > > timer_counter = readl_relaxed(wdt->base + RTIDWDCNTR); > > + timer_counter *= 1000; > + > do_div(timer_counter, wdt->freq); > > return timer_counter; > } > > +static unsigned int rti_wdt_get_timeleft(struct watchdog_device *wdd) > +{ > + return rti_wdt_get_timeleft_ms(wdd) / 1000; > +} > + > static const struct watchdog_info rti_wdt_info = { > .options = WDIOF_KEEPALIVEPING, > .identity = "K3 RTI Watchdog", > @@ -148,6 +198,7 @@ static int rti_wdt_probe(struct platform_device *pdev) > struct watchdog_device *wdd; > struct rti_wdt_device *wdt; > struct clk *clk; > + u32 last_ping = 0; > > wdt = devm_kzalloc(dev, sizeof(*wdt), GFP_KERNEL); > if (!wdt) > @@ -169,6 +220,14 @@ static int rti_wdt_probe(struct platform_device *pdev) > return -EINVAL; > } > > + /* > + * If watchdog is running at 32k clock, it is not accurate. > + * Adjust frequency down in this case so that we don't pet > + * the watchdog too often. > + */ > + if (wdt->freq < 32768) > + wdt->freq = wdt->freq * 9 / 10; > + > pm_runtime_enable(dev); > ret = pm_runtime_get_sync(dev); > if (ret) { > @@ -185,11 +244,8 @@ static int rti_wdt_probe(struct platform_device *pdev) > wdd->min_timeout = 1; > wdd->max_hw_heartbeat_ms = (WDT_PRELOAD_MAX << WDT_PRELOAD_SHIFT) / > wdt->freq * 1000; > - wdd->timeout = DEFAULT_HEARTBEAT; > wdd->parent = dev; > > - watchdog_init_timeout(wdd, heartbeat, dev); > - > watchdog_set_drvdata(wdd, wdt); > watchdog_set_nowayout(wdd, 1); > watchdog_set_restart_priority(wdd, 128); > @@ -201,12 +257,48 @@ static int rti_wdt_probe(struct platform_device *pdev) > goto err_iomap; > } > > + if (readl(wdt->base + RTIDWDCTRL) == WDENABLE_KEY) { > + u32 time_left_ms; > + u64 heartbeat_ms; > + u32 wsize; > + > + set_bit(WDOG_HW_RUNNING, &wdd->status); > + time_left_ms = rti_wdt_get_timeleft_ms(wdd); > + heartbeat_ms = readl(wdt->base + RTIDWDPRLD); > + heartbeat_ms <<= WDT_PRELOAD_SHIFT; > + heartbeat_ms *= 1000; > + do_div(heartbeat_ms, wdt->freq); > + if (heartbeat_ms != heartbeat * 1000) > + dev_warn(dev, "watchdog already running, ignoring heartbeat config!\n"); > + > + heartbeat = heartbeat_ms; > + heartbeat /= 1000; > + > + wsize = readl(wdt->base + RTIWWDSIZECTRL); > + ret = rti_wdt_setup_hw_hb(wdd, wsize); > + if (ret) { > + dev_err(dev, "bad window size.\n"); > + goto err_iomap; > + } > + > + last_ping = heartbeat_ms - time_left_ms; > + if (time_left_ms > heartbeat_ms) { > + dev_warn(dev, "time_left > heartbeat? Assuming last ping just before now.\n"); > + last_ping = 0; > + } > + } > + > + watchdog_init_timeout(wdd, heartbeat, dev); > + > ret = watchdog_register_device(wdd); > if (ret) { > dev_err(dev, "cannot register watchdog device\n"); > goto err_iomap; > } > > + if (last_ping) > + watchdog_set_last_hw_keepalive(wdd, last_ping); > + > return 0; > > err_iomap: >