From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1DEFC48BC2 for ; Sun, 27 Jun 2021 15:42:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8EF261973 for ; Sun, 27 Jun 2021 15:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230309AbhF0PpT (ORCPT ); Sun, 27 Jun 2021 11:45:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230225AbhF0PpS (ORCPT ); Sun, 27 Jun 2021 11:45:18 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AFE4C061574; Sun, 27 Jun 2021 08:42:54 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id c19-20020a9d6c930000b0290464c2cdfe2bso4372538otr.9; Sun, 27 Jun 2021 08:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3thVEfEpc7oBCh/Z27+kIvV0g7/BSf4GHimjNmLAI/8=; b=rfsm1MHy91CuXvQVQQij4cW7Zsel9ybXCQ4Bg/zbKngnjahskh1NOnTqelKWDLzoH6 MVjUAgGz86qXRsghK7UD8EUcM4dCNgpIUMkehuyaeUaFnkRn8GRDOWPsjV1dNvU/1Duh 2xuMGAHr6s8ItFCcy67OKsgJPeezbfx0KDRCb1wEH1KbxjkUhxsZQEqLNMyS/X/WSTSo cNH0xXzKtkizwhqgkCLChNXghdcg8U6vRtW9IDyb8Hnpk/Tpn8cWJpLb9f3xMZdEZMbo bJuTlID+QmpJkSzV0LsdJyhmJjvIUKk38IMH5Dvu7+1/fyx2u9yxV3Gxv2NP1ebkXjiT JX9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3thVEfEpc7oBCh/Z27+kIvV0g7/BSf4GHimjNmLAI/8=; b=fAWhiond+Vi/BoOQKoSGZQYK146GOWs8W4JvQ19r9RPnCl67KM4I1/8o0zdAPJ6f0H I6bR8EVjsatLcOAGgqDupVYX+fXXQj2bhRlIAhHURqaevSsmHQyZYXFuC6VVKXx0bIdy hltt9hlwXu6dRv1hXHEhSgaZAtGDpUQ78XhDiD0Lm43S1Ldy4bvLDi3swmE1f1n9wyiU cRX1YLBlmEYaoSg6/Wov3mukAsBUcmaCZaarRq5bIMVpYMaRQzb8uPnLAmk9YHvoEtF/ OeP35Jsxcz1Ing+6aK/fFDimfHLpBSWE4sfJuF5KGfgUWa+4rLRBFEvwSPtcY69BG/w8 cFWA== X-Gm-Message-State: AOAM530WbXET4XnYleqsoMV77gvyJ8EfuWVUYDWUnWMHAoiDjIze+RTj osW3352yyZDtujnxFUaO6XQ= X-Google-Smtp-Source: ABdhPJy4+D9Td70nq0/Ra304FJwRaeQ44Jesy5d+gYrZz3MGsnReGMgyHMry5n5m2z9CRD4GS62+pQ== X-Received: by 2002:a9d:4d8d:: with SMTP id u13mr16983789otk.367.1624808573453; Sun, 27 Jun 2021 08:42:53 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 26sm2534781ooy.46.2021.06.27.08.42.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Jun 2021 08:42:52 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH 4/5] watchdog: meson_gxbb_wdt: add stop_on_unregister To: Artem Lapkin , narmstrong@baylibre.com Cc: wim@linux-watchdog.org, khilman@baylibre.com, jbrunet@baylibre.com, christianshewitt@gmail.com, martin.blumenstingl@googlemail.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, art@khadas.com, nick@khadas.com, gouwa@khadas.com References: <20210623024429.1346349-1-art@khadas.com> <20210623024429.1346349-5-art@khadas.com> From: Guenter Roeck Message-ID: <5229d62c-b327-254f-800f-1524f27491b3@roeck-us.net> Date: Sun, 27 Jun 2021 08:42:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210623024429.1346349-5-art@khadas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 6/22/21 7:44 PM, Artem Lapkin wrote: > Added missed watchdog_stop_on_unregister call > This is again personal opinion and needs an acknowledgement by driver authors. It is only necessary if one wants to support that the watchdog is force-stopped by killing the watchdog daemon (which leaves the watchdog running) and subsequently unloading the driver. The call is not 'missing'; otherwise the core could just do it. For that reason it should not be added with the argument that it would be 'missing'. This will require a better argument. Why is that call needed ? What is the use case ? Guenter > Signed-off-by: Artem Lapkin > --- > drivers/watchdog/meson_gxbb_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > index 0bf5dccf70b1..2dbe254e5122 100644 > --- a/drivers/watchdog/meson_gxbb_wdt.c > +++ b/drivers/watchdog/meson_gxbb_wdt.c > @@ -196,6 +196,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) > > meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); > watchdog_set_nowayout(&data->wdt_dev, nowayout); > + watchdog_stop_on_unregister(&data->wdt_dev); > > return devm_watchdog_register_device(dev, &data->wdt_dev); > } >