* [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
@ 2019-09-24 14:31 Andy Shevchenko
2019-09-30 13:15 ` Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Andy Shevchenko @ 2019-09-24 14:31 UTC (permalink / raw)
To: Razvan Becheriu, linux-watchdog, Wim Van Sebroeck, Guenter Roeck
Cc: Andy Shevchenko, Ferry Toth
Normally, the watchdog is disabled when /dev/watchdog is closed, but if
CONFIG_WATCHDOG_NOWAYOUT is defined, then it means that the watchdog should
remain enabled. So we should keep it enabled if CONFIG_WATCHDOG_NOWAYOUT
is defined.
Reported-by: Razvan Becheriu <razvan.becheriu@qualitance.com>
Cc: Ferry Toth <fntoth@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/watchdog/intel-mid_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
index 2cdbd37c700c..470213abfd3d 100644
--- a/drivers/watchdog/intel-mid_wdt.c
+++ b/drivers/watchdog/intel-mid_wdt.c
@@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev)
wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT;
wdt_dev->parent = dev;
+ watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT);
watchdog_set_drvdata(wdt_dev, dev);
ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
2019-09-24 14:31 [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support Andy Shevchenko
@ 2019-09-30 13:15 ` Guenter Roeck
2019-10-29 17:42 ` Ferry Toth
[not found] ` <CAJAoKi8aRHyySUM1mcuub_tgmE7fdLgRyajYF=fUf6QH0PvZPA@mail.gmail.com>
[not found] ` <CAJAoKi_c2XRi_tdJcc3MMS1=9d4WH_Tq9EmH30-GyXcPoJhXGA@mail.gmail.com>
2 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2019-09-30 13:15 UTC (permalink / raw)
To: Andy Shevchenko, Razvan Becheriu, linux-watchdog, Wim Van Sebroeck
Cc: Ferry Toth
On 9/24/19 7:31 AM, Andy Shevchenko wrote:
> Normally, the watchdog is disabled when /dev/watchdog is closed, but if
> CONFIG_WATCHDOG_NOWAYOUT is defined, then it means that the watchdog should
> remain enabled. So we should keep it enabled if CONFIG_WATCHDOG_NOWAYOUT
> is defined.
>
> Reported-by: Razvan Becheriu <razvan.becheriu@qualitance.com>
> Cc: Ferry Toth <fntoth@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/intel-mid_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 2cdbd37c700c..470213abfd3d 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev)
> wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT;
> wdt_dev->parent = dev;
>
> + watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT);
> watchdog_set_drvdata(wdt_dev, dev);
>
> ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
[not found] ` <CAJAoKi8aRHyySUM1mcuub_tgmE7fdLgRyajYF=fUf6QH0PvZPA@mail.gmail.com>
@ 2019-10-01 20:32 ` Andy Shevchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2019-10-01 20:32 UTC (permalink / raw)
To: razvan becheriu
Cc: Razvan Becheriu, linux-watchdog, Wim Van Sebroeck, Guenter Roeck,
Ferry Toth
On Tue, Oct 01, 2019 at 10:08:53PM +0300, razvan becheriu wrote:
> PS: sry for sending this several times, I get a message like:
> Message may contain a virus
> Your message wasn't delivered to linux-watchdog@vger.kernel.org because it
> may contain a virus. Learn how to check for and prevent viruses.
You need to send the message as plain text. You may test yourself without
spamming people by sending to some other address which you have access to.
All there messages I got have HTML part. Usually it shows MUA misconfiguration.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
[not found] ` <CAJAoKi_c2XRi_tdJcc3MMS1=9d4WH_Tq9EmH30-GyXcPoJhXGA@mail.gmail.com>
@ 2019-10-02 6:11 ` razvan becheriu
2019-10-02 8:31 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: razvan becheriu @ 2019-10-02 6:11 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Razvan Becheriu, linux-watchdog, Wim Van Sebroeck, Guenter Roeck,
Ferry Toth
Hi,
regarding the test for the WATCHDOG_NOWAYOUT patch:
```
Tested-by: Razvan Becheriu <razvan.becheriu@gmail.com>
The patch works.
By configuring the CONFIG_WATCHDOG_NOWAYOUT in the kernel and stopping
the watchdog.service, the board reboots.
Previously, the watchdog.service was able to disable the watchdog
counter, and no reboot was performed.
```
Thank you,
Razvan
On Tue, Oct 1, 2019 at 10:06 PM razvan becheriu
<razvan.becheriu@gmail.com> wrote:
>
> Hi,
>
> regarding the test for the WATCHDOG_NOWAYOUT patch:
>
> ...
> Tested-by: Razvan Becheriu <razvan.becheriu@gmail.com>
> The patch works.
> By configuring the CONFIG_WATCHDOG_NOWAYOUT in the kernel and stopping the watchdog.service, the board reboots.
> Previously, the watchdog.service was able to disable the watchdog counter, and no reboot was performed.
> ...
>
> Thank you,
> Razvan
>
> On Tue, Sep 24, 2019 at 6:13 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>>
>> Normally, the watchdog is disabled when /dev/watchdog is closed, but if
>> CONFIG_WATCHDOG_NOWAYOUT is defined, then it means that the watchdog should
>> remain enabled. So we should keep it enabled if CONFIG_WATCHDOG_NOWAYOUT
>> is defined.
>>
>> Reported-by: Razvan Becheriu <razvan.becheriu@qualitance.com>
>> Cc: Ferry Toth <fntoth@gmail.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> drivers/watchdog/intel-mid_wdt.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
>> index 2cdbd37c700c..470213abfd3d 100644
>> --- a/drivers/watchdog/intel-mid_wdt.c
>> +++ b/drivers/watchdog/intel-mid_wdt.c
>> @@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev)
>> wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT;
>> wdt_dev->parent = dev;
>>
>> + watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT);
>> watchdog_set_drvdata(wdt_dev, dev);
>>
>> ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,
>> --
>> 2.23.0
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
2019-10-02 6:11 ` razvan becheriu
@ 2019-10-02 8:31 ` Andy Shevchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2019-10-02 8:31 UTC (permalink / raw)
To: razvan becheriu
Cc: Razvan Becheriu, linux-watchdog, Wim Van Sebroeck, Guenter Roeck,
Ferry Toth
On Wed, Oct 02, 2019 at 09:11:33AM +0300, razvan becheriu wrote:
> regarding the test for the WATCHDOG_NOWAYOUT patch:
>
> ```
> Tested-by: Razvan Becheriu <razvan.becheriu@gmail.com>
> The patch works.
> By configuring the CONFIG_WATCHDOG_NOWAYOUT in the kernel and stopping
> the watchdog.service, the board reboots.
> Previously, the watchdog.service was able to disable the watchdog
> counter, and no reboot was performed.
> ```
Thank you!
Now you can find it in archives [1].
[1]: https://lore.kernel.org/linux-watchdog/CAJAoKi_C85WDxu_XppFhn7BjZC1GznqQrPFKW9W2wEpHzz4wPw@mail.gmail.com/T/#t
For the future, please avoid top postings.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
2019-09-30 13:15 ` Guenter Roeck
@ 2019-10-29 17:42 ` Ferry Toth
2019-10-30 0:13 ` Guenter Roeck
0 siblings, 1 reply; 7+ messages in thread
From: Ferry Toth @ 2019-10-29 17:42 UTC (permalink / raw)
To: Guenter Roeck, Andy Shevchenko, Razvan Becheriu, linux-watchdog,
Wim Van Sebroeck
Op 30-09-2019 om 15:15 schreef Guenter Roeck:
> On 9/24/19 7:31 AM, Andy Shevchenko wrote:
>> Normally, the watchdog is disabled when /dev/watchdog is closed, but if
>> CONFIG_WATCHDOG_NOWAYOUT is defined, then it means that the watchdog
>> should
>> remain enabled. So we should keep it enabled if CONFIG_WATCHDOG_NOWAYOUT
>> is defined.
>>
>> Reported-by: Razvan Becheriu <razvan.becheriu@qualitance.com>
>> Cc: Ferry Toth <fntoth@gmail.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Any chance of this going in v5.4?
>> ---
>> drivers/watchdog/intel-mid_wdt.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/watchdog/intel-mid_wdt.c
>> b/drivers/watchdog/intel-mid_wdt.c
>> index 2cdbd37c700c..470213abfd3d 100644
>> --- a/drivers/watchdog/intel-mid_wdt.c
>> +++ b/drivers/watchdog/intel-mid_wdt.c
>> @@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device
>> *pdev)
>> wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT;
>> wdt_dev->parent = dev;
>> + watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT);
>> watchdog_set_drvdata(wdt_dev, dev);
>> ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
2019-10-29 17:42 ` Ferry Toth
@ 2019-10-30 0:13 ` Guenter Roeck
0 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2019-10-30 0:13 UTC (permalink / raw)
To: Ferry Toth, Andy Shevchenko, Razvan Becheriu, linux-watchdog,
Wim Van Sebroeck
On 10/29/19 10:42 AM, Ferry Toth wrote:
> Op 30-09-2019 om 15:15 schreef Guenter Roeck:
>> On 9/24/19 7:31 AM, Andy Shevchenko wrote:
>>> Normally, the watchdog is disabled when /dev/watchdog is closed, but if
>>> CONFIG_WATCHDOG_NOWAYOUT is defined, then it means that the watchdog should
>>> remain enabled. So we should keep it enabled if CONFIG_WATCHDOG_NOWAYOUT
>>> is defined.
>>>
>>> Reported-by: Razvan Becheriu <razvan.becheriu@qualitance.com>
>>> Cc: Ferry Toth <fntoth@gmail.com>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> Any chance of this going in v5.4?
>
Good question. There are a few other pending bug fixes, including one
which fixes a build failure. Wim, any chance you can queue those up ?
Thanks,
Guenter
>>> ---
>>> drivers/watchdog/intel-mid_wdt.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
>>> index 2cdbd37c700c..470213abfd3d 100644
>>> --- a/drivers/watchdog/intel-mid_wdt.c
>>> +++ b/drivers/watchdog/intel-mid_wdt.c
>>> @@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev)
>>> wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT;
>>> wdt_dev->parent = dev;
>>> + watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT);
>>> watchdog_set_drvdata(wdt_dev, dev);
>>> ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,
>>>
>>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-30 0:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-24 14:31 [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support Andy Shevchenko
2019-09-30 13:15 ` Guenter Roeck
2019-10-29 17:42 ` Ferry Toth
2019-10-30 0:13 ` Guenter Roeck
[not found] ` <CAJAoKi8aRHyySUM1mcuub_tgmE7fdLgRyajYF=fUf6QH0PvZPA@mail.gmail.com>
2019-10-01 20:32 ` Andy Shevchenko
[not found] ` <CAJAoKi_c2XRi_tdJcc3MMS1=9d4WH_Tq9EmH30-GyXcPoJhXGA@mail.gmail.com>
2019-10-02 6:11 ` razvan becheriu
2019-10-02 8:31 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).