linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Curtis Klein <curtis.klein@hpe.com>,
	wim@linux-watchdog.org, linux@roeck-us.net
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v3] watchdog: Add hrtimer-based pretimeout feature
Date: Thu, 2 Sep 2021 08:55:37 +0200	[thread overview]
Message-ID: <67d601c9-8f95-cb10-40df-4d962ec6f9ba@kernel.org> (raw)
In-Reply-To: <1612383090-27110-1-git-send-email-curtis.klein@hpe.com>

On 03. 02. 21, 21:11, Curtis Klein wrote:
> This adds the option to use a hrtimer to generate a watchdog pretimeout
> event for hardware watchdogs that do not natively support watchdog
> pretimeouts.
> 
> With this enabled, all watchdogs will appear to have pretimeout support
> in userspace. If no pretimeout value is set, there will be no change in
> the watchdog's behavior.

Hi,

on my Dell Latitude 7280, CONFIG_WATCHDOG_HRTIMER_PRETIMEOUT=y causes 
all reboot, kexec, suspend to panic. Disabling that option makes it all 
work again. Provided it happens very late in the process, I don't know 
how to grab some logs...

Any ideas?

...
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -73,6 +73,14 @@ config WATCHDOG_SYSFS
>   	  Say Y here if you want to enable watchdog device status read through
>   	  sysfs attributes.
>   
> +config WATCHDOG_HRTIMER_PRETIMEOUT
> +	bool "Enable watchdog hrtimer-based pretimeouts"
> +	help
> +	  Enable this if you want to use a hrtimer timer based pretimeout for
> +	  watchdogs that do not natively support pretimeout support. Be aware
> +	  that because this pretimeout functionality uses hrtimers, it may not
> +	  be able to fire before the actual watchdog fires in some situations.

thanks,
-- 
js
suse labs

  parent reply	other threads:[~2021-09-02  6:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 20:11 Curtis Klein
2021-02-04  1:35 ` Guenter Roeck
2021-09-02  6:55 ` Jiri Slaby [this message]
2021-09-02 14:05   ` Guenter Roeck
2021-09-04  8:16     ` was [Re: [PATCH v3] watchdog: Add hrtimer-based pretimeout feature] Jiri Slaby
     [not found]       ` <54d77fb1-2531-c6ed-738e-9f661443b097@kernel.org>
2021-09-05 22:22         ` Klein, Curtis
2021-09-05 22:56           ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67d601c9-8f95-cb10-40df-4d962ec6f9ba@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=curtis.klein@hpe.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    --subject='Re: [PATCH v3] watchdog: Add hrtimer-based pretimeout feature' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).