From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8AB7C10DCE for ; Fri, 13 Mar 2020 16:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B81E32072C for ; Fri, 13 Mar 2020 16:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbgCMQMn (ORCPT ); Fri, 13 Mar 2020 12:12:43 -0400 Received: from mail-sz.amlogic.com ([211.162.65.117]:12635 "EHLO mail-sz.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbgCMQMn (ORCPT ); Fri, 13 Mar 2020 12:12:43 -0400 Received: from [10.28.90.144] (10.28.90.144) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server id 15.1.1591.10; Sat, 14 Mar 2020 00:13:10 +0800 Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible To: Julius Werner CC: Evan Benn , Mark Rutland , , LINUX-WATCHDOG , Jianxin Pan , Rob Herring , Greg Kroah-Hartman , LKML , Yonghui Yu , Jonathan Cameron , Mauro Carvalho Chehab , "open list:ARM/Amlogic Meson..." , Wim Van Sebroeck , "David S. Miller" , Guenter Roeck References: <20200214062637.216209-1-evanbenn@chromium.org> <20200214172512.1.I02ebc5b8743b1a71e0e15f68ea77e506d4e6f840@changeid> <20200219223046.GA16537@bogus> <20200219232005.GA9737@roeck-us.net> <1326f594-3cfd-c03d-4f2c-50eeb75724b2@amlogic.com> From: Xingyu Chen Message-ID: <6e846246-dfd5-c002-cd61-41c2d11a2e54@amlogic.com> Date: Sat, 14 Mar 2020 00:13:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [10.28.90.144] Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Hi, Julius On 2020/3/12 3:24, Julius Werner wrote: >> - *_INIT and *GETTIMEOUT. Although your driver does not need them, could you take them as options in your driver ? > The driver already has SMCWD_INFO which is used during probe to > retrieve the minimum and maximum timeout values supported by the > hardware at probe time. Maybe it would make sense to rename that to > INIT (which would still return those values, but can also do whatever > initialization needs to be done in TF)? Yes，INIT would make sense for me. > GETTIMELEFT I agree we can > implement optionally, and other platforms would just return a > PSCI_RET_NOT_SUPPORTED for that. > >> - *_RESETNOW. It is used to reset the system right now, similar to your SOFT RESET. could you reserve an operation index in ATF ? > Just curious, why do you need this? Shouldn't you use the PSCI > standard SYSTEM_RESET SMC for that? (If you want to control exactly > how the platform is reset, you could also use SYSTEM_RESET2 with a > vendor-defined reset_type.) I just wanted it to be compatible with other OS，and I  think it over, maybe I can also use the PSCI interface to execuate the system reset on the other OS. Anyway, please ignore this request. Thanks. > > .