From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A433C7618A for ; Mon, 20 Mar 2023 10:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbjCTKSQ (ORCPT ); Mon, 20 Mar 2023 06:18:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229837AbjCTKSP (ORCPT ); Mon, 20 Mar 2023 06:18:15 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E782F10259 for ; Mon, 20 Mar 2023 03:18:12 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id o12so44500929edb.9 for ; Mon, 20 Mar 2023 03:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679307491; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M9QmThArlU3j/do0x0/HOKynN3iklRKOHG46pnLsnHw=; b=cfKIOkAWt2qSqihZu+iJRamjO6lMQhnDcRYEV6P8j561vRc+Apj+CESbo74m4MU+20 z9OBbShtAEkZXCjwdfPwxH/ywg1w5QPwP9bau6B9z4Q/oH49tCRBl8T+BkWeKhLPydnM lnzyhQdu7Vb9qPzNsdiq1JFCZoZzQO4X8acut3VxbpUKfcKZuLNLV+0Z3L5DqNDZ+xsK JnHhYXCM5S9UEVNvGNen4IMgdSyYhxc2QKDgIBv0N2CAk6ckjDpirwCHmctbEqCf1bmS T/4zDrlak6vMHplZHupoUBnpvz8So809N2GkYn2G45EMTc8ETGSxAl64KotQ1g3KGbwp 8/hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679307491; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M9QmThArlU3j/do0x0/HOKynN3iklRKOHG46pnLsnHw=; b=dd32+jye3bBNVte9f8sEG9q4BIrBfeKtazGrwP5H6h+nkjCNzZgd9uLxjWikqSq3qY zoOzA9Fp5D7WIjb7VmzMyztgP2go0Gs4MCLRNHBHs+RGj7JF0uLBzJWRqbJzs06Vjtz6 4K0CBbs1pK7pnTTNzIckpDKR0oVAlfo8ZnxCKkAJls4ZxpZlOyj0ToXIq3r9P5Bl3Civ bzPt+3QCq9SlWMfTDwfhTETB0h0Dh0sxGGVD4RZ7LPpX+VWSHmWlNLsZiP0iFnbJ201O 3cQbF1UqrPx6bbOx467IFfE6f35+7XD1xbW+ZKj0EzGmSSihA9xqRZFjKglOJmLZmoIu flcw== X-Gm-Message-State: AO0yUKXqnnUDo4NTZN2KW22cOaQJZkzke6hU0uS8LLr7A7RvSQolmFjR 7F+8XzDL0PtH0rIUOQN1GoQ3IIYKj6GQZGZOjLg= X-Google-Smtp-Source: AK7set+TovgWorTvh0ACBLoB6PXtYdY+uBaQ+fhbXWNdFqjwNLDcjjjMwN+Ujio9D2J6NyIVvckFig== X-Received: by 2002:a05:6402:12c1:b0:4ff:844a:ed4c with SMTP id k1-20020a05640212c100b004ff844aed4cmr12664996edx.0.1679307491486; Mon, 20 Mar 2023 03:18:11 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:4428:8354:afb6:2992? ([2a02:810d:15c0:828:4428:8354:afb6:2992]) by smtp.gmail.com with ESMTPSA id o2-20020a509b02000000b004faa1636758sm4633214edi.68.2023.03.20.03.18.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 03:18:11 -0700 (PDT) Message-ID: <713745fe-4963-6008-89b8-f0fb68c8056c@linaro.org> Date: Mon, 20 Mar 2023 11:18:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5332: add few device nodes Content-Language: en-US To: Kathiravan T , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230320094450.8015-1-quic_kathirav@quicinc.com> <20230320094450.8015-3-quic_kathirav@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230320094450.8015-3-quic_kathirav@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 20/03/2023 10:44, Kathiravan T wrote: > Add the nodes for QUP peripheral, PRNG and WDOG. While at it, enable the > I2C device for MI01.2 board. > > Signed-off-by: Kathiravan T > --- > arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts | 14 +++++ > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 67 +++++++++++++++++++++ > 2 files changed, 81 insertions(+) Thank you for your patch. There is something to discuss/improve. > + > blsp1_uart0: serial@78af000 { > compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; > reg = <0x078af000 0x200>; > @@ -201,6 +218,48 @@ > status = "disabled"; > }; > > + blsp1_spi0: spi@78b5000 { > + compatible = "qcom,spi-qup-v2.2.1"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x078b5000 0x600>; Please keep the reg as second property, after compatible. Best regards, Krzysztof