From: Neil Armstrong <narmstrong@baylibre.com>
To: Guenter Roeck <linux@roeck-us.net>, Artem Lapkin <email2tema@gmail.com>
Cc: wim@linux-watchdog.org, khilman@baylibre.com,
jbrunet@baylibre.com, christianshewitt@gmail.com,
martin.blumenstingl@googlemail.com,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
art@khadas.com, nick@khadas.com, gouwa@khadas.com
Subject: Re: [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot
Date: Fri, 30 Jul 2021 10:20:06 +0200 [thread overview]
Message-ID: <7832d036-3811-544e-8007-fe719bb38ded@baylibre.com> (raw)
In-Reply-To: <20210730045857.GC2110311@roeck-us.net>
Hi Guenter,
On 30/07/2021 06:58, Guenter Roeck wrote:
> On Fri, Jul 30, 2021 at 12:13:55PM +0800, Artem Lapkin wrote:
>> Remove watchdog_stop_on_reboot()
>>
>> Meson platform still have some hardware drivers problems for some
>> configurations which can freeze device on shutdown/reboot stage and i
>> think better to have reboot warranty by default.
>>
>> I feel that it is important to keep the watchdog running during the
>> reboot sequence, in the event that an abnormal driver freezes the reboot
>> process.
>>
>> This is my personal opinion and I hope the driver authors will agree
>> with my proposal, or just ignore this commit if not.
>>
>> https://lore.kernel.org/linux-watchdog/20210729072308.1908904-1-art@khadas.com/T/#t
>>
>
> A much better description would be something like
>
> "The Meson platform still has some hardware drivers problems for some
> configurations which can freeze devices on shutdown/reboot.
> Remove watchdog_stop_on_reboot() to catch this situation and ensure
> that the reboot happens anyway.
> Users who still want to stop the watchdog on reboot can still do so
> using the watchdog.stop_on_reboot=1 module parameter.
> "
>
> That leaves the personal opinion out of the picture and provides both
> a rationale for the change and an alternative for people who want
> to stop the watchdog on reboot anyway.
>
>> Signed-off-by: Artem Lapkin <art@khadas.com>
>
> As mentioned, I'd still like to get an opinion from the driver
> author and/or some other users of this platform. However, I'll
> accept the patch with the above description change if I don't get
> additional feedback.
Sorry for the reply delay and thanks a lot for your review.
The rationale from Artem is OK for me.
Please add my Acked-by for the whole patchset.
Neil
>
> Thanks,
> Guenter
>
>> ---
>> drivers/watchdog/meson_gxbb_wdt.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c
>> index 945f5e65db57..d3c9e2f6e63b 100644
>> --- a/drivers/watchdog/meson_gxbb_wdt.c
>> +++ b/drivers/watchdog/meson_gxbb_wdt.c
>> @@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)
>>
>> meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout);
>>
>> - watchdog_stop_on_reboot(&data->wdt_dev);
>> return devm_watchdog_register_device(dev, &data->wdt_dev);
>> }
>>
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2021-07-30 8:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 4:13 [PATCH v4 0/3] watchdog: meson_gxbb_wdt: improve Artem Lapkin
2021-07-30 4:13 ` [PATCH v4 1/3] watchdog: meson_gxbb_wdt: add nowayout parameter Artem Lapkin
2021-07-30 4:45 ` Guenter Roeck
2021-11-09 7:59 ` Art Nikpal
2021-07-30 4:13 ` [PATCH v4 2/3] watchdog: meson_gxbb_wdt: add timeout parameter Artem Lapkin
2021-07-30 4:47 ` Guenter Roeck
2021-11-09 7:59 ` Art Nikpal
2021-07-30 4:13 ` [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot Artem Lapkin
2021-07-30 4:58 ` Guenter Roeck
2021-07-30 6:52 ` Art Nikpal
2021-07-30 8:20 ` Neil Armstrong [this message]
2021-11-09 7:59 ` Art Nikpal
2021-11-09 15:30 ` Guenter Roeck
2021-11-10 2:27 ` Art Nikpal
2021-11-09 7:58 ` [PATCH v4 0/3] watchdog: meson_gxbb_wdt: improve Art Nikpal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7832d036-3811-544e-8007-fe719bb38ded@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=art@khadas.com \
--cc=christianshewitt@gmail.com \
--cc=email2tema@gmail.com \
--cc=gouwa@khadas.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.blumenstingl@googlemail.com \
--cc=nick@khadas.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).