linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] watchdog: sc520_wdt: Fix possible use-after-free in wdt_turnoff()
@ 2021-05-11  7:04 Zou Wei
  2021-05-11 13:37 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2021-05-11  7:04 UTC (permalink / raw)
  To: wim, linux; +Cc: linux-watchdog, linux-kernel, Zou Wei

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/watchdog/sc520_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/sc520_wdt.c b/drivers/watchdog/sc520_wdt.c
index e66e6b9..ca65468 100644
--- a/drivers/watchdog/sc520_wdt.c
+++ b/drivers/watchdog/sc520_wdt.c
@@ -186,7 +186,7 @@ static int wdt_startup(void)
 static int wdt_turnoff(void)
 {
 	/* Stop the timer */
-	del_timer(&timer);
+	del_timer_sync(&timer);
 
 	/* Stop the watchdog */
 	wdt_config(0);
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] watchdog: sc520_wdt: Fix possible use-after-free in wdt_turnoff()
  2021-05-11  7:04 [PATCH -next] watchdog: sc520_wdt: Fix possible use-after-free in wdt_turnoff() Zou Wei
@ 2021-05-11 13:37 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-05-11 13:37 UTC (permalink / raw)
  To: Zou Wei, wim; +Cc: linux-watchdog, linux-kernel

On 5/11/21 12:04 AM, Zou Wei wrote:
> This module's remove path calls del_timer(). However, that function
> does not wait until the timer handler finishes. This means that the
> timer handler may still be running after the driver's remove function
> has finished, which would result in a use-after-free.
> 
> Fix by calling del_timer_sync(), which makes sure the timer handler
> has finished, and unable to re-schedule itself.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/sc520_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/sc520_wdt.c b/drivers/watchdog/sc520_wdt.c
> index e66e6b9..ca65468 100644
> --- a/drivers/watchdog/sc520_wdt.c
> +++ b/drivers/watchdog/sc520_wdt.c
> @@ -186,7 +186,7 @@ static int wdt_startup(void)
>   static int wdt_turnoff(void)
>   {
>   	/* Stop the timer */
> -	del_timer(&timer);
> +	del_timer_sync(&timer);
>   
>   	/* Stop the watchdog */
>   	wdt_config(0);
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-11 13:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11  7:04 [PATCH -next] watchdog: sc520_wdt: Fix possible use-after-free in wdt_turnoff() Zou Wei
2021-05-11 13:37 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).