From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B341C4338F for ; Wed, 4 Aug 2021 06:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 640FF60F35 for ; Wed, 4 Aug 2021 06:58:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235235AbhHDG6u (ORCPT ); Wed, 4 Aug 2021 02:58:50 -0400 Received: from goliath.siemens.de ([192.35.17.28]:50999 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235227AbhHDG6u (ORCPT ); Wed, 4 Aug 2021 02:58:50 -0400 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 1746wHWd023426 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Aug 2021 08:58:17 +0200 Received: from [139.22.36.137] ([139.22.36.137]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 1746wGge023617; Wed, 4 Aug 2021 08:58:17 +0200 Subject: Re: Faulty commit "watchdog: iTCO_wdt: Account for rebooting on second timeout" To: Michael Marley , Jean Delvare , linux-watchdog@vger.kernel.org, LKML , stable@vger.kernel.org Cc: Guenter Roeck , Wim Van Sebroeck References: <20210803165108.4154cd52@endymion> <934e0af4-3c4c-3ac5-30e2-958f0725a21d@michaelmarley.com> From: Jan Kiszka Message-ID: <788533fa-0b77-4c44-2906-d8c9b2b8997d@siemens.com> Date: Wed, 4 Aug 2021 08:58:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <934e0af4-3c4c-3ac5-30e2-958f0725a21d@michaelmarley.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 04.08.21 02:04, Michael Marley wrote: > On 8/3/21 10:59 AM, Jan Kiszka wrote: > >> https://lkml.org/lkml/2021/7/26/349 >> > > It fixes the problem for me (the person who opened the Bugzilla report) > too, thanks! > > Tested-by: Michael Marley > Thanks for the confirmation! Yeah, sorry, that original mistake is truly mine. In fact, I wrote this code twice [1] but only messed it up here. Unfortunate that it spread so quickly. I'll try discuss this with stable people eventually, if it was a one off or if there are more such cases. Jan [1] https://github.com/siemens/efibootguard/commit/aa89fe3cbd883198c23eaec43c4448fe9e8ae148 -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux