From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v3 2/3] watchdog: f71808e_wdt: migrate to new kernel watchdog API
Date: Mon, 3 May 2021 16:39:25 +0200 [thread overview]
Message-ID: <9f326f40-08dd-ab2b-0a80-970d20c57d6a@pengutronix.de> (raw)
In-Reply-To: <92b48338-4d9a-dc02-d8b5-198bd34c9f21@roeck-us.net>
Hello Guenter,
On 03.05.21 16:31, Guenter Roeck wrote:
>> -static struct fintek_wdt watchdog = {
>> - .lock = __MUTEX_INITIALIZER(watchdog.lock),
>> -};
>> +static struct fintek_wdt watchdog;
>
> This should really be allocated, and "watchdog" is a terrible variable name
> even if static, especially given the previous patch.
I can add a follow up patch to change this. I maintained the old
state of things here to make review easier.
>
>>
>> /* Super I/O functions */
>> static inline int superio_inb(int base, int reg)
>> @@ -218,17 +206,9 @@ static inline void superio_exit(int base)
>> release_region(base, 2);
>> }
>>
>> -static int fintek_wdt_set_timeout(int timeout)
>> +static int fintek_wdt_set_timeout(struct watchdog_device *wdd, unsigned int timeout)
>> {
>> - if (timeout <= 0
>> - || timeout > max_timeout) {
>> - pr_err("watchdog timeout out of range\n");
>> - return -EINVAL;
>> - }
>> -
>> - mutex_lock(&watchdog.lock);
>> -
>> - watchdog.timeout = timeout;
>> + wdd->timeout = timeout;
>
> This needs to save the actual timeout, which differs from the
> configured one if larger than 255.
Oh, makes sense. Will changes with v4.
Thanks,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-05-03 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 10:46 [RESEND PATCH v3 0/3] watchdog: f71808e_wdt: migrate to new kernel API Ahmad Fatoum
2021-04-13 10:46 ` [RESEND PATCH v3 1/3] watchdog: f71808e_wdt: rename variant-independent identifiers appropriately Ahmad Fatoum
2021-04-13 10:46 ` [RESEND PATCH v3 2/3] watchdog: f71808e_wdt: migrate to new kernel watchdog API Ahmad Fatoum
2021-05-03 14:31 ` Guenter Roeck
2021-05-03 14:39 ` Ahmad Fatoum [this message]
2021-05-03 15:28 ` Guenter Roeck
2021-05-03 18:33 ` Ahmad Fatoum
2021-04-13 10:46 ` [RESEND PATCH v3 3/3] watchdog: f71808e_wdt: refactor to platform device/driver pair Ahmad Fatoum
2021-05-03 13:09 ` [RESEND PATCH v3 0/3] watchdog: f71808e_wdt: migrate to new kernel API Marc Kleine-Budde
2021-05-03 13:33 ` Guenter Roeck
2021-05-03 13:49 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f326f40-08dd-ab2b-0a80-970d20c57d6a@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).