From: "Sanil, Shruthi" <shruthi.sanil@intel.com>
To: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"kris.pan@linux.intel.com" <kris.pan@linux.intel.com>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"Thokala, Srikanth" <srikanth.thokala@intel.com>,
"Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>,
"Sangannavar,
Mallikarjunappa" <mallikarjunappa.sangannavar@intel.com>
Subject: RE: [PATCH v2 0/9] Intel Keem Bay WDT bug fixes
Date: Mon, 24 May 2021 06:06:35 +0000 [thread overview]
Message-ID: <BYAPR11MB312848D2D369C78BD2E969F0F1269@BYAPR11MB3128.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210517174953.19404-1-shruthi.sanil@intel.com>
Hi Roeck,
I have addressed your review comments in the v2 version of this patch series.
Could you please review?
If no comments, can I get an Acked-by tag?
Thanks!
Regards,
Shruthi
> -----Original Message-----
> From: Sanil, Shruthi <shruthi.sanil@intel.com>
> Sent: Monday, May 17, 2021 11:20 PM
> To: wim@linux-watchdog.org; linux@roeck-us.net; linux-
> watchdog@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: andriy.shevchenko@linux.intel.com; kris.pan@linux.intel.com;
> mgross@linux.intel.com; Thokala, Srikanth <srikanth.thokala@intel.com>;
> Raja Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>;
> Sangannavar, Mallikarjunappa <mallikarjunappa.sangannavar@intel.com>;
> Sanil, Shruthi <shruthi.sanil@intel.com>
> Subject: [PATCH v2 0/9] Intel Keem Bay WDT bug fixes
>
> From: Shruthi Sanil <shruthi.sanil@intel.com>
>
> The series of patches include the below bug fixes in the Intel Keem Bay
> watchdog timer driver:
>
> Patch 1/9:
> - Update WDT pre-timeout during the initialization
> The pretimeout register has a default reset value. Hence
> when a smaller WDT timeout is set which would be lesser than the
> default pretimeout, the system behaves abnormally, starts
> triggering the pretimeout interrupt even when the WDT is
> not enabled, most of the times leading to system crash.
> Hence an update in the pre-timeout is also required for the
> default timeout that is being configured.
>
> Patch 2/9:
> - Upadate WDT pretimeout for every update in timeout
> The pre-timeout value to be programmed to the register has to be
> calculated and updated for every change in the timeout value.
> Else the threshold time wouldn't be calculated to its
> corresponding timeout.
>
> Patch 3/9:
> - Update pretimeout to 0 in the TH ISR
> The pretimeout has to be updated to 0 during the ISR of the
> ThresHold interrupt. Else the TH interrupt would be triggerred for
> every tick until the timeout.
>
> Patch 4/9:
> - Clear either the TO or TH interrupt bit
> During the interrupt service routine of the TimeOut interrupt and
> the ThresHold interrupt, the respective interrupt clear bit
> have to be cleared and not both.
>
> Patch 5/9:
> - Remove timeout update in the WDT start function
> Removed set timeout from the start WDT function. There is a function
> defined to set the timeout. Hence no need to set the timeout again in
> start function as the timeout would have been already updated
> before calling the start/enable.
>
> Patch 6/9:
> - Removed timeout update in the TO ISR
> In the TO ISR removed updating the Timeout value because
> its not serving any purpose as the timer would have already expired
> and the system would be rebooting.
>
> Patch 7/9:
> - MACRO for WDT enable and disable values
> Introduced MACRO's for WDT enable and disable values for better
> readability
>
> Patch 8/9:
> - WDT SMC handler MACRO name update
> Updated the WDT SMC handler MACRO name to make it clear that its
> a ARM SMC handler that helps in clearing the WDT interrupt bit.
>
> Patch 9/9:
> - Typo corrections and other blank operations
> Corrected typos, aligned the tabs and added new lines
> wherever required for better readability
>
> Changes since v1:
> - Dropped a patch with the incorrect fix
> regarding the WDT suspend/resume function.
>
> Shruthi Sanil (9):
> watchdog: keembay: Update WDT pre-timeout during the initialization
> watchdog: keembay: Upadate WDT pretimeout for every update in timeout
> watchdog: keembay: Update pretimeout to zero in the TH ISR
> watchdog: keembay: Clear either the TO or TH interrupt bit
> watchdog: keembay: Remove timeout update in the WDT start function
> watchdog: keembay: Removed timeout update in the TO ISR
> watchdog: keembay: MACRO for WDT enable and disable values
> watchdog: keembay: WDT SMC handler MACRO name update
> watchdog: keembay: Typo corrections and other blank operations
>
> drivers/watchdog/keembay_wdt.c | 34 ++++++++++++++++++++++------------
> 1 file changed, 22 insertions(+), 12 deletions(-)
>
>
> base-commit: 88b06399c9c766c283e070b022b5ceafa4f63f19
> --
> 2.17.1
next prev parent reply other threads:[~2021-05-24 6:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 17:49 [PATCH v2 0/9] Intel Keem Bay WDT bug fixes shruthi.sanil
2021-05-17 17:49 ` [PATCH v2 1/9] watchdog: keembay: Update WDT pre-timeout during the initialization shruthi.sanil
2021-05-17 17:49 ` [PATCH v2 2/9] watchdog: keembay: Upadate WDT pretimeout for every update in timeout shruthi.sanil
2021-05-17 17:49 ` [PATCH v2 3/9] watchdog: keembay: Update pretimeout to zero in the TH ISR shruthi.sanil
2021-05-17 17:49 ` [PATCH v2 4/9] watchdog: keembay: Clear either the TO or TH interrupt bit shruthi.sanil
2021-05-17 17:49 ` [PATCH v2 5/9] watchdog: keembay: Remove timeout update in the WDT start function shruthi.sanil
2021-05-17 17:49 ` [PATCH v2 6/9] watchdog: keembay: Removed timeout update in the TO ISR shruthi.sanil
2021-05-17 17:49 ` [PATCH v2 7/9] watchdog: keembay: MACRO for WDT enable and disable values shruthi.sanil
2021-05-17 17:49 ` [PATCH v2 8/9] watchdog: keembay: WDT SMC handler MACRO name update shruthi.sanil
2021-05-17 17:49 ` [PATCH v2 9/9] watchdog: keembay: Typo corrections and other blank operations shruthi.sanil
2021-05-24 6:06 ` Sanil, Shruthi [this message]
2021-05-24 10:36 ` [PATCH v2 0/9] Intel Keem Bay WDT bug fixes andriy.shevchenko
2021-05-24 13:42 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB312848D2D369C78BD2E969F0F1269@BYAPR11MB3128.namprd11.prod.outlook.com \
--to=shruthi.sanil@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=kris.pan@linux.intel.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mgross@linux.intel.com \
--cc=srikanth.thokala@intel.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).