From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7432C07E9C for ; Mon, 5 Jul 2021 16:22:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A09D6144E for ; Mon, 5 Jul 2021 16:22:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229693AbhGEQYj (ORCPT ); Mon, 5 Jul 2021 12:24:39 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:33051 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbhGEQYi (ORCPT ); Mon, 5 Jul 2021 12:24:38 -0400 Received: from mail-ed1-f72.google.com ([209.85.208.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1m0RM8-0004JB-3n for linux-watchdog@vger.kernel.org; Mon, 05 Jul 2021 16:22:00 +0000 Received: by mail-ed1-f72.google.com with SMTP id cn11-20020a0564020cabb0290396d773d4c7so4531693edb.18 for ; Mon, 05 Jul 2021 09:22:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sD/y1xlMgbYq3fBjsf0pX1g5M044zHykQS8WXVhlrdI=; b=Hh7G5PqlUDicjzPt6exQDuk0eM35RgnxwYvtvDkTrxueOWrmb8CctAN9pYP2vqJoJq CJel6HesYJJPUVoZfEtd9si1fzF7dT2DtBMWe8osRK2p1uwQFd0ZzMn92amjDsGEzopV ZhJ2VaLlsWLVSEcLAym9n7IutLP7zBSt7g6ZZ8/m5byf4eriMK3ADmLcf0HvBDtOZwaO +ut2zkxbdKaBXG604BhUf7vTYxi9ll63D3jjqalzbgFnKIqydxDIi4osJ0+oX7T6zutl 0b6YGUjgHHT4bRKSnjORilXKHjEc24nFFdt5UpGaXZ+OPH1tvkBeAyqc2Rm6T+DBvgOV XnnA== X-Gm-Message-State: AOAM532qYh1x10tEULZFxBNN63gdKVvQsFMexYHU/O3VAACePf+1Yryi rH9uFEeQROpjQWBQDQQLgR64PFjsqGYlzQBdXLtwdR0OlWmPlWaYjfkoqnljnInnRCG8jpmuAxq 1vTx2Y6eLcDoMnmRnIjXARI3Yk1t+NqK9TpIbUFlWpUDBxnYGIAlDD/nMWZWa X-Received: by 2002:a50:ed82:: with SMTP id h2mr17295921edr.165.1625502119904; Mon, 05 Jul 2021 09:21:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCJTJVm2cXmAPIEVtM0YZG4CWbGju7SyX7A+wp+GUMWL0lWArHCZ3pGx2eLKBQqDAJd5M6pJn5KLDGPSPGTWY= X-Received: by 2002:a50:ed82:: with SMTP id h2mr17295906edr.165.1625502119732; Mon, 05 Jul 2021 09:21:59 -0700 (PDT) MIME-Version: 1.0 References: <20210514131750.52867-1-krzysztof.kozlowski@canonical.com> <2b427eca-fd6c-d099-337f-39cfbd85cb46@roeck-us.net> <9d98ec40-757d-28c7-1669-a683b2cd3881@canonical.com> In-Reply-To: From: Krzysztof Kozlowski Date: Mon, 5 Jul 2021 18:21:48 +0200 Message-ID: Subject: Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module To: Guenter Roeck Cc: Wim Van Sebroeck , Thomas Bogendoerfer , Philipp Zabel , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, John Crispin , Lee Jones , kernel test robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Mon, 5 Jul 2021 at 18:08, Guenter Roeck wrote: > > On 7/5/21 8:15 AM, Krzysztof Kozlowski wrote: > > On 14/05/2021 16:04, Krzysztof Kozlowski wrote: > >> On 14/05/2021 09:48, Guenter Roeck wrote: > >>> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote: > >>>> When rt2880_wdt watchdog driver is built as a module, the > >>>> rt_sysc_membase needs to be exported (it is being used via inlined > >>>> rt_sysc_r32): > >>>> > >>>> ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined! > >>>> > >>>> Reported-by: kernel test robot > >>>> Signed-off-by: Krzysztof Kozlowski > >>> > >>> Acked-by: Guenter Roeck > >>> > >>> I don't see a recent change in the code. Has that problem been there > >>> all along ? > >> > >> I think the problem was there always but 0-day builder did not hit it > >> until recently: > >> https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/ > > > > Hi Guenter, > > > > It seems that patch was not applied. Anything to fix here? > > > I see commit fef532ea0cd8 ("MIPS: ralink: export rt_sysc_membase for > rt2880_wdt.c"). Does that not solve the problem ? Yes, that fixes it. It was sent later, though. :( Anyway, thanks! Best regards, Krzysztof