Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>,
	Kukjin Kim <kgene@kernel.org>,
	Vincent Sanders <vince@simtec.co.uk>,
	Simtec Linux Team <linux@simtec.co.uk>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>, Arnd Bergmann <arnd@arndb.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"moderated list:SAMSUNG SOC CLOCK DRIVERS" 
	<linux-samsung-soc@vger.kernel.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	patches@opensource.cirrus.com,
	"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
	linux-watchdog@vger.kernel.org,
	Sergio Prado <sergio.prado@e-labworks.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>,
	Cedric Roux <sed@free.fr>, Lihua Yao <ylhuajnu@outlook.com>
Subject: Re: [PATCH 3/7] ARM: s3c: Remove plat-samsung/.../samsung-time.h
Date: Wed, 29 Jul 2020 19:49:02 +0200
Message-ID: <CA+Ln22HWNSwVWARKL2NeUVx1y5yqHe0SGPZ1hcqBW88awySfPA@mail.gmail.com> (raw)
In-Reply-To: <20200729160942.28867-4-krzk@kernel.org>

2020年7月29日(水) 18:11 Krzysztof Kozlowski <krzk@kernel.org>:
>
> Remove the arch/arm/plat-samsung/include/plat/samsung-time.h header and
> move the contents to common.h headers in mach-s3c24xx and mach-s3c64xx.
> The definition of declared functions is already in common.c in mach
> directories, so it is logically to put declaration next to them.
>
> This is also one step further towards removal of plat-samsung directory
> and it fixes W=1 build warnings:
>
>     arch/arm/mach-s3c64xx/common.c:174:13: warning:
>         no previous prototype for 'samsung_set_timer_source' [-Wmissing-prototypes]
>       174 | void __init samsung_set_timer_source(unsigned int event, unsigned int source)
>
>     arch/arm/mach-s3c64xx/common.c:180:13: warning:
>         no previous prototype for 'samsung_timer_init' [-Wmissing-prototypes]
>       180 | void __init samsung_timer_init(void)
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm/mach-s3c24xx/common.h                | 12 +++++++++
>  arch/arm/mach-s3c24xx/mach-amlm5900.c         |  2 --
>  arch/arm/mach-s3c24xx/mach-anubis.c           |  1 -
>  arch/arm/mach-s3c24xx/mach-at2440evb.c        |  1 -
>  arch/arm/mach-s3c24xx/mach-bast.c             |  1 -
>  arch/arm/mach-s3c24xx/mach-gta02.c            |  1 -
>  arch/arm/mach-s3c24xx/mach-h1940.c            |  1 -
>  arch/arm/mach-s3c24xx/mach-jive.c             |  1 -
>  arch/arm/mach-s3c24xx/mach-mini2440.c         |  1 -
>  arch/arm/mach-s3c24xx/mach-n30.c              |  1 -
>  arch/arm/mach-s3c24xx/mach-nexcoder.c         |  1 -
>  arch/arm/mach-s3c24xx/mach-osiris.c           |  1 -
>  arch/arm/mach-s3c24xx/mach-otom.c             |  1 -
>  arch/arm/mach-s3c24xx/mach-qt2410.c           |  1 -
>  arch/arm/mach-s3c24xx/mach-rx1950.c           |  1 -
>  arch/arm/mach-s3c24xx/mach-rx3715.c           |  1 -
>  arch/arm/mach-s3c24xx/mach-smdk2410.c         |  1 -
>  arch/arm/mach-s3c24xx/mach-smdk2413.c         |  1 -
>  arch/arm/mach-s3c24xx/mach-smdk2416.c         |  1 -
>  arch/arm/mach-s3c24xx/mach-smdk2440.c         |  1 -
>  arch/arm/mach-s3c24xx/mach-smdk2443.c         |  1 -
>  arch/arm/mach-s3c24xx/mach-tct_hammer.c       |  1 -
>  arch/arm/mach-s3c24xx/mach-vr1000.c           |  1 -
>  arch/arm/mach-s3c24xx/mach-vstms.c            |  1 -
>  arch/arm/mach-s3c64xx/common.h                | 13 ++++++++++
>  arch/arm/mach-s3c64xx/mach-anw6410.c          |  1 -
>  arch/arm/mach-s3c64xx/mach-crag6410.c         |  1 -
>  arch/arm/mach-s3c64xx/mach-hmt.c              |  1 -
>  arch/arm/mach-s3c64xx/mach-mini6410.c         |  1 -
>  arch/arm/mach-s3c64xx/mach-ncp.c              |  1 -
>  arch/arm/mach-s3c64xx/mach-real6410.c         |  1 -
>  arch/arm/mach-s3c64xx/mach-smartq.c           |  1 -
>  arch/arm/mach-s3c64xx/mach-smartq5.c          |  1 -
>  arch/arm/mach-s3c64xx/mach-smartq7.c          |  1 -
>  arch/arm/mach-s3c64xx/mach-smdk6400.c         |  1 -
>  arch/arm/mach-s3c64xx/mach-smdk6410.c         |  1 -
>  .../plat-samsung/include/plat/samsung-time.h  | 26 -------------------
>  37 files changed, 25 insertions(+), 61 deletions(-)
>  delete mode 100644 arch/arm/plat-samsung/include/plat/samsung-time.h
>

For the s3c64xx bits:

Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>

I suppose the next step would be renaming those functions to s3c24xx_*
and s3c64xx_* to avoid naming collisions?

Best regards,
Tomasz

  reply index

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 16:09 [PATCH 0/7] ARM: samsung: Cleanup of various S3C bits Krzysztof Kozlowski
2020-07-29 16:09 ` [PATCH 1/7] clk: samsung: s3c64xx: Declare s3c64xx_clk_init() in shared header Krzysztof Kozlowski
2020-07-29 17:39   ` Tomasz Figa
2020-07-29 19:42   ` Stephen Boyd
2020-07-29 20:16     ` Krzysztof Kozlowski
2020-07-29 16:09 ` [PATCH 2/7] ARM: s3c64xx: Include header to fix -Wmissing-prototypes Krzysztof Kozlowski
2020-07-29 17:46   ` Tomasz Figa
2020-07-29 16:09 ` [PATCH 3/7] ARM: s3c: Remove plat-samsung/.../samsung-time.h Krzysztof Kozlowski
2020-07-29 17:49   ` Tomasz Figa [this message]
2020-07-29 19:02     ` Krzysztof Kozlowski
2020-07-29 16:09 ` [PATCH 4/7] ARM: samsung: Fix language typo Krzysztof Kozlowski
2020-07-29 16:09 ` [PATCH 5/7] ARM: samsung: Kill useless HAVE_S3C2410_WATCHDOG Krzysztof Kozlowski
2020-07-29 17:02   ` Guenter Roeck
2020-07-29 17:36     ` Tomasz Figa
2020-07-29 19:08       ` Krzysztof Kozlowski
2020-07-29 16:09 ` [PATCH 6/7] ARM: s3c64xx: Switch to generic watchdog driver reset Krzysztof Kozlowski
2020-07-29 17:33   ` Tomasz Figa
2020-07-29 19:15     ` Krzysztof Kozlowski
2020-07-29 19:25       ` Krzysztof Kozlowski
2020-07-30 11:34       ` Tomasz Figa
2020-07-30 11:45         ` Krzysztof Kozlowski
2020-07-29 16:09 ` [PATCH 7/7] ARM: s3c24xx: Fix missing system reset Krzysztof Kozlowski
2020-07-29 20:01 ` [PATCH 0/7] ARM: samsung: Cleanup of various S3C bits Arnd Bergmann
2020-07-29 20:15   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+Ln22HWNSwVWARKL2NeUVx1y5yqHe0SGPZ1hcqBW88awySfPA@mail.gmail.com \
    --to=tomasz.figa@gmail.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=cw00.choi@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linux@roeck-us.net \
    --cc=linux@simtec.co.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@baylibre.com \
    --cc=patches@opensource.cirrus.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=sed@free.fr \
    --cc=sergio.prado@e-labworks.com \
    --cc=snawrocki@kernel.org \
    --cc=vince@simtec.co.uk \
    --cc=will@kernel.org \
    --cc=wim@linux-watchdog.org \
    --cc=ylhuajnu@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git