From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E5CDC48BE5 for ; Mon, 21 Jun 2021 06:11:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6CE561040 for ; Mon, 21 Jun 2021 06:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbhFUGNy (ORCPT ); Mon, 21 Jun 2021 02:13:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbhFUGNx (ORCPT ); Mon, 21 Jun 2021 02:13:53 -0400 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CB06C061756 for ; Sun, 20 Jun 2021 23:11:35 -0700 (PDT) Received: by mail-il1-x12b.google.com with SMTP id b5so2265495ilc.12 for ; Sun, 20 Jun 2021 23:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UrVnWD4uqk477BZlRoS6bPA0gBVrgjlmN2CjO1g4ZrY=; b=b7jNAfXK+9+FAA00prZSOHK32v7G04pvd7XGXWaJDoQhAgeyFKeHtahoZQXX8mRdKD w2BtpOuAerm7s4/3jQS5LmioFE0lk9cmsNBWko9c4CIQj3xlFNaWaXL6qtdPNL3RTEiQ HMrTXeM5ULR2LfmbFT5EFF1U/l6oFfhYtJbWVL2VA6FNHdlepozCGYkuT2kI6I4ZZrLv z1wFIIR+feiCuHNLR9McO8u0fhUb7p79WQjUrAKmqOm5G15paYZODcS/63w8bvBVX3nC Xvk5XQbfM/zd9+F7YJZrGCw/mQ2HnyvjUXdSOA0RMBS1pldze0IjLhKiqg0khW199GnH AZvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UrVnWD4uqk477BZlRoS6bPA0gBVrgjlmN2CjO1g4ZrY=; b=bSiDRV3C6vb4Rn9AaN1XBZ8Hfv1OlkL6FQT7w2CuItcv9F0tUb4KiHGH0NEUWs0KA+ MaCJZFJOQE1kTaBZ4X3sar7+ZsPWBDHLCWmC9LmkUHuWEik/HIFCkCVjCZyZTAQDIxsR gb7wuuC+pusNVcQjJAKOUoYrQgN4Yh/BsVRUT8Wzkk+M/2nWUl7TUbigH2tLGBgHzw7r DP8QOIEwnqSW8arma1iezou9qcnFoz3sPs9UGdljy233Fz2B76LYpJwkEVlCByc1DtT1 kONF0V5Nhy7uVvwFB/6lz3FzV2LFkjO4r7iZ5sDuL44JMrj/g1aKUIv1rcIzoP83yoRm d5ag== X-Gm-Message-State: AOAM533uBfpJpWxvNTrHahEMb2396xu2JbKZnUF8BEE323WgK8jHOgJN uvpe1KIgyrsgaSWKKkbzQY+q4NSxj2MqZfLrXcr8WQ== X-Google-Smtp-Source: ABdhPJyH1zVl7wIiAFgQ8e1e8lUbGMzodYIhXDk676HPCNCBJlym94W/qbDfS3mva7wU9ICE+EAx0H0frj0pQnM7DGY= X-Received: by 2002:a05:6e02:1be1:: with SMTP id y1mr17552207ilv.204.1624255894489; Sun, 20 Jun 2021 23:11:34 -0700 (PDT) MIME-Version: 1.0 References: <20210620134954.15233-1-Christine.Zhu@mediatek.com> <20210620134954.15233-4-Christine.Zhu@mediatek.com> In-Reply-To: <20210620134954.15233-4-Christine.Zhu@mediatek.com> From: Tzung-Bi Shih Date: Mon, 21 Jun 2021 14:11:23 +0800 Message-ID: Subject: Re: [v1,3/3] watchdog: mt8195: add wdt support To: Christine Zhu Cc: linux@roeck-us.net, robh+dt@kernel.org, wim@linux-watchdog.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, seiya.wang@mediatek.com, linux-watchdog@vger.kernel.org, rex-bc.chen@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com, srv_heupstream@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Sun, Jun 20, 2021 at 9:50 PM Christine Zhu wrote: > add support for watchdog device found in MT8195 SoC Please write complete sentences. For example, "Supports MT8195 watchdog device." > Change-Id: Ib2434cf2d47a2e14916056f08a4fc630569624ed Remove the unneeded tag. > +static const struct mtk_wdt_data mt8195_data = { > + .toprgu_sw_rst_num = MT8195_TOPRGU_SW_RST_NUM, > +}; Expect to see the of_device_id (i.e. mtk_wdt_dt_ids) has the newly introduced compatible string and use the mt8195_data but failed to find it.