From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF6DC433E1 for ; Mon, 18 May 2020 13:23:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AB8D2065F for ; Mon, 18 May 2020 13:23:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cfcy4DgN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727885AbgERNXn (ORCPT ); Mon, 18 May 2020 09:23:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727003AbgERNXm (ORCPT ); Mon, 18 May 2020 09:23:42 -0400 Received: from mail-oo1-xc41.google.com (mail-oo1-xc41.google.com [IPv6:2607:f8b0:4864:20::c41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94E42C061A0C; Mon, 18 May 2020 06:23:42 -0700 (PDT) Received: by mail-oo1-xc41.google.com with SMTP id z6so2022339ooz.3; Mon, 18 May 2020 06:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DBlvsBNo07SGqI/EUYBm242mZ59YuGTGeckJLd8jOpQ=; b=cfcy4DgNDBCTvF7mVRHlNGMhkmacmQXoOEN7xHQW5RByJmQEOZPVAPyo9YID2+ksAi /afPVXSML+4G3Bw1Av627prEUHM1DSfL+K+x7/YDrloQUeRdA0RHZ/Ci8IiVSn06JvxM ERD+F7OU2G0aYA1jm533gAqjJDTSnLWqrFY36parhqgXEhiSPdgqNwQO5fR9KwIhBQHQ YOpKIOz6q+0B0PXG8v4Biq/vO8dKWXEzyeRa0Y9yjaxmh3OejiceK8lNmw23eVKaKsvC ADaynfCq4eIlVTdkVXFTZbxc33D8fvQN23K/LX+Sx2IBxLRkGYZGb+euiCHZkVjhZq4k d+hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DBlvsBNo07SGqI/EUYBm242mZ59YuGTGeckJLd8jOpQ=; b=C5iMQe4UU3Tl0hFeiOWzE/StQvqw3Kmh7p8HM5Kkzy1UvxF5PqWz/k7wu4t0rTyzPY CMxoOIf04UWyi68XYs7384GaZ0SDhpamcvEm3DUSeXvXTCSvz8TNuG2WP56smSCovt56 LlqUTnVaR1pzC7u533b9RMNGOtMFC53EdchJ8tTGz+X8Pbu2B63z/wB6Cv4WQz4N0awh e3C0lzPdxyXf/MMSZrKtX8mlhLhCgq9UHG3OOHLqnr/cF6btir2AVvf5Fy+kZ9vA3HDe aSP9SRgTWbM0lo0Ff2J+4Hg9k2V29nC2ixYhyQC8MEPefYc472Q2J30Pjz+zm9EdrFRJ ynmw== X-Gm-Message-State: AOAM5314CWzbmL/eFVDRRvDaCOQ05xk0e3fqsi6ObjmhfTL0TIsidPmZ 51DtjthyxZJynOHhm/5qJ02cGYP78rQsUvYhoDE= X-Google-Smtp-Source: ABdhPJxVcUiw42ooaQWea/4dYUB4KCyh0tbeqfXUZvqVqSB4YyCTuhyTbJeCJawG71KxJDG6Rdbo2qnrc9R3IY+DJW4= X-Received: by 2002:a4a:b346:: with SMTP id n6mr12858795ooo.18.1589808222002; Mon, 18 May 2020 06:23:42 -0700 (PDT) MIME-Version: 1.0 References: <1589555337-5498-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1589555337-5498-18-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <9ab946d2-1076-ed92-0a48-9a95d798d291@cogentembedded.com> In-Reply-To: <9ab946d2-1076-ed92-0a48-9a95d798d291@cogentembedded.com> From: "Lad, Prabhakar" Date: Mon, 18 May 2020 14:23:15 +0100 Message-ID: Subject: Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node To: Sergei Shtylyov Cc: Geert Uytterhoeven , Lad Prabhakar , Jens Axboe , Rob Herring , Wolfram Sang , Ulf Hansson , "David S. Miller" , Wim Van Sebroeck , Guenter Roeck , linux-ide@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux I2C , Linux MMC List , netdev , Linux-Renesas , Linux Watchdog Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Hi Sergei, On Mon, May 18, 2020 at 2:17 PM Sergei Shtylyov wrote: > > Hello! > > On 18.05.2020 15:27, Lad, Prabhakar wrote: > > >>> Add a device node for the Watchdog Timer (RWDT) controller on the Renesas > >>> RZ/G1H (r8a7742) SoC. > >>> > >>> Signed-off-by: Lad Prabhakar > >>> Reviewed-by: Marian-Cristian Rotariu > >> > >> Thanks for your patch! > >> > >>> --- a/arch/arm/boot/dts/r8a7742.dtsi > >>> +++ b/arch/arm/boot/dts/r8a7742.dtsi > >>> @@ -201,6 +201,16 @@ > >>> #size-cells = <2>; > >>> ranges; > >>> > >>> + rwdt: watchdog@e6020000 { > >>> + compatible = "renesas,r8a7742-wdt", > >>> + "renesas,rcar-gen2-wdt"; > >>> + reg = <0 0xe6020000 0 0x0c>; > >>> + clocks = <&cpg CPG_MOD 402>; > >>> + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>; > >>> + resets = <&cpg 402>; > >>> + status = "disabled"; > >> > >> Missing "interrupts" property. > >> > > "interrupts" property isn't used by rwdt driver and can be dropped > > from bindings file. > > DT describes the hardware, not its driver's abilities. > Agreed will add, I had followed it on similar lines of r8a7743/44. Cheers, --Prabhakar