From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38EE4C433EF for ; Fri, 17 Sep 2021 22:28:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1164261100 for ; Fri, 17 Sep 2021 22:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344693AbhIQW3r (ORCPT ); Fri, 17 Sep 2021 18:29:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235667AbhIQW3r (ORCPT ); Fri, 17 Sep 2021 18:29:47 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75CDDC061757 for ; Fri, 17 Sep 2021 15:28:24 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id z24so12492862lfu.13 for ; Fri, 17 Sep 2021 15:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ATG5NnjBZl5uROxRiGQuGsgW+WoiTqVTfaTtEyWboD4=; b=GIxqeNwHyHeXl9iWMRj3tvHiLtIR8wE8ZDUo49LZQyHArLZ5Y8u5tw9G02aO7GfZSr d4RiONMGCMitnH03p/SPXvtPRfw93zOOagGcWOIiNwhcTOuc5p7DL00jY22JfoDQ/0iu 7bkKj1eIsUgbIpiOSHKqnGnXToC3qmkdxpp6z6KKBsGatuAnXsacWt/IVR3vy0zGi0DH Adsc+WdzyRa3R00hPVKRIsrckqyqlxosWyPOFI8ihA2HgIJLhTzmGuvHqQcNUDJnBlRQ F0DUlyuusMf+8Dgjl0h2SWMmpRdhBi487vWd3auyOndzagE9ZllRxv25dHsKZ5cHyCZJ PCnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ATG5NnjBZl5uROxRiGQuGsgW+WoiTqVTfaTtEyWboD4=; b=dFbt93Spl7u9WhCELi4PPnlFeSSnese6lvHIVpHoIjZb/1jdMHwRCg457Yq5afYKLq xYWwOcEPBWApMxWyAftn+FaDiFS/oUoH0kQ5Rn0zLZxZvd8qqHmPYbvO7lYjLzaQMbx4 Xx7q6gCYpWdy3JCI2fsWba3oC81HBuOf3WrMNw2Hg5Uy9DgP+H7WHimYIC6dj8+8PkhR tjKHOJfbFjoBJwYYiX4IE0pZTuLcuLc4l3EzYtG86eXWk3PuMBNoGHLGd2v4h0WWr0wo 9pwaLmvRMKocXHUhyYkVbCqu8KoAyXFqBmERVrKFbWbM9zQAG84ou9ZCJfJKHY/1WIWG Tv1A== X-Gm-Message-State: AOAM533+14yznSWACRqalHc9Hq5apz5hRiW2LaJnaOxR6n7BpFh06X8Z SYXWivMveHHM2nLYo6oncUOchkxfeSnC6yMmTOoGClZCHeU= X-Google-Smtp-Source: ABdhPJyJzS6Eh5ph0KTz0AHFM3V7mMDZRHus4peWL04EIpE/0/VyQ76dzmHnSnuRLtGQVLTH7syzF4tuj9ZRm7UveqU= X-Received: by 2002:a05:6512:12c4:: with SMTP id p4mr10112672lfg.72.1631917702757; Fri, 17 Sep 2021 15:28:22 -0700 (PDT) MIME-Version: 1.0 References: <20210911042925.556889-1-linux@roeck-us.net> In-Reply-To: <20210911042925.556889-1-linux@roeck-us.net> From: Linus Walleij Date: Sat, 18 Sep 2021 00:28:11 +0200 Message-ID: Subject: Re: [PATCH] watchdog: ixp4xx_wdt: Fix address space warning To: Guenter Roeck Cc: Wim Van Sebroeck , LINUXWATCHDOG , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Sat, Sep 11, 2021 at 6:29 AM Guenter Roeck wrote: > sparse reports the following address space warning. > > drivers/watchdog/ixp4xx_wdt.c:122:20: sparse: > incorrect type in assignment (different address spaces) > drivers/watchdog/ixp4xx_wdt.c:122:20: sparse: > expected void [noderef] __iomem *base > drivers/watchdog/ixp4xx_wdt.c:122:20: sparse: > got void *platform_data > > Add a typecast to solve the problem. > > Fixes: 21a0a29d16c6 ("watchdog: ixp4xx: Rewrite driver to use core") > Cc: Linus Walleij > Signed-off-by: Guenter Roeck Thanks for fixing this! Reviewed-by: Linus Walleij Yours, Linus Walleij