From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D975C4151A for ; Mon, 4 Feb 2019 11:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F67620815 for ; Mon, 4 Feb 2019 11:25:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="OyoJQUVl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbfBDLZ4 (ORCPT ); Mon, 4 Feb 2019 06:25:56 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:46978 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728299AbfBDLZ4 (ORCPT ); Mon, 4 Feb 2019 06:25:56 -0500 Received: by mail-lj1-f194.google.com with SMTP id v15-v6so11166881ljh.13 for ; Mon, 04 Feb 2019 03:25:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wRYfuP7oYobYTBvy6aIr+v9XulGm0xPZTNCq3iUqj+k=; b=OyoJQUVlHhFQSKp34oawUzjkkJD20j0DGfRc8AUsiwOh6L47Iq47rbho1DAC6JojOK 8mdMAyYBzAuUpKy5aCmpgsA/pGdfSIm2Bwhu8w0vxuDCrVE8Y6nyXLMFaGqgCVZLxapX z3iL1LeErLJ6w5QXPD21yv8wYjA1U8A4zy8Y4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wRYfuP7oYobYTBvy6aIr+v9XulGm0xPZTNCq3iUqj+k=; b=EexvXgE+B2ugLThIo6gdvQHUAi2sTh4Q7lVKbzbl7FKl4UoVNd1taRok8GAr/cDV1t NlJS8uG8qhP0K+eLrQRBAR96O/he+ND+uh5+bxHPq7M1C8NErc+OIqP0YQgViTO+FjK9 FUd9Kr1sgmAfcMz7DQDMNvzZ3cE+oDvQdMzubTfWvZsFFWAtofFo9c/tCBMTnHynHM4h 5OgY6KSdHrMvE6UZmZQX2Po7WksXDkHnz4zJKWdIsOLY/ZoMCkmcBOyWKpKVKhAgcBR2 lnSMDm9tFrLUO//unkEVeBpljSawoTmn0TN9/KXmpe+wqb5MCzMtG5ZHpP4ZUxNVKOXv roxA== X-Gm-Message-State: AJcUukcZYpNVzaegAkBwgcOTCQAHPghlEqf14ho7MkXinmOOGORff8oC XaZTF2wGWh2PakTmuUXyvEfXqMy+uDwXpzqIuRGx6g== X-Google-Smtp-Source: ALg8bN7nx6sXITFyoPuFfw23CVvKBGmyEoL5ZFGpk6r4uHCrK3mNJtdnoravyOf/yoASu8/EqQzyBvCsgA2Xe1ImuZE= X-Received: by 2002:a2e:9356:: with SMTP id m22-v6mr39242047ljh.135.1549279554049; Mon, 04 Feb 2019 03:25:54 -0800 (PST) MIME-Version: 1.0 References: <127bd8d6765e35272ad174c59838d1374813c910.1548935790.git.matti.vaittinen@fi.rohmeurope.com> In-Reply-To: <127bd8d6765e35272ad174c59838d1374813c910.1548935790.git.matti.vaittinen@fi.rohmeurope.com> From: Linus Walleij Date: Mon, 4 Feb 2019 12:25:41 +0100 Message-ID: Subject: Re: [RFC PATCH v4 06/10] devicetree: bindings: Document first ROHM BD70528 bindings To: Matti Vaittinen Cc: Matti Vaittinen , heikki.haikola@fi.rohmeurope.com, mikko.mutanen@fi.rohmeurope.com, Lee Jones , Rob Herring , Mark Rutland , Mark Brown , Greg KH , "Rafael J. Wysocki" , Michael Turquette , Stephen Boyd , Bartosz Golaszewski , Sebastian Reichel , Liam Girdwood , Alessandro Zummo , Alexandre Belloni , Wim Van Sebroeck , Guenter Roeck , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , linux-clk , "open list:GPIO SUBSYSTEM" , Linux PM list , linux-rtc@vger.kernel.org, LINUXWATCHDOG Content-Type: text/plain; charset="UTF-8" Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Thu, Jan 31, 2019 at 1:04 PM Matti Vaittinen wrote: > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED > drivers) and 4 GPIO pins which can be configured for I/O or > as interrupt sources withe configurable trigger levels. > > Signed-off-by: Matti Vaittinen (...) > +Required properties: > + - compatible : Should be "rohm,bd70528" > + - reg : I2C slave address. > + - interrupts : The interrupt line the device is connected to. > + - interrupt-controller : To indicate bd70528 acts as an interrupt controller. > + - #interrupt-cells : Should be 2. usage is compliant to the 2 cells > + variant of ../interrupt-controller/interrupts.txt > + - gpio-controller : To indicate bd70528 acts as a gpio controller. > + - #gpio-cells : Should be 2. The first cell is the pin number and > + the second cell is used to specify flags. See > + ../gpio/gpio.txt for more information. > + - #clock-cells : Should be 0. > + - regulators: : List of child nodes that specify the regulators. > + Please see ../regulator/rohm,bd70528-regulator.txt So if I understand correctly, the clocks and GPIO does not spawn any child nodes but are attached directly to the MFD node. This works! Acked-by: Linus Walleij Yours, Linus Walleij