From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF49C433DF for ; Wed, 8 Jul 2020 07:40:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB4AA20656 for ; Wed, 8 Jul 2020 07:40:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kf6x43ay" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbgGHHkD (ORCPT ); Wed, 8 Jul 2020 03:40:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726325AbgGHHj6 (ORCPT ); Wed, 8 Jul 2020 03:39:58 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 773A7C08E81E for ; Wed, 8 Jul 2020 00:39:57 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id q4so17276716lji.2 for ; Wed, 08 Jul 2020 00:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+HxgH6sad3gU6leW7SDh/gf8Hzfs0/fhZcOEjnvGhWs=; b=kf6x43aymox0RXHGLm8aA9SdFQARFjcUUTid1nkeg9ibekZJqFjhwH23OVWjfAOjVS PIyKh85DWMiQQ7vV4MPU9N/PHWMBXsW8ALCT0jUDOBYiRrEm93dNmyBY2QKLC8e59uXU rF/LbFEzhwf7Hh9D0M9LGkfmU1uXbWrbwnSzZ8YxxZR5BL7KxyZLYny+CUf+LF90Q6OB gITnA0TUKecjikeYVz6qOheu9mHlpVGZsqJgXhFyS2gl3mAaueYbWpptMe/oEQAYYllA zsUp2xKjkGd9Lw4e7zUScEK+4AP896Zl4fGx27sAKWpJkoT11s4X/JaSJFPzE8k8XuwU CRkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+HxgH6sad3gU6leW7SDh/gf8Hzfs0/fhZcOEjnvGhWs=; b=e4ry8oQ22pqk7owuBQTds2k4AbzPRLaOMQM1V+zoUFcaH5D3rvrLMuAR27RkubB7a2 +89zVrOHTI/Oz73yZWe67AHLtmzyZ3f7uMvntv06CsIFfsJQQWPg1tV67sqntkd8OGHJ tG22gJ/6jZKaHAjZxSIOQfBYoGDUozsoekAURE+qNLWUZmkUGUnR6CZT5+cY955+nQnN l3PgOr+pKZCy/tNfbJrhA/ziHs1W4/YmhY/QLVMwGMrvRux4dtcquyLpjT+6Pk1uVYH9 xo1F6BudwM6PFE0ZnB8sdPFZEfSq0SRl1MTX/MDAEOUa9YlIntJ/GRZg0l3ofmOw2sBM E8QA== X-Gm-Message-State: AOAM531xRp5pO92kZ0da/ZfUvOHk+rpv3uh2RvbQgQZXxj6jDswnIW/0 5NuM92nbIS0zbRZre5Qw6OZx1pCMVTfgajmSFh9N7A== X-Google-Smtp-Source: ABdhPJxTYp6lBnboAKIMoKnmPkXV27lA7iN1d1K5nRqP4hkVKmZacGWC0DDRGgpoKAE/wWfaRt/VjtFi95icB142swA= X-Received: by 2002:a2e:9c3:: with SMTP id 186mr33775780ljj.293.1594193995825; Wed, 08 Jul 2020 00:39:55 -0700 (PDT) MIME-Version: 1.0 References: <20200706175353.16404-1-michael@walle.cc> <20200706175353.16404-14-michael@walle.cc> In-Reply-To: <20200706175353.16404-14-michael@walle.cc> From: Linus Walleij Date: Wed, 8 Jul 2020 09:39:45 +0200 Message-ID: Subject: Re: [PATCH v5 13/13] arm64: dts: freescale: sl28: enable fan support To: Michael Walle Cc: "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, LINUXWATCHDOG , Linux ARM , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Hi Michael, just a drive-by-comment: On Mon, Jul 6, 2020 at 7:57 PM Michael Walle wrote: > Add a pwm-fan mapped to the PWM channel 0 which is connected to the > fan connector of the carrier. > > Signed-off-by: Michael Walle If you have a cooling device like this, do you also have a temperature sensor? In that case it makes sense to add a thermal zone and a policy, such as I did for a device in 6e97f0aaca4ca778905dd1dc667cbf379f4cae15 Yours, Linus Walleij