From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 742F9C04AAC for ; Mon, 20 May 2019 14:57:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5318020856 for ; Mon, 20 May 2019 14:57:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731245AbfETO5W convert rfc822-to-8bit (ORCPT ); Mon, 20 May 2019 10:57:22 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:46424 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730351AbfETO5V (ORCPT ); Mon, 20 May 2019 10:57:21 -0400 Received: by mail-ed1-f66.google.com with SMTP id f37so24258152edb.13; Mon, 20 May 2019 07:57:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+tTKrGaZbZAWn5dajRxbdafRjHqzlUJiRVVSR6xwRss=; b=dAP55o4sap/ep1EL2VRkswg8vqjB94gaDu6x4YlfB0lVTEq28FYy5+7U7Il8+nttW3 KjnDwDZPzU+MNZAZ0bvkL7buMlZCcsT/F0uTytmwjm+GB6spN5869OeZI7UyaTO9wJZH SsL+yotjsb15EIenBv6upKRapq7G9o07APH2ebO4wf4coK15jmdJ00hcVns7TX2f1hSF sGndOPiRluN2E8lDLrkB0JgeXKs8LCS1jTZX+rTORzgrCqvIbwH16R8p9gWcNoBgD6jQ ScKOSghsdo+LdOjJBOaY1PstAXD0lypl4KSiNM36lgya3waVTzabAt4EOdyvsEzlK+hv ozoQ== X-Gm-Message-State: APjAAAVvlEiaOW40EyDIYdOE48j4xyXGnZh1VkWLkFnxc5gbqXGDrBDc NdvimJp3ZGCnXT+6KqZ0CYE172/g5WQ= X-Google-Smtp-Source: APXvYqwYUltTtgEaV/LPP1or7X7oyVvUT72UbUlSiW5yHKeCauyoECqqWOVIjNg8uYwe3UGiQR55cw== X-Received: by 2002:a50:9056:: with SMTP id z22mr76319431edz.72.1558364239098; Mon, 20 May 2019 07:57:19 -0700 (PDT) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com. [209.85.128.44]) by smtp.gmail.com with ESMTPSA id hb11sm3161651ejb.43.2019.05.20.07.57.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 07:57:17 -0700 (PDT) Received: by mail-wm1-f44.google.com with SMTP id 198so13641380wme.3; Mon, 20 May 2019 07:57:16 -0700 (PDT) X-Received: by 2002:a1c:80c3:: with SMTP id b186mr12164236wmd.43.1558364236763; Mon, 20 May 2019 07:57:16 -0700 (PDT) MIME-Version: 1.0 References: <20190518152355.11134-1-peron.clem@gmail.com> <20190518152355.11134-3-peron.clem@gmail.com> <20190520073652.itk452vrpnicta5v@flea> <20190520144404.zprbuqt3d7uuxgr2@flea> In-Reply-To: <20190520144404.zprbuqt3d7uuxgr2@flea> From: Chen-Yu Tsai Date: Mon, 20 May 2019 22:57:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node To: Maxime Ripard Cc: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , linux-watchdog@vger.kernel.org, devicetree , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Mon, May 20, 2019 at 10:44 PM Maxime Ripard wrote: > > On Mon, May 20, 2019 at 10:21:40AM +0200, Clément Péron wrote: > > Hi, > > > > On Mon, 20 May 2019 at 09:36, Maxime Ripard wrote: > > > > > > On Sat, May 18, 2019 at 05:23:53PM +0200, Clément Péron wrote: > > > > Allwinner H6 has a watchog node which seems broken > > > > on some boards. > > > > > > > > Test has been performed on several boards. > > > > > > > > Chen-Yu Tsai boards: > > > > Pine H64 - H6448BA 7782 => OK > > > > OrangePi Lite 2 - H8068BA 61C2 => KO > > > > > > > > Martin Ayotte boards: > > > > Pine H64 - H8069BA 6892 => OK > > > > OrangePi 3 - HA047BA 69W2 => KO > > > > OrangePi One Plus - H7310BA 6842 => KO > > > > OrangePi Lite2 - H6448BA 6662 => KO > > > > > > > > Clément Péron board: > > > > Beelink GS1 - H7309BA 6842 => KO > > > > > > > > As it seems not fixable for now, declare the node > > > > but leave it disable with a comment. > > > > > > > > Signed-off-by: Clément Péron > > > > > > If it doesn't work most boards, then why do we need to merge that > > > patch in the first place? > > > > My personnal opinion, is that having the IP declared and disabled with > > a comment saying "it's broken on some boards" in the device-tree is > > better than not having at all. > > > > This will explicit say "the IP exist but don't use it!". > > Maybe some people with a functionnal board would like to explicitly > > use it on their dts. > > Yeah, that makes sense. Chen-Yu, any opinion on the matter? Works for me.