From: Andy Shevchenko <email@example.com> To: Jan Kiszka <firstname.lastname@example.org> Cc: "Guenter Roeck" <email@example.com>, "Wim Van Sebroeck" <firstname.lastname@example.org>, email@example.com, "Linux Kernel Mailing List" <firstname.lastname@example.org>, "Paolo Bonzini" <email@example.com>, "Christian Storm" <firstname.lastname@example.org>, "Mantas Mikulėnas" <email@example.com> Subject: Re: [PATCH] watchdog: iTCO_wdt: Fix detection of SMI-off case Date: Mon, 26 Jul 2021 17:51:51 +0300 [thread overview] Message-ID: <CAHp75VdqS5QUwq=25RGKOiPRfcNzNxG9kNMtP-2-=z4EAnUi8w@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, Jul 26, 2021 at 5:05 PM Jan Kiszka <email@example.com> wrote: > > On 26.07.21 15:59, Guenter Roeck wrote: > > On 7/26/21 6:40 AM, Andy Shevchenko wrote: > >> On Mon, Jul 26, 2021 at 3:04 PM Jan Kiszka <firstname.lastname@example.org> > >> wrote: > >>> > >>> On 26.07.21 14:01, Andy Shevchenko wrote: > >>>> On Mon, Jul 26, 2021 at 2:46 PM Jan Kiszka <email@example.com> > >>>> wrote: > >>>>> > >>>>> From: Jan Kiszka <firstname.lastname@example.org> > >>>>> > >>>>> Obviously, the test needs to run against the register content, not its > >>>>> address. > >>>>> > >>>>> Fixes: cb011044e34c ("watchdog: iTCO_wdt: Account for rebooting on > >>>>> second timeout") > >>>>> Reported-by: Mantas Mikulėnas <email@example.com> > >>>> > >>>>> Signed-off-by: Jan Kiszka <firstname.lastname@example.org> > >>>> > >>>> Missed SoB of the submitter (hint: configure your Git to make sure > >>>> that submitter and author are the same in terms of name-email). > >>> > >>> The signed off is there. Not sure what you are referring to. > >> > >> Nope. It's not. The sign of that is the From: line in the body of the > >> email. It happens when the submitter != author. And SoB of the former > >> one is absent. But what is strange is that reading them here I haven't > >> found the difference. Maybe one is in UTF-8 while the other is not and > >> a unicode character degraded to Latin-1 or so? > >> > > > > I have no idea why there is an additional From:, but both From: > > tags in the e-mail source are exact matches, and both match the > > name and e-mail address in Signed-off-by:. I agree with Jan, > > the SoB is there. > > There is one unknown in this equation, and that is the anti-email system > operated by a our IT and some company in Redmond. Hmm... The From: in the body is the result of the `git format-patch` I believe. So, two (or more?) possibilities here: 1) your configuration enforces it to always put From: (something new to me); 2) the submitter and author are not the same (see also: https://github.com/git/git/commit/a90804752f6ab2b911882d47fafb6c2b78f447c3); 3) ...anything else...? > But I haven't received > any complaints that my outgoing emails are negatively affected by it > (incoming are, but that's a different story...). If you received > something mangled, Andy, please share the source of that email. I'm > happy to escalate internally - and externally. I believe I see it in the same way as lore, i.e. https://email@example.com/raw > For the potential case they were mangled or in case I'm submitting via a > real email provider, my scripts always add a "From:" to the body of my > patches. Outgoing, that From matched my Signed-off. -- With Best Regards, Andy Shevchenko
next prev parent reply other threads:[~2021-07-26 14:52 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-26 11:46 Jan Kiszka 2021-07-26 12:01 ` Andy Shevchenko 2021-07-26 12:04 ` Jan Kiszka 2021-07-26 13:40 ` Andy Shevchenko 2021-07-26 13:59 ` Guenter Roeck 2021-07-26 14:05 ` Jan Kiszka 2021-07-26 14:51 ` Andy Shevchenko [this message] 2021-07-26 17:10 ` Jan Kiszka 2021-07-26 21:45 ` Andy Shevchenko 2021-07-26 12:03 ` Paolo Bonzini 2021-07-26 12:05 ` Jan Kiszka 2021-07-26 13:51 ` Guenter Roeck 2021-07-26 13:44 ` Guenter Roeck 2021-07-26 16:59 ` Mantas Mikulėnas 2021-08-20 13:45 ` Jan Kiszka 2021-08-30 19:47 ` Jan Kiszka 2021-08-30 20:00 ` Guenter Roeck 2021-09-07 20:14 ` Wim Van Sebroeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHp75VdqS5QUwq=25RGKOiPRfcNzNxG9kNMtP-2-=z4EAnUi8w@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] watchdog: iTCO_wdt: Fix detection of SMI-off case' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).