From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99490C2BB56 for ; Sat, 29 Aug 2020 06:24:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7874E20E65 for ; Sat, 29 Aug 2020 06:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598682278; bh=rO56MVIvVtBfpXUiJzwAJauYsn+0k3epFv4DZf0v930=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ftn6GN6LzUNhV4qn3OgMZy8ZPAurSr8ex/i4TJKmtP2tm6DD/B2DINMOpka2qWRI9 3KP57HDWb0VrX+YZwyIg/sRmZQAtIrxsibW8EufOublY1/UAoh2ogghSwXlxPqBEap 4M/wNAHFPu81VBkzGr1xbt6yAzYNO9Y6n5NKRNK8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726405AbgH2GYe (ORCPT ); Sat, 29 Aug 2020 02:24:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:56310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbgH2GYe (ORCPT ); Sat, 29 Aug 2020 02:24:34 -0400 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23B6220E65; Sat, 29 Aug 2020 06:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598682273; bh=rO56MVIvVtBfpXUiJzwAJauYsn+0k3epFv4DZf0v930=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QlJAZyqSAmECnl4bbQSHcum5VHSkJCTsozVueyferoSttjlBPB/FITNMUinzNR1BP 5xEy1WY8WdAAqz+oR5fUnewT/d2Jrxy4VwXsfln3ZXy7B0hLk/iwFmCmwHnYd+3zn6 ALHbwBKZkLSF2l/4sgXjHvhaGv2AGyHDtZdZk/UA= Received: by mail-ej1-f41.google.com with SMTP id o18so1918888eje.7; Fri, 28 Aug 2020 23:24:33 -0700 (PDT) X-Gm-Message-State: AOAM531dv0fxsJg5a958//jsj61rs8FEMmgBm/sEsYn8VDBZAmI7ooJw 2K6Z7nScYxwExkLkuDekajpfaWPRfRmgT7QT9LI= X-Google-Smtp-Source: ABdhPJxPqtl25Mm9VQlnooxEKiADTie13uCG9BQK2ZeTNWjK59f8umoolhx1AO7I9ld//ckn9tNf3hs4c0nADZ6+a0Y= X-Received: by 2002:a17:906:3b4b:: with SMTP id h11mr2194097ejf.381.1598682271779; Fri, 28 Aug 2020 23:24:31 -0700 (PDT) MIME-Version: 1.0 References: <20200825193536.7332-1-krzk@kernel.org> <20200825193536.7332-13-krzk@kernel.org> <20200828213850.GA3444012@bogus> In-Reply-To: <20200828213850.GA3444012@bogus> From: Krzysztof Kozlowski Date: Sat, 29 Aug 2020 08:24:20 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 12/19] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching To: Rob Herring Cc: Fabio Estevam , Miquel Raynal , Fugang Duan , linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-gpio@vger.kernel.org, Thierry Reding , Anson Huang , Han Xu , linux-serial@vger.kernel.org, Li Yang , Sascha Hauer , Rob Herring , linux-arm-kernel@lists.infradead.org, Shawn Guo , Bartosz Golaszewski , Ulf Hansson , linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, Linus Walleij , Pengutronix Kernel Team , NXP Linux Team , Frank Li , Mark Rutland , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Fri, 28 Aug 2020 at 23:38, Rob Herring wrote: > > On Tue, 25 Aug 2020 21:35:29 +0200, Krzysztof Kozlowski wrote: > > The i.MX 8 DTSes use two compatibles so update the binding to fix > > dtbs_check warnings like: > > > > arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000: > > compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too long > > From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > > > arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000: > > compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected) > > > > arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: mmc@30b40000: > > compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too long > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v2: > > 1. Remove moved compatibles. > > > > Changes since v1: > > 1. Handle also fsl,imx8mm-usdhc and fsl,imx8qxp-usdhc > > --- > > .../bindings/mmc/fsl-imx-esdhc.yaml | 37 ++++++++++--------- > > 1 file changed, 20 insertions(+), 17 deletions(-) > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: compatible: ['fsl,imx8qxp-usdhc'] is not valid under any of the given schemas (Possible causes of the failure): > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: compatible: ['fsl,imx8qxp-usdhc'] is too short I will send a v4 just for this one patch. All others seem to be good. Best regards, Krzysztof