From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Mark Rutland <mark.rutland@arm.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Convert Samsung SoC watchdog bindings to json-schema
Date: Wed, 18 Sep 2019 13:26:29 +0200 [thread overview]
Message-ID: <CAJKOXPfsUw-+yRc=GF+t=1pE7D3dF_wpRUwZpmfLnRbDyEmKeQ@mail.gmail.com> (raw)
In-Reply-To: <20190912170145.GA17889@bogus>
On Fri, 13 Sep 2019 at 16:36, Rob Herring <robh@kernel.org> wrote:
>
> On Sat, Sep 07, 2019 at 04:45:40PM +0200, Krzysztof Kozlowski wrote:
> > Convert Samsung S3C/S5P/Exynos watchdog bindings to DT schema format
> > using json-schema.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > .../bindings/watchdog/samsung-wdt.txt | 35 ----------
> > .../bindings/watchdog/samsung-wdt.yaml | 69 +++++++++++++++++++
> > 2 files changed, 69 insertions(+), 35 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
> > create mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
>
>
> > diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> > new file mode 100644
> > index 000000000000..39f1ca3bc4db
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/samsung-wdt.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Samsung SoC Watchdog Timer Controller
> > +
> > +maintainers:
> > + - Krzysztof Kozlowski <krzk@kernel.org>
> > +
> > +description: |+
> > + The Samsung's Watchdog controller is used for resuming system operation
> > + after a preset amount of time during which the WDT reset event has not
> > + occurred.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - samsung,s3c2410-wdt # for S3C2410
> > + - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4
> > + - samsung,exynos5250-wdt # for Exynos5250
> > + - samsung,exynos5420-wdt # for Exynos5420
> > + - samsung,exynos7-wdt # for Exynos7
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + samsung,syscon-phandle:
> > + $ref: '/schemas/types.yaml#/definitions/phandle'
> > + description:
> > + Phandle to the PMU system controller node (in case of Exynos5250
> > + and Exynos5420).
> > +
> > + timeout-sec:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + Watchdog timeout in seconds.
>
> We need a common schema for this and the node name.
Common schema in dt-schema or in Linux kernel bindings? If the latter,
I can add it.
> Also note that anything with a unit suffix already has a type
> definition, so we don't really need to define it again.
Right.
Best regards,
Krzysztof
next prev parent reply other threads:[~2019-09-18 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 14:45 [PATCH 1/2] dt-bindings: watchdog: Convert Samsung SoC watchdog bindings to json-schema Krzysztof Kozlowski
2019-09-07 14:45 ` [PATCH 2/2] dt-bindings: watchdog: Add missing clocks requirement in Samsung SoC watchdog Krzysztof Kozlowski
2019-09-13 14:36 ` Rob Herring
2019-09-13 14:36 ` [PATCH 1/2] dt-bindings: watchdog: Convert Samsung SoC watchdog bindings to json-schema Rob Herring
2019-09-18 11:26 ` Krzysztof Kozlowski [this message]
2019-09-20 15:46 ` Rob Herring
2019-09-20 15:52 ` Rob Herring
2019-09-20 16:15 ` Krzysztof Kozlowski
2019-09-20 16:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPfsUw-+yRc=GF+t=1pE7D3dF_wpRUwZpmfLnRbDyEmKeQ@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).