From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BB31C678D5 for ; Wed, 8 Mar 2023 16:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232406AbjCHQKZ (ORCPT ); Wed, 8 Mar 2023 11:10:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232629AbjCHQKE (ORCPT ); Wed, 8 Mar 2023 11:10:04 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C9F750F92 for ; Wed, 8 Mar 2023 08:09:28 -0800 (PST) Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 347963F597 for ; Wed, 8 Mar 2023 16:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1678291766; bh=jxEkW8OFX3baFTB/CKLudkQuvhDNrRf95y5rQkRLsGE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=eyW/8nofgUFcTirYPvjZNN5tzG13OiiHcNT/UjW3PibbRfEvyY0MQZpTKJBByca4C 7p6XHBEkoElNIrx+I1nh3Cno3KMWj9CQZ6H2BECi9cFb8H76avmUjRwfhhcVNYb4ri J2TU0198xJsSzandzB0CsmzRmZCEXfkx7yT3s6b1+al61mE8gHYwamff2YAnJI/h0r OOpDfcawt6xSstGWc2vYYEzxsbX55ES7FDcppikHnW/70RdiscCNPcRiH+KP6Rthd+ 00sOGBWhyHcJjb1Bh9UFpzoPMVPxZ2AfnUYi8VVJ3UfiHrsJTcd23x8Lp+iPLrVdg8 1bXaphw6d8vJQ== Received: by mail-qv1-f70.google.com with SMTP id pm17-20020ad446d1000000b0057256b237b9so9513536qvb.16 for ; Wed, 08 Mar 2023 08:09:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678291765; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jxEkW8OFX3baFTB/CKLudkQuvhDNrRf95y5rQkRLsGE=; b=NbA1afILN/RQEpu5xKungsX3xKgNDFw2w6JN1ZWqdxt0ZfdMIp6eO/GsFFcDlvbBV9 YXq6vI6n0Yul2uM178QX0cwUjnbMLdEVaAo0oXH5XHD2HpvvZs+F0ezxLwVRyxIKP2P2 hVgvgFlZW1w4Y+HafICZ8dhLd7E4B9u5E+2GVG5zy4fMZ7iLQv3Z97y4YeAo4l7BOXTG HrSYSkJfg+gbCPHSdUIxzWq3RzyCEEaVBE9S5uowURYQXo+YuypdiKxvrbVzjSGpp1LB Vc93/uLJ1sjksnSLuHVYPuPfLJHqiay2BMiV33RGjYwdiwrSw3iptyAPN5qxzW+Ey+Pk lByg== X-Gm-Message-State: AO0yUKVbDf9CKW/3KNbiRBKDx926xl0rYvEG7+XbgE7mKexeFAK+2bH4 qJJEazb0OAPEX7S07Fub/ZOxtAoQaZV8oMHAM3TESjfa2Mj1acn/yUEYtCYYbgEm6wE+tt2GuZ3 uTsrGxmfQ+zo1bNkAitw34rVrmim73mlApxtaHA6eR4SKSSEKmDFCQmT+5+qU X-Received: by 2002:a05:620a:8416:b0:742:9899:98fb with SMTP id pc22-20020a05620a841600b00742989998fbmr4036587qkn.7.1678291765342; Wed, 08 Mar 2023 08:09:25 -0800 (PST) X-Google-Smtp-Source: AK7set9rDdUme+19ci4Y+eeQIQ1S8Pps6PmhEkfVr/t2a1f+TOq5hvLfQHCft/Xi0WgN485LzYzwIKfwYQUqflfbMR8= X-Received: by 2002:a05:620a:8416:b0:742:9899:98fb with SMTP id pc22-20020a05620a841600b00742989998fbmr4036581qkn.7.1678291765113; Wed, 08 Mar 2023 08:09:25 -0800 (PST) MIME-Version: 1.0 References: <20230308034036.99213-1-xingyu.wu@starfivetech.com> <20230308034036.99213-4-xingyu.wu@starfivetech.com> In-Reply-To: <20230308034036.99213-4-xingyu.wu@starfivetech.com> From: Emil Renner Berthing Date: Wed, 8 Mar 2023 17:09:09 +0100 Message-ID: Subject: Re: [PATCH v4 3/3] riscv: dts: starfive: jh7100: Add watchdog node To: Xingyu Wu Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , Rob Herring , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Samin Guo , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, 8 Mar 2023 at 04:42, Xingyu Wu wrote: > > Add watchdog node for the StarFive JH7100 RISC-V SoC. > > Signed-off-by: Xingyu Wu > --- > arch/riscv/boot/dts/starfive/jh7100.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/riscv/boot/dts/starfive/jh7100.dtsi b/arch/riscv/boot/dts/starfive/jh7100.dtsi > index 000447482aca..1eb7c21a94fd 100644 > --- a/arch/riscv/boot/dts/starfive/jh7100.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7100.dtsi > @@ -238,5 +238,15 @@ i2c3: i2c@12460000 { > #size-cells = <0>; > status = "disabled"; > }; > + > + wdog: watchdog@12480000 { I don't see anything referencing this node, so the label can be dropped. With that fixed: Reviewed-by: Emil Renner Berthing > + compatible = "starfive,jh7100-wdt"; > + reg = <0x0 0x12480000 0x0 0x10000>; > + clocks = <&clkgen JH7100_CLK_WDTIMER_APB>, > + <&clkgen JH7100_CLK_WDT_CORE>; > + clock-names = "apb", "core"; > + resets = <&rstgen JH7100_RSTN_WDTIMER_APB>, > + <&rstgen JH7100_RSTN_WDT>; > + }; > }; > }; > -- > 2.25.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv