From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61EB6CCA479 for ; Wed, 13 Jul 2022 16:51:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234827AbiGMQvf (ORCPT ); Wed, 13 Jul 2022 12:51:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229807AbiGMQvd (ORCPT ); Wed, 13 Jul 2022 12:51:33 -0400 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D94C328732; Wed, 13 Jul 2022 09:51:32 -0700 (PDT) Received: by mail-yb1-f173.google.com with SMTP id i206so3196785ybc.5; Wed, 13 Jul 2022 09:51:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MdioiXZT/1OLnUpB9pBiNBnK7JQURhyFx0+jkgyKxdU=; b=7kU/e5HedCwvp0CJpUsMat+/D8j3HNgqhmwhK48/i7CP26syszLHLl8lxPHF5eEgpf tKSEM2nOyUK2VQl/n9Y3E8QqtVGcsY+jKwa7Z/wfo2b27qMGGrDZVT33vAHzmz4+1wnk AtzPb6tkIpzeVfyeUmv0FZ+RswIJxqtY61MmyLkaGHYvSMp9q4ZN4Qguyi4ZKyYZYB/5 b7re3j+U1AIPqwE0Lv3EZ3vtWpRPO0L8ml7eEqVTkC/mFjdkFQXBvSiU+sAsY70szxyV egEPcdSaNGcgZR51VvzVqt0v4nw+wGyh5zcCTZQgDQnLY7bbZ1kHIrTzNRUlcqmRsggz ToRg== X-Gm-Message-State: AJIora+yovNd5Hh2/lO+McDmnon3uulI97nBP/W1mtERi10jUwpMJcS5 q2fD7ab9itNCgzPzswE4b3uWng08wJvUm+Alil8= X-Google-Smtp-Source: AGRyM1sJueCSFRWB/dmbyoEVbV54g4Smn3B8XwROXomGUfytxsBCHCBnHTGndijV3tmn86lXslhwloFgivU9XNq0Tnw= X-Received: by 2002:a25:a2ca:0:b0:66e:719e:279 with SMTP id c10-20020a25a2ca000000b0066e719e0279mr4399098ybn.622.1657731092034; Wed, 13 Jul 2022 09:51:32 -0700 (PDT) MIME-Version: 1.0 References: <20220606164138.66535-1-andriy.shevchenko@linux.intel.com> <20220629191406.35965d5b@md1za8fc.ad001.siemens.net> In-Reply-To: From: "Rafael J. Wysocki" Date: Wed, 13 Jul 2022 18:51:20 +0200 Message-ID: Subject: Re: [PATCH v6 00/12] platform/x86: introduce p2sb_bar() helper To: Andy Shevchenko Cc: Henning Schild , Lee Jones , "Rafael J. Wysocki" , Tony Luck , Wolfram Sang , Jean Delvare , Heiner Kallweit , Mika Westerberg , Hans de Goede , Linus Walleij , Jonathan Yong , Guenter Roeck , Wim Van Sebroeck , Linux Kernel Mailing List , "open list:EDAC-CORE" , linux-i2c , Linux LED Subsystem , "open list:GPIO SUBSYSTEM" , Platform Driver , LINUXWATCHDOG , Borislav Petkov , Mauro Carvalho Chehab , James Morse , Robert Richter , Jean Delvare , Pavel Machek , Peter Tyser , Andy Shevchenko , Mark Gross Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, Jul 13, 2022 at 6:40 PM Andy Shevchenko wrote: > > On Wed, Jun 29, 2022 at 07:14:06PM +0200, Henning Schild wrote: > > Am Wed, 29 Jun 2022 19:39:58 +0300 > > schrieb Andy Shevchenko : > > > > > +Cc: Rafael > > > > > > On Tue, Jun 21, 2022 at 02:58:16PM +0300, Andy Shevchenko wrote: > > > > On Wed, Jun 08, 2022 at 12:50:44PM +0200, Andy Shevchenko wrote: > > > > > On Wed, Jun 8, 2022 at 9:42 AM Lee Jones > > > > > wrote: > > > > > > On Mon, 06 Jun 2022, Andy Shevchenko wrote: > > > > > > > > > > > > > There are a few users that would like to utilize P2SB > > > > > > > mechanism of hiding and unhiding a device from the PCI > > > > > > > configuration space. > > > > > > > > > > > > > > Here is the series to consolidate p2sb handling code for > > > > > > > existing users and to provide a generic way for new comer(s). > > > > > > > > > > > > > > It also includes a patch to enable GPIO controllers on Apollo > > > > > > > Lake when it's used with ABL bootloader w/o ACPI support. > > > > > > > > > > > > > > The patch that brings the helper ("platform/x86/intel: Add > > > > > > > Primary to Sideband (P2SB) bridge support") has a commit > > > > > > > message that sheds a light on what the P2SB is and why this > > > > > > > is needed. > > > > > > > > > > > > > > I have tested this on Apollo Lake platform (I'm able to see > > > > > > > SPI NOR and since we have an ACPI device for GPIO I do not > > > > > > > see any attempts to recreate one). > > > > > > > > > > > > > > The series is ready to be merged via MFD tree, but see below. > > > > > > > > > > > > > > The series also includes updates for Simatic IPC drivers that > > > > > > > partially tagged by respective maintainers (the main question > > > > > > > is if Pavel is okay with the last three patches, since I > > > > > > > believe Hans is okay with removing some code under PDx86). > > > > > > > Hence the first 8 patches can be merged right away and the > > > > > > > rest when Pavel does his review. > > > > > > > > > > > > Can we just wait for Pavel's review, then merge them all at > > > > > > once? > > > > > > > > > > Sure, it would be the best course of action. > > > > > > > > Pavel, do you have a chance to review the patches (last three) that > > > > touch LED drivers? What would be your verdict? > > > > > > Lee, Rafael, > > > > > > It seems quite hard to get Pavel's attention to this series [1]. It's > > > already passed more than 3 weeks for any sign of review of three top > > > patches of the series that touched LED subsystem. The entire series > > > has all necessary tags, but for LED changes. > > > > > > Note, that the top of this series is not done by me and was sent for > > > preliminary review much earlier [2], altogether it makes months of no > > > response from the maintainer. > > > > > > The nature of patches is pretty simple and doesn't touch any of other > > > than Simatic LED drivers nor LED core. Moreover, it was written by > > > Siemens, who produces the H/W in question and very well tested as a > > > separate change and as part of the series. > > > > The code has been reviewed and is in fact pretty simple. The only > > questionable but pragmatic change that might catch the attention of a > > pedantic reviewer is that i did put the gpio implementation of the > > driver under the same/existing kernel config switch. > > > > > I think to move forward we may ask Rafael to review it on behalf of > > > good maintainer and with his approval apply entire series. > > > > > > Thoughts? > > > > Thanks for pushing this Andy. I was wondering how and when that story > > would continue. Technically these changes should really go in one badge > > or we need to find a way to separate them somehow. I would try to go > > that extra mile to get out of your way. But i am kind of afraid such an > > effort might also end up touching the same files and block us at the > > same maintainer. > > > > Did anyone check whether Pavel was active at all in those last months > > and maybe other patches waiting for review? Hope he is fine and active > > and just somehow forgot/overlooked/ignored this one. > > I have send a private mail to Pavel and have got no response. > Can we move this forward, let's say, by applying first 8 patches? IMV, everything up to and including patc [11/12] in the series should be good to go. There are ACKs from the relevant maintainers on that material and I'm not sure what Pavel can add to that TBH. > > > [1]: > > > https://lore.kernel.org/all/20220606164138.66535-1-andriy.shevchenko@linux.intel.com/ > > > [2]: > > > https://lore.kernel.org/linux-leds/20220513083652.974-1-henning.schild@siemens.com/ > >