From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D95C04AAC for ; Mon, 20 May 2019 15:19:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEE58216FD for ; Mon, 20 May 2019 15:19:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g39fxCpP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387444AbfETPTa (ORCPT ); Mon, 20 May 2019 11:19:30 -0400 Received: from mail-yw1-f67.google.com ([209.85.161.67]:43541 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732749AbfETPTa (ORCPT ); Mon, 20 May 2019 11:19:30 -0400 Received: by mail-yw1-f67.google.com with SMTP id t5so5991526ywf.10; Mon, 20 May 2019 08:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=plhElv+BUriUXkpSQXoRKCyimftsR0KZ9zPI/uX0VTQ=; b=g39fxCpP9jJ+hCzPERmfMVo1Ed4LieWjnbbF/wkeYiIRg/N0UscK7Q5MCGnojUCn6p A1FP94Fr43XeRPFA6q/WlPlOSQITHWQ4cqfvlpZq65nT5DzPAejfPlgmMyJrYy/PvfjV miI0HU5g0v4AwnjpQeLCHH9jDzcgLFn+VC+GbTe2j8/WvrOTZm9ipAm3Vn3V4w/h/Vot 8YkjSbBlbpv5aYTZ3F4Nokl8+Flm43x5+NZWUiHwD1c52YH9SbbEhVJCHj9Xv+nsQI1B OCm05MS1tOSwpWfH+p2PxVuVVQAnrOsKvk8S5vkwJoVKdYx5y5FMLp244JrFtfTfX16x oGGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=plhElv+BUriUXkpSQXoRKCyimftsR0KZ9zPI/uX0VTQ=; b=RpOuox7rEhJWruHgREowbgvG/0fbVhfLKg/favXZ2HqduAHdFaqj8RzTGh6Muev4tK IhGbdWn5deknA8vppvaqyJjC/H1cxgrLkedUr3PionKf61IzyjRERApbLK9wq3mkx3iI BvbJa/haMbZnZntCsICiAMrTxnHRkSr8XlO/WdaaQGql27RMtxEfquXCpvmaxCXQLbri cO1sUx36vQbHSGr4xn+XQszI0U9q/mvJqnkte22x3QkoqkB/Kw2sw/ItikoIdaNrX8ha tODagRTIHeZQI0Jy8nqCQFBXmORY6g3HZCAhDJY2QRfDLEI40HlvYEFGlTfIAyb2Pto2 B7gw== X-Gm-Message-State: APjAAAVjxXnRohAAcm+TwM2LpCbBf//a0iaTzApdPvBO79Qk3KXoV9Wj mlJUbU1hrRR3j7bxHDD5Vzr1Y9HbJ7Hhf5g/2Pc= X-Google-Smtp-Source: APXvYqwU/0+XEhwYF+YlLZjzvLcGA3xe1OksHMiGFtm34/k1x/2galfCzg4w8Pmv+zx4UnYDt1r8ZsHWOdXIM2EFcAw= X-Received: by 2002:a0d:ea4c:: with SMTP id t73mr35484753ywe.472.1558365569102; Mon, 20 May 2019 08:19:29 -0700 (PDT) MIME-Version: 1.0 References: <20190518152355.11134-1-peron.clem@gmail.com> <20190518152355.11134-4-peron.clem@gmail.com> In-Reply-To: <20190518152355.11134-4-peron.clem@gmail.com> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 20 May 2019 17:19:17 +0200 Message-ID: Subject: Re: [PATCH v3 3/4] arm64: dts: allwinner: h6: add r_watchog node To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai Cc: linux-watchdog@vger.kernel.org, devicetree , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Hi Maxime, On Sat, 18 May 2019 at 17:24, Cl=C3=A9ment P=C3=A9ron wrote: > > Allwinner H6 has a r_watchdog similar to A64. > > Declare it in the device-tree. > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/bo= ot/dts/allwinner/sun50i-h6.dtsi > index 60b47f23b2f5..27647e496269 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > @@ -632,6 +632,14 @@ > #reset-cells =3D <1>; > }; > > + r_watchdog: watchdog@7020400 { > + compatible =3D "allwinner,sun50i-h6-wdt", > + "allwinner,sun50i-a64-wdt", > + "allwinner,sun6i-a31-wdt"; > + reg =3D <0x07020400 0x20>; > + interrupts =3D ; Just want to point out that i have used the same bindings for WDT and R_WDT= . I think it would be better to also introduce a bindings like "allwinner,sun50i-h6-r-wdt", "allwinner,sun6i-a31-wdt"; We don't have access to the datasheet of this IP but we can strongly suppose that wdt and r-wdt are the same. What do you think? Regards, Clement > + }; > + > r_intc: interrupt-controller@7021000 { > compatible =3D "allwinner,sun50i-h6-r-intc", > "allwinner,sun6i-a31-r-intc"; > -- > 2.17.1 >