From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
linux-watchdog@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] dt-bindings: watchdog: add Allwinner H6 watchdog
Date: Mon, 20 May 2019 10:14:10 +0200 [thread overview]
Message-ID: <CAJiuCcdrW7RcEKePCr1DaL-be8dA5oOjvHdxYkiu=h37z2e7tw@mail.gmail.com> (raw)
In-Reply-To: <20190520073529.nxptfbibexrqyzfi@flea>
Hi Maxime,
On Mon, 20 May 2019 at 09:35, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Sat, May 18, 2019 at 05:23:52PM +0200, Clément Péron wrote:
> > Allwinner H6 has a similar watchdog as the A64 which is already
> > a compatible of the A31.
> >
> > This commit sort the lines and add the H6 compatible.
> >
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> > .../devicetree/bindings/watchdog/sunxi-wdt.txt | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt b/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
> > index 46055254e8dd..f4810f8ad1c5 100644
> > --- a/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
> > +++ b/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
> > @@ -3,10 +3,12 @@ Allwinner SoCs Watchdog timer
> > Required properties:
> >
> > - compatible : should be one of
> > - "allwinner,sun4i-a10-wdt"
> > - "allwinner,sun6i-a31-wdt"
> > - "allwinner,sun50i-a64-wdt","allwinner,sun6i-a31-wdt"
> > - "allwinner,suniv-f1c100s-wdt", "allwinner,sun4i-a10-wdt"
>
> That sorting was kind of intentional
Arg indeed, I will remove it.
>
> > + - "allwinner,sun4i-a10-wdt"
> > + - "allwinner,sun50i-a64-wdt","allwinner,sun6i-a31-wdt"
> > + - "allwinner,sun50i-h6-wdt","allwinner,sun50i-a64-wdt",
> > + "allwinner,sun6i-a31-wdt"
>
> Is there a reason to keep the A64 compatible?
Yes, A64 and H6 has the exact same memory mapping looking at the datasheet.
So if there is an errata or a new feature for the A64, it should be
also compatible with the H6.
Which is not the case with A31 (WDT_KEY_FIELD is not preset)
Thanks,
Clement
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
next prev parent reply other threads:[~2019-05-20 8:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 15:23 [PATCH v3 0/4] Allwinner H6 watchdog support Clément Péron
2019-05-18 15:23 ` [PATCH v3 1/4] dt-bindings: watchdog: add Allwinner H6 watchdog Clément Péron
2019-05-20 7:35 ` Maxime Ripard
2019-05-20 8:14 ` Clément Péron [this message]
2019-05-20 14:42 ` Maxime Ripard
2019-05-20 15:16 ` Clément Péron
2019-05-18 15:23 ` [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node Clément Péron
2019-05-20 7:36 ` Maxime Ripard
2019-05-20 8:21 ` Clément Péron
2019-05-20 14:44 ` Maxime Ripard
2019-05-20 14:57 ` Chen-Yu Tsai
2019-05-18 15:23 ` [PATCH v3 3/4] arm64: dts: allwinner: h6: add r_watchog node Clément Péron
2019-05-20 15:19 ` Clément Péron
2019-05-18 15:23 ` [PATCH v3 4/4] arm64: defconfig: enable sunxi watchdog Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJiuCcdrW7RcEKePCr1DaL-be8dA5oOjvHdxYkiu=h37z2e7tw@mail.gmail.com' \
--to=peron.clem@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).