Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	LINUXWATCHDOG <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v5 05/18] watchdog: cpwd: use generic compat_ptr_ioctl
Date: Tue, 8 Oct 2019 09:38:33 +0200
Message-ID: <CAK8P3a3bDnHRexRP7xntE_r=E4TfdnYqzAF_wrHwA35KjtGsfA@mail.gmail.com> (raw)
In-Reply-To: <20191007232832.GA26929@roeck-us.net>

On Tue, Oct 8, 2019 at 1:30 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Wed, Aug 14, 2019 at 10:42:32PM +0200, Arnd Bergmann wrote:
> > The cpwd_compat_ioctl() contains a bogus mutex that dates
> > back to a leftover BKL instance.
> >
> > Simplify the implementation by using the new compat_ptr_ioctl()
> > helper function that will do the right thing for all calls
> > here.
> >
> > Note that WIOCSTART/WIOCSTOP don't take any arguments, so
> > the compat_ptr() conversion is not needed here, but it also
> > doesn't hurt.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> This patch made it into the kernel, but the infrastructure didn't make it.
> Do we need to revert it ?

Sorry I had not realized that this patch got queued in the watchdog tree
and relied on the other patches. I ended up not sending the series after
a runtime regression in another driver, combined with the series not
having spent much time in linux-next before the merge window.

I've sent a fixup patch now that will make it do the right thing
regardless of my series, please apply that for v5.4.

        Arnd

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 20:42 [PATCH v5 00/18] compat_ioctl.c removal, part 2/3 Arnd Bergmann
2019-08-14 20:42 ` [PATCH v5 05/18] watchdog: cpwd: use generic compat_ptr_ioctl Arnd Bergmann
2019-08-15 18:06   ` Guenter Roeck
2019-10-07 23:28   ` Guenter Roeck
2019-10-08  7:38     ` Arnd Bergmann [this message]
2019-08-14 20:49 ` [PATCH v5 06/18] compat_ioctl: move WDIOC handling into wdt drivers Arnd Bergmann
2019-08-15 18:10   ` Guenter Roeck

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a3bDnHRexRP7xntE_r=E4TfdnYqzAF_wrHwA35KjtGsfA@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org linux-watchdog@archiver.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/ public-inbox