From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-28.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1047C4361B for ; Thu, 10 Dec 2020 23:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1BEA23BA7 for ; Thu, 10 Dec 2020 23:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731234AbgLJXBm (ORCPT ); Thu, 10 Dec 2020 18:01:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727312AbgLJXBX (ORCPT ); Thu, 10 Dec 2020 18:01:23 -0500 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23D6DC0613D3 for ; Thu, 10 Dec 2020 15:00:43 -0800 (PST) Received: by mail-pg1-x542.google.com with SMTP id w4so5664351pgg.13 for ; Thu, 10 Dec 2020 15:00:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zQXrB9GHmdvtRuHXM7RSGkfWQJp8dLu6UhfyqtSRnns=; b=oJI7rUjABIfze0dgGZkMr02FaZ9Jg88b/E/6azILua9cEMSFUPY9S96DxPyL9fxrPL udB81F6h5qsWBn1mWaU6OIs3oDjlDxQNZl2nf5Unsh0sh1DRxlxwlUXO0vPYPAPD9YeX RZcjccdsuz1XZBkTfpvqpIgSDfIkkAL2xZohx5CEIdhERACcOE6iHN+jdY7rqjoZd4Eq YHi0o5shX5UDJe9n1t+KDdlrP0wxeBq7ONEv7cIMvcnFPoT9FyjAVlcVYHMyHI2Kg6TB IsDwipXGvRU5c+/gWYiNGvaIOLzjTzOgu/VA8nANZWqF8k0nBp6P/jsFKNWyQDvCVgKK 0YvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zQXrB9GHmdvtRuHXM7RSGkfWQJp8dLu6UhfyqtSRnns=; b=ZVEJydIdZSYl7swdWg7BhUKoASRxqnTJc7SJJeoktAbwejXJlqSPQbiGkVHGhed/FT Sgzl57BvFNgculyN8i3jNNy90LCYzECsJe2gsY3HFOnl+qabhgft1rueFe5XwtBCoP+y amXI2Vmk/cVlOw79GUXKvEJ9eCETPnQcO+KZ88R73aiItuQMl6Q2gTlJ/3N8jawZS1ZE Od3/3+jUsNVjLOqY+/gdFw3YGOAgv2VSrQOthkZ/l1jns0GCdpAyp0UAcqPgwq3BHFg7 lPrCUrgLii8IQ0mPaohM0IBBLsCD1RzAWq97rpH8bvIy+15OTxtGJiE0DkFIkNIKNBdI PZ+A== X-Gm-Message-State: AOAM532x0YQrWgDJBvCANkzCBq12zOXn5aPsJfoTMw3bmj3PQNd8dPTD pOHAWoBSGsoo9DuRtc4YJtxy80tAjShcrOJBjl2yrNWevD+WAQ== X-Google-Smtp-Source: ABdhPJz0pxOCfgQlzNtv+0u+GyVi8pW0EKEaGpARy/XIY2lvHQuG2ZyvZwucRGGsuCqcNfyL98lVsF/WJiOSUtAVDtQ= X-Received: by 2002:a63:184c:: with SMTP id 12mr1301455pgy.381.1607641242592; Thu, 10 Dec 2020 15:00:42 -0800 (PST) MIME-Version: 1.0 References: <20201203223358.1269372-1-arnd@kernel.org> In-Reply-To: <20201203223358.1269372-1-arnd@kernel.org> From: Nick Desaulniers Date: Thu, 10 Dec 2020 15:00:30 -0800 Message-ID: Subject: Re: [PATCH] watchdog: coh901327: add COMMON_CLK dependency To: Arnd Bergmann Cc: Wim Van Sebroeck , Guenter Roeck , Nathan Chancellor , Arnd Bergmann , linux-watchdog@vger.kernel.org, LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Thu, Dec 3, 2020 at 2:34 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang produces a build failure in configurations without COMMON_CLK > when a timeout calculation goes wrong: > > arm-linux-gnueabi-ld: drivers/watchdog/coh901327_wdt.o: in function `coh901327_enable': > coh901327_wdt.c:(.text+0x50): undefined reference to `__bad_udelay' Isn't a linkage failure against __bad_udelay supposed to be interpreted as a value too large being passed to udelay()? IIRC, this was an issue for someone building an Apple touchpad driver with Clang at -O3...you sent a fix for that: https://github.com/ClangBuiltLinux/linux/issues/678, https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=fff2d0f701e6753591609739f8ab9be1c8e80ebb. > > Add a Kconfig dependency to only do build testing when COMMON_CLK > is enabled. > > Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible") > Signed-off-by: Arnd Bergmann > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 8bdbd125821b..32fa6de7b820 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -631,7 +631,7 @@ config SUNXI_WATCHDOG > > config COH901327_WATCHDOG > bool "ST-Ericsson COH 901 327 watchdog" > - depends on ARCH_U300 || (ARM && COMPILE_TEST) > + depends on ARCH_U300 || (ARM && COMMON_CLK && COMPILE_TEST) > default y if MACH_U300 > select WATCHDOG_CORE > help > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers