From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFA10C49EC7 for ; Thu, 17 Jun 2021 22:17:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE326613BA for ; Thu, 17 Jun 2021 22:17:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232301AbhFQWTU (ORCPT ); Thu, 17 Jun 2021 18:19:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:56494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232088AbhFQWTM (ORCPT ); Thu, 17 Jun 2021 18:19:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F0DD6613B4; Thu, 17 Jun 2021 22:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623968224; bh=8lLNvAQJFBYHcwyHgNEpUKH4liF//tJL8IXh/++g2VQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=huvrHHpH2Av8vejTexiFgCIX8gaey/rp/0fjLnRAt1uHvre0POa9FMvPn6CSKF4vP c1dyDYSMYo16eAP+y8b7jCtqCSK/GxM08QdxX1G394l3E8JBesdgSfezsVwCObf+XY 7aWLgTlzsBBO6TKNEHxE7nsZ/+OgD85yLW8ohdjh7wOtV4YkqobaNmS5taze+KHWCO fK6lrJ8I7DNEWJB2YicAQ/PLhU6Y66Is1uaJonoeXzDn/9t9wK0lIH/tQqckcXFuET u5Swl2hwja6dodRo6iE7Vpv+Vl8JR6ZLXVJxbLuKQjO/HsCiolAUliP6AHbf478B1T ZnwiO+IrhijxQ== Received: by mail-ej1-f42.google.com with SMTP id g8so12572868ejx.1; Thu, 17 Jun 2021 15:17:03 -0700 (PDT) X-Gm-Message-State: AOAM533H3WTBiNxJM6fB2cmYC7GQaa7pmWFlsaU47n2KIwiQ92m1Lq8f UK4pz+k6qhTXDxkxwrDizAPdZXHPBGMyCwOnhw== X-Google-Smtp-Source: ABdhPJxzgkf6C07sPN7yjl1phyvHCv9pAxXmIQ1iuWsb7n6aw/LK46UKCpGaWvweVtQco41YaA9gmDx268LBgSxFl4o= X-Received: by 2002:a17:907:264b:: with SMTP id ar11mr7391845ejc.525.1623968222450; Thu, 17 Jun 2021 15:17:02 -0700 (PDT) MIME-Version: 1.0 References: <20210615191543.1043414-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Thu, 17 Jun 2021 16:16:50 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems To: Suman Anna Cc: devicetree@vger.kernel.org, Andrew Lunn , Linux-ALSA , Daniel Lezcano , Alexandre Belloni , Guenter Roeck , "open list:IIO SUBSYSTEM AND DRIVERS" , PCI , Linus Walleij , Wim Van Sebroeck , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , Ulf Hansson , dri-devel , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , Linux I2C , linux-phy@lists.infradead.org, linux-riscv , Lee Jones , linux-clk , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , Lars-Peter Clausen , Herbert Xu , Bartosz Golaszewski , Marc Zyngier , Jassi Brar , Vinod Koul , Kishon Vijay Abraham I , David Airlie , "open list:SERIAL DRIVERS" , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Jakub Kicinski , Zhang Rui , Vivien Didelot , Wolfgang Grandegger , Linux Media Mailing List , Ohad Ben-Cohen , Linux PWM List , Albert Ou , LINUX-WATCHDOG , "open list:THERMAL" , linux-can@vger.kernel.org, "open list:GPIO SUBSYSTEM" , Mark Brown , Marc Kleine-Budde , Kamal Dasu , Paul Walmsley , Bjorn Helgaas , Krzysztof Kozlowski , Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel , Jens Axboe , Alessandro Zummo , Mathieu Poirier , Stephen Boyd , netdev , Philipp Zabel , Linux USB List , linux-mmc , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, iommu@lists.linux-foundation.org, Palmer Dabbelt , linux-crypto@vger.kernel.org, Daniel Vetter , Greg Kroah-Hartman , dmaengine@vger.kernel.org, Vladimir Oltean , "David S. Miller" , Jonathan Cameron Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Thu, Jun 17, 2021 at 10:06 AM Suman Anna wrote: > > Hi Rob, > > On 6/15/21 2:15 PM, Rob Herring wrote: > > If a property has an 'items' list, then a 'minItems' or 'maxItems' with= the > > same size as the list is redundant and can be dropped. Note that is DT > > schema specific behavior and not standard json-schema behavior. The too= ling > > will fixup the final schema adding any unspecified minItems/maxItems. > > > > This condition is partially checked with the meta-schema already, but > > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > > An improved meta-schema is pending. > > > > Cc: Jens Axboe > > Cc: Stephen Boyd > > Cc: Herbert Xu > > Cc: "David S. Miller" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Vinod Koul > > Cc: Bartosz Golaszewski > > Cc: Kamal Dasu > > Cc: Jonathan Cameron > > Cc: Lars-Peter Clausen > > Cc: Thomas Gleixner > > Cc: Marc Zyngier > > Cc: Joerg Roedel > > Cc: Jassi Brar > > Cc: Mauro Carvalho Chehab > > Cc: Krzysztof Kozlowski > > Cc: Ulf Hansson > > Cc: Jakub Kicinski > > Cc: Wolfgang Grandegger > > Cc: Marc Kleine-Budde > > Cc: Andrew Lunn > > Cc: Vivien Didelot > > Cc: Vladimir Oltean > > Cc: Bjorn Helgaas > > Cc: Kishon Vijay Abraham I > > Cc: Linus Walleij > > Cc: "Uwe Kleine-K=C3=B6nig" > > Cc: Lee Jones > > Cc: Ohad Ben-Cohen > > Cc: Mathieu Poirier > > Cc: Philipp Zabel > > Cc: Paul Walmsley > > Cc: Palmer Dabbelt > > Cc: Albert Ou > > Cc: Alessandro Zummo > > Cc: Alexandre Belloni > > Cc: Greg Kroah-Hartman > > Cc: Mark Brown > > Cc: Zhang Rui > > Cc: Daniel Lezcano > > Cc: Wim Van Sebroeck > > Cc: Guenter Roeck > > Signed-off-by: Rob Herring > > --- > > .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 1 - > > .../devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml | 2 -- > > .../devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 1 - > > Documentation/devicetree/bindings/clock/qcom,gcc-sdx55.yaml | 2 -- > > .../devicetree/bindings/clock/qcom,gcc-sm8350.yaml | 2 -- > > .../devicetree/bindings/clock/sprd,sc9863a-clk.yaml | 1 - > > .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 2 -- > > Documentation/devicetree/bindings/crypto/fsl-dcp.yaml | 1 - > > .../display/allwinner,sun4i-a10-display-backend.yaml | 6 ------ > > .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 1 - > > .../bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml | 4 ---- > > .../bindings/display/allwinner,sun8i-a83t-hdmi-phy.yaml | 2 -- > > .../bindings/display/allwinner,sun8i-r40-tcon-top.yaml | 2 -- > > .../devicetree/bindings/display/bridge/cdns,mhdp8546.yaml | 2 -- > > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 2 -- > > Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 -- > > .../devicetree/bindings/display/st,stm32-ltdc.yaml | 1 - > > .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 4 ---- > > .../devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - > > .../devicetree/bindings/edac/amazon,al-mc-edac.yaml | 2 -- > > Documentation/devicetree/bindings/eeprom/at24.yaml | 1 - > > Documentation/devicetree/bindings/example-schema.yaml | 2 -- > > Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 - > > Documentation/devicetree/bindings/gpu/vivante,gc.yaml | 1 - > > Documentation/devicetree/bindings/i2c/brcm,brcmstb-i2c.yaml | 1 - > > .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 2 -- > > .../devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml | 1 - > > .../devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml | 1 - > > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 -- > > .../bindings/interrupt-controller/fsl,irqsteer.yaml | 1 - > > .../bindings/interrupt-controller/loongson,liointc.yaml | 1 - > > Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml | 1 - > > .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 - > > .../devicetree/bindings/mailbox/st,stm32-ipcc.yaml | 2 -- > > .../devicetree/bindings/media/amlogic,gx-vdec.yaml | 1 - > > Documentation/devicetree/bindings/media/i2c/adv7604.yaml | 1 - > > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 1 - > > .../devicetree/bindings/media/qcom,sc7180-venus.yaml | 1 - > > .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 1 - > > .../devicetree/bindings/media/qcom,sm8250-venus.yaml | 1 - > > Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 - > > .../bindings/memory-controllers/mediatek,smi-common.yaml | 6 ++---- > > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 1 - > > .../devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml | 2 -- > > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 1 - > > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 -- > > Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 -- > > Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 1 - > > Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml | 1 - > > .../devicetree/bindings/net/amlogic,meson-dwmac.yaml | 2 -- > > .../devicetree/bindings/net/brcm,bcm4908-enet.yaml | 2 -- > > Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 2 -- > > Documentation/devicetree/bindings/net/dsa/brcm,sf2.yaml | 2 -- > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 -- > > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 1 - > > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 -- > > Documentation/devicetree/bindings/pci/loongson.yaml | 1 - > > .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 1 - > > .../devicetree/bindings/pci/microchip,pcie-host.yaml | 2 -- > > Documentation/devicetree/bindings/perf/arm,cmn.yaml | 1 - > > .../devicetree/bindings/phy/brcm,bcm63xx-usbh-phy.yaml | 1 - > > .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml | 3 --- > > Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 1 - > > Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 2 -- > > .../devicetree/bindings/phy/phy-cadence-sierra.yaml | 2 -- > > .../devicetree/bindings/phy/phy-cadence-torrent.yaml | 4 ---- > > .../devicetree/bindings/phy/qcom,ipq806x-usb-phy-hs.yaml | 1 - > > .../devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml | 1 - > > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 - > > Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 2 -- > > Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml | 2 -- > > Documentation/devicetree/bindings/phy/renesas,usb3-phy.yaml | 1 - > > .../devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml | 1 - > > .../devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml | 1 - > > .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 1 - > > .../devicetree/bindings/remoteproc/st,stm32-rproc.yaml | 2 -- > > .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 1 - > > .../devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml | 1 - > > Documentation/devicetree/bindings/reset/fsl,imx-src.yaml | 1 - > > .../devicetree/bindings/riscv/sifive-l2-cache.yaml | 1 - > > .../devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 1 - > > Documentation/devicetree/bindings/rtc/imxdi-rtc.yaml | 1 - > > Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 2 -- > > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 1 - > > .../devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 1 - > > Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 2 -- > > .../bindings/sound/nvidia,tegra-audio-graph-card.yaml | 1 - > > .../devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 2 -- > > Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 3 --- > > .../devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml | 1 - > > .../devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml | 2 -- > > .../bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 2 -- > > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 - > > .../bindings/timer/allwinner,sun5i-a13-hstimer.yaml | 1 - > > Documentation/devicetree/bindings/timer/arm,arch_timer.yaml | 1 - > > .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml | 2 -- > > .../devicetree/bindings/timer/intel,ixp4xx-timer.yaml | 1 - > > .../devicetree/bindings/usb/maxim,max3420-udc.yaml | 2 -- > > .../devicetree/bindings/usb/nvidia,tegra-xudc.yaml | 4 ---- > > Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 --- > > .../devicetree/bindings/watchdog/st,stm32-iwdg.yaml | 1 - > > 101 files changed, 2 insertions(+), 163 deletions(-) > > > > [snip] > > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rpr= oc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > > index 6070456a7b67..f399743b631b 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > > @@ -57,7 +57,6 @@ properties: > > > > memory-region: > > minItems: 2 > > - maxItems: 8 > > description: | > > phandle to the reserved memory nodes to be associated with the r= emoteproc > > device. There should be at least two reserved memory nodes defin= ed. The > > Does this enforce the maxItems to be 2 only now? Or should this be droppi= ng the > minItems here which matches the length of items instead of maxItems? > > I have originally listed the individual item list only for the mandatory = items > and rest are scalable. I provided this through "additionalItems: true" un= der > this property. Good catch. This should be dropped. The meta-schema doesn't enforce this if "additionalItems: true" which is rarely used. > Also, have the exact same usage in > Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml as well= which > is not included in this patch. Yeah, I just missed this one. I've double checked and there aren't any more= . Rob