From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E35A4CA9EAE for ; Tue, 29 Oct 2019 20:52:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A136121721 for ; Tue, 29 Oct 2019 20:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572382322; bh=v0+2wjHOV3TPOZBmkD3JlMqMySjlcS3TjLyd/H3+Vb0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=BNmm4vd13RqBt/IZkeY8BWMpkuwXNBd3/A/YMR5T9HLjvzoUEVLifIG/3nHvmwaxa vDTfDVwiXIGy1qMcUkjoD9yX3l10kBJ+LwLS2knXSVvYdpKLSlwXEEoBLgjny1Neap dpIVJvpltYXMamGROcE/7IA+nrmYa58CX0pX3Vus= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726679AbfJ2UwC (ORCPT ); Tue, 29 Oct 2019 16:52:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:35872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbfJ2UwC (ORCPT ); Tue, 29 Oct 2019 16:52:02 -0400 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BE8C21721; Tue, 29 Oct 2019 20:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572382320; bh=v0+2wjHOV3TPOZBmkD3JlMqMySjlcS3TjLyd/H3+Vb0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jeoJsxjjNE6CGSF/eDsifXtRv6MFoyej58BzCWJ9dtainNbQLHgEBmBOdDbzmlzS3 8mPLRij1NWGeikAECXh3rin5I3GSDRdDiraYmtN5V48K62fm2+iR+6UYtVtQYbGsuK QXNe/3IhAVfAR2fVXlHywPQiAUit8DyD+WOu+YwM= Received: by mail-qt1-f173.google.com with SMTP id c26so68604qtj.10; Tue, 29 Oct 2019 13:52:00 -0700 (PDT) X-Gm-Message-State: APjAAAW71O0biyQDk6Rxw/SfdSOV27hTey0JxQDJc7B49U1pyJVgrEju XlaCfBvYqeH1IyUYEmoHxFzHkkJrYTJ8wboW/w== X-Google-Smtp-Source: APXvYqyeg1I39tq2DqoXkraIzTHFUcqmrXNzXXgnb3VS9R2ReFwbWaEL1h/jcRIEbWALZ20wYKpj3bIc8bfKSrVHldc= X-Received: by 2002:ac8:65d5:: with SMTP id t21mr1315081qto.300.1572382319631; Tue, 29 Oct 2019 13:51:59 -0700 (PDT) MIME-Version: 1.0 References: <1571983984-11771-1-git-send-email-xingyu.chen@amlogic.com> <1571983984-11771-3-git-send-email-xingyu.chen@amlogic.com> <20191025203030.GA28391@bogus> <1914e315-3cb7-9251-f871-0024e0e4f68b@amlogic.com> In-Reply-To: <1914e315-3cb7-9251-f871-0024e0e4f68b@amlogic.com> From: Rob Herring Date: Tue, 29 Oct 2019 15:51:47 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog To: Xingyu Chen Cc: Wim Van Sebroeck , Guenter Roeck , Kevin Hilman , Neil Armstrong , Jerome Brunet , Qianggui Song , Jianxin Pan , Jian Hu , LINUX-WATCHDOG , "open list:ARM/Amlogic Meson..." , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Mon, Oct 28, 2019 at 3:35 AM Xingyu Chen wrote= : > > Hi, Rob > > On 2019/10/26 4:30, Rob Herring wrote: > > On Fri, Oct 25, 2019 at 02:13:02PM +0800, Xingyu Chen wrote: > >> The binding targets the Meson-A/C series compatible SoCs, in which the > >> watchdog registers are in secure world. > >> > >> Signed-off-by: Xingyu Chen > >> --- > >> .../bindings/watchdog/amlogic,meson-sec-wdt.yaml | 34 ++++++++++++= ++++++++++ > >> 1 file changed, 34 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/watchdog/amlogi= c,meson-sec-wdt.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-= sec-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec= -wdt.yaml > >> new file mode 100644 > >> index 00000000..0bbc807 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt= .yaml > >> @@ -0,0 +1,34 @@ > >> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >> +# Copyright (c) 2019 Amlogic, Inc > >> +%YAML 1.2 > >> +--- > >> +$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-wdt.yaml#= " > >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > >> + > >> +title: Amlogic Meson Secure Watchdog Timer > >> + > >> +maintainers: > >> + - Xingyu Chen > >> + > >> +description: |+ > >> + Secure Watchdog Timer used in Meson-A/C series Compatible SoCs > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - amlogic,meson-sec-wdt > > > > If there are no other properties, then you don't need this. Just have > > the secure firmware driver instantiate the watchdog. > I'am very sorry i don't understand how to initialize the watchdog driver > if the compatible property is removed, Could you give me more > suggestions or examples =EF=BC=9F Thank you very much. platform_device_register_simple() from the secure firmware driver. Rob