From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 421C1C49ED7 for ; Fri, 13 Sep 2019 10:36:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 147A4208C0 for ; Fri, 13 Sep 2019 10:36:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qhf0AlR2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729461AbfIMKga (ORCPT ); Fri, 13 Sep 2019 06:36:30 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:39116 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729390AbfIMKg3 (ORCPT ); Fri, 13 Sep 2019 06:36:29 -0400 Received: by mail-ed1-f66.google.com with SMTP id g12so929593eds.6 for ; Fri, 13 Sep 2019 03:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yoMobX+cp8FzXhuE26Q5iqWmU4wBMrUuYv1hKskRd6A=; b=Qhf0AlR2j+FSqbhmp1Fj7EAQaLxKBhepyLfpUOIiUsmhXO9jqJKrzDITuLM1MUNeW0 o/Tr3cee7IuwSejgIE4VBlFMQZWKuD+IxbnM6d3J7XHVfEIXViexzt7DbrOhyqfgwGKo eacId+Cr4sT3sTtp1nTEB8pKIY9YsR9FW7lObVWVdb/+wLDlQf4qvXM6UL0Fb90voIO5 uEx3E42KI9odugb/0Zl5vuqW+F1Pr875+M5rRDUpqqhe6hnGOA90vIpkgAYDW83fE0WV QmI1rG7t8BDos/V12GrP2PfN4qIupRWA40DfkwMiB/9Q0hJ1UY3imPN32L80fhhtup2q X+aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yoMobX+cp8FzXhuE26Q5iqWmU4wBMrUuYv1hKskRd6A=; b=ts9SQdOI1keyn8cDpkaq6w+kJ8JNrOTdCQEg7VYBR3Wxwzm0FYdvIhJ2OJgF4SnNDf 9ydaOw+cP7CNEN1Al8uCUKZ55+MX5tV1OVi+RpPvl9sNfj6C4sKF8ssfrM0Nz8qRbfZa eZFpljpRjCy+MWHffkYBErWMTw1xbFgmeRt7nD/B3EIBXWYfwrklTMU7flsVsOIaPKZw XKJ3DGOvSBE3KxguJlVa+gohN5/HTfzvxhMqSkQUlqg4rSiBhZgSBNA5k3grxroH9xFy enVK+w18/8kNI2fV0MLtH8/raO+5A2ikj+gsQA3YJtQU3GH6yB7tmOiw8Ws18c5p+p86 CNHQ== X-Gm-Message-State: APjAAAUsuvtpJqbuk+O+T6B7jXIyoie4aawCeUVWDfdGtDVn9ogR5/GT T/nThlN9VMBI9BlDkXOs++JydfR+rIMQuqu0MNSP7Q== X-Google-Smtp-Source: APXvYqwPsnLfPQsWRGtRzHOng4f3SNonXdca+U/1zyNzOoIoq5wS6PXilOsiEpbAp7R0tF/s1gfw/IIzuqRmdfb84fk= X-Received: by 2002:a17:906:b34a:: with SMTP id cd10mr38860564ejb.300.1568370987905; Fri, 13 Sep 2019 03:36:27 -0700 (PDT) MIME-Version: 1.0 References: <20190906203054.26725-1-jorge.ramirez-ortiz@linaro.org> <4231aab1-c538-a14f-cea1-ceb28781c7bb@roeck-us.net> <20190911175453.GA31612@roeck-us.net> In-Reply-To: <20190911175453.GA31612@roeck-us.net> From: Loic Poulain Date: Fri, 13 Sep 2019 12:36:55 +0200 Message-ID: Subject: Re: [PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow To: Guenter Roeck Cc: Jorge Ramirez-Ortiz , wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson Content-Type: text/plain; charset="UTF-8" Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, 11 Sep 2019 at 19:54, Guenter Roeck wrote: > > On Wed, Sep 11, 2019 at 10:04:12AM +0200, Loic Poulain wrote: > > Hi Guenter, Jorge, > > > > On Mon, 9 Sep 2019 at 00:50, Guenter Roeck wrote: > > > > > On 9/6/19 1:30 PM, Jorge Ramirez-Ortiz wrote: > > > > When an IRQ is present in the dts, the probe function shall fail if > > > > the interrupt can not be registered. > > > > > > > > > > The author intended differently, and did not want registration to fail > > > in this situation, following the logic that it is better to have a > > > standard watchdog without pretimeout than no watchdog at all. > > > > > > > Indeed, but I tend to agree with this change since it aligns behavior with > > other > > watchdog drivers and I assume there is a serious issue if request_irq fails. > > I suggest adding a dev_err message in such case. > > > > Copying the author; I am not inclined to accept such a change without > > > input from the driver author. > > > > > > Similar, for the deferred probe, we'll need to know from the driver author > > > if this is a concern. In general it is, but there are cases where > > > -EPROBE_DEFFER is never returned in practice (eg for some SoC watchdog > > > drivers). > > > > > > > The IRQ controller is the SPMI bus parent node whose driver (MFD_SPMI_PMIC) > > is a direct dependency of pm8916_wdt. I'm not sure in which scenario this > > could > > happen. > > > Not sure what the action item is. Accept the patch as-is (Reviewed-by > appreciated), or resubmit without the -EPROBE_DEFER check ? Reviewed-by: Loic Poulain