From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F86FC433DB for ; Tue, 22 Dec 2020 08:27:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2423123124 for ; Tue, 22 Dec 2020 08:27:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725783AbgLVI1S (ORCPT ); Tue, 22 Dec 2020 03:27:18 -0500 Received: from mail-ot1-f54.google.com ([209.85.210.54]:35259 "EHLO mail-ot1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725300AbgLVI1S (ORCPT ); Tue, 22 Dec 2020 03:27:18 -0500 Received: by mail-ot1-f54.google.com with SMTP id i6so11290281otr.2; Tue, 22 Dec 2020 00:27:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KHNVKftY48PjyeGHYfK+vLHEafMZdXMutCS+6rlBWJk=; b=rBr4Ns6n7htrXbf3hNQhyL6/gaIAiOTDXhsv1Yxkuy+Q1gzn/qhvAExpmlUjeMTB/1 QmeYOFeQ7WLI6v+5Fj74PrC2yS7JlwsJEMHUhhuz9qj3GSYefpqBd1qFSHIodAQa5XFd e7+HlJbWSIRFmmgP6+m6A7I1hlmYmuyHg54Em7bs5Ow2ahcaTjRB5jOD8zKqdQs5+qFP FqMd8xOF/xYCT/U4uBwyom8LcTVH2dDx6o/nLxJFTOyd/fClZ4YDG45Q1dChPQJ+UW9a OOH9i+9LgJ/Jg5lkHwlid1wdbww0JyDWxyS0mzLve5ar6LT7HmMDFLi2Gan/JFcJw5Ps vZ6Q== X-Gm-Message-State: AOAM530y6qCwK/DqaNEDp3t2ATiynffV4h3rFp0PxFJdXFC1VGSWyWr8 wnOR+hYMJTZ6Mw0+qS7nuONEHZaefpNLXfZlSx+mb+Mf X-Google-Smtp-Source: ABdhPJxzAJBHivxcUGyQbpokh/3pVGnEnrFqsE+3rgGYlRzK8MAW5zYyTV70+oczD506KLlhURNhIiAsUtmfnkzY0Do= X-Received: by 2002:a9d:c01:: with SMTP id 1mr400113otr.107.1608625597379; Tue, 22 Dec 2020 00:26:37 -0800 (PST) MIME-Version: 1.0 References: <20201219173415.21848-1-wsa+renesas@sang-engineering.com> In-Reply-To: <20201219173415.21848-1-wsa+renesas@sang-engineering.com> From: Geert Uytterhoeven Date: Tue, 22 Dec 2020 09:26:26 +0100 Message-ID: Subject: Re: [PATCH] watchdog: renesas_wdt: don't sleep in atomic context To: Wolfram Sang Cc: Linux Watchdog Mailing List , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Sat, Dec 19, 2020 at 6:36 PM Wolfram Sang wrote: > In the restart handler, we hit multiple OOPSes. One because of > usleep_range() and one because of RPM. So, instead of re-using > rwdt_start(), we implement an atomic version of it in the restart > handler. As a little bonus, reboot will occur sooner because we can now > use the smallest divider in the custom restart routine. > > Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds