From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7AABC35660 for ; Fri, 21 Feb 2020 19:42:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE2CE24670 for ; Fri, 21 Feb 2020 19:42:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OOj04mF2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726767AbgBUTmB (ORCPT ); Fri, 21 Feb 2020 14:42:01 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:44715 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727053AbgBUTmA (ORCPT ); Fri, 21 Feb 2020 14:42:00 -0500 Received: by mail-io1-f66.google.com with SMTP id z16so3579071iod.11 for ; Fri, 21 Feb 2020 11:41:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WPEkVNQNo6+YwuuDTJ8f8LWVOUVBTxJ7HCWvWKezvwM=; b=OOj04mF2+3yRsYgUDM4psSLvDVhPp3+mkxUO1ZzxFRyV2BpOHmDVNSaSg0Nf+m0Jvv g0iOef6Ch4C7hb4JDOA4KgPfcuXgKOre6matGbVL9twWijFXGJ0NeeRfME4dB6V33VJK mrf7dJ5OaUo00VZfHhlyludpRW1y7L1C8zfQI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WPEkVNQNo6+YwuuDTJ8f8LWVOUVBTxJ7HCWvWKezvwM=; b=eJTO/PZdKpPmR3lRGYPa1/UncFucKDCii8qKrkCIw5NtGChT+jFsGOoeDvprvDzwiY kFpqJW9CIDZ9TwNwoR/p479DW00hpA2zBgMbNgiwztsIJN2PC79/RjjFne4lURVCIDSo q6cpRuSAy1WriJ4h9ROvZUG0I+z0OmkQ6k9iLG/ADK7Cfq8f7bj6UVPQM185dUUf4MVx sGAl7aRjuxEykpLdVrfI2PwK9BcBKmYyHnoe+t6fI9vNkomc/3wB9NE/bwrj4nUR7/Px zo0kgqpkPwFbk0hJP7F4Ex+yr53aGONVprQlrp1FcddFan4pftCEkBBmOLLSZ71rLeZ2 cKoQ== X-Gm-Message-State: APjAAAXNtErZ98I1f7AkvJcTCmBFORgDVu3+OjCURfNbYEbFS3Nga0fh MUTlndNqyPA0S3yygFUV8zItkaTYoNS4YaO75mezgA== X-Google-Smtp-Source: APXvYqyhv6yoRrvJUuENNKPAWV05pjT3Uyf9H3bCQETX5SOA9ofYJ2wSIn+d5yP6cxreX1ktp9sFgfx2+GHoYNL0c/U= X-Received: by 2002:a6b:7117:: with SMTP id q23mr31725213iog.153.1582314118577; Fri, 21 Feb 2020 11:41:58 -0800 (PST) MIME-Version: 1.0 References: <20200214062637.216209-1-evanbenn@chromium.org> <20200214172512.1.I02ebc5b8743b1a71e0e15f68ea77e506d4e6f840@changeid> <20200219223046.GA16537@bogus> <20200219232005.GA9737@roeck-us.net> In-Reply-To: From: Julius Werner Date: Fri, 21 Feb 2020 11:41:47 -0800 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible To: Xingyu Chen Cc: Evan Benn , Julius Werner , Guenter Roeck , Rob Herring , LKML , devicetree@vger.kernel.org, "David S. Miller" , Jonathan Cameron , Mauro Carvalho Chehab , Wim Van Sebroeck , Greg Kroah-Hartman , Mark Rutland , linux-watchdog@vger.kernel.org, Jianxin Pan , Yonghui Yu Content-Type: text/plain; charset="UTF-8" Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org > Because the ATF does not define standard wdt index, each vendor defines > its own index. > So I don't think that the current driver[0] can fully cover my usecases. I think the best way to solve this would be to put the SMC function ID as another field into the device tree, so that multiple vendors could share the same driver even if their firmware interface uses a different SMC. But they still have to implement the same API for that SMC, of course, not sure if the Meson driver is suitable for that (but if it is then I think merging those drivers would be a good idea).